All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Rogers <irogers@google.com>
To: John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
	James Clark <james.clark@arm.com>,
	Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Andi Kleen <ak@linux.intel.com>,
	Zhengjun Xing <zhengjun.xing@linux.intel.com>,
	Ravi Bangoria <ravi.bangoria@amd.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH v5 03/14] perf jevents: Provide path to json file on error
Date: Fri, 12 Aug 2022 16:09:38 -0700	[thread overview]
Message-ID: <20220812230949.683239-4-irogers@google.com> (raw)
In-Reply-To: <20220812230949.683239-1-irogers@google.com>

If a JSONDecoderError or similar is raised then it is useful to know the
path. Print this and then raise the exception agan.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/pmu-events/jevents.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
index 8e8462cb359b..31936eafa9ff 100755
--- a/tools/perf/pmu-events/jevents.py
+++ b/tools/perf/pmu-events/jevents.py
@@ -225,7 +225,12 @@ class JsonEvent:
 
 def read_json_events(path: str) -> Sequence[JsonEvent]:
   """Read json events from the specified file."""
-  return json.load(open(path), object_hook=lambda d: JsonEvent(d))
+
+  try:
+    return json.load(open(path), object_hook=lambda d: JsonEvent(d))
+  except BaseException as err:
+    print(f"Exception processing {path}")
+    raise
 
 
 def preprocess_arch_std_files(archpath: str) -> None:
-- 
2.37.1.595.g718a3a8f04-goog


WARNING: multiple messages have this Message-ID (diff)
From: Ian Rogers <irogers@google.com>
To: John Garry <john.garry@huawei.com>, Will Deacon <will@kernel.org>,
	 James Clark <james.clark@arm.com>,
	Mike Leach <mike.leach@linaro.org>,  Leo Yan <leo.yan@linaro.org>,
	Peter Zijlstra <peterz@infradead.org>,
	 Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	 Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>,  Namhyung Kim <namhyung@kernel.org>,
	Andi Kleen <ak@linux.intel.com>,
	 Zhengjun Xing <zhengjun.xing@linux.intel.com>,
	Ravi Bangoria <ravi.bangoria@amd.com>,
	 Kan Liang <kan.liang@linux.intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	 linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-perf-users@vger.kernel.org
Cc: Stephane Eranian <eranian@google.com>, Ian Rogers <irogers@google.com>
Subject: [PATCH v5 03/14] perf jevents: Provide path to json file on error
Date: Fri, 12 Aug 2022 16:09:38 -0700	[thread overview]
Message-ID: <20220812230949.683239-4-irogers@google.com> (raw)
In-Reply-To: <20220812230949.683239-1-irogers@google.com>

If a JSONDecoderError or similar is raised then it is useful to know the
path. Print this and then raise the exception agan.

Signed-off-by: Ian Rogers <irogers@google.com>
---
 tools/perf/pmu-events/jevents.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/perf/pmu-events/jevents.py b/tools/perf/pmu-events/jevents.py
index 8e8462cb359b..31936eafa9ff 100755
--- a/tools/perf/pmu-events/jevents.py
+++ b/tools/perf/pmu-events/jevents.py
@@ -225,7 +225,12 @@ class JsonEvent:
 
 def read_json_events(path: str) -> Sequence[JsonEvent]:
   """Read json events from the specified file."""
-  return json.load(open(path), object_hook=lambda d: JsonEvent(d))
+
+  try:
+    return json.load(open(path), object_hook=lambda d: JsonEvent(d))
+  except BaseException as err:
+    print(f"Exception processing {path}")
+    raise
 
 
 def preprocess_arch_std_files(archpath: str) -> None:
-- 
2.37.1.595.g718a3a8f04-goog


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-08-12 23:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12 23:09 [PATCH v5 00/14] Compress the pmu_event tables Ian Rogers
2022-08-12 23:09 ` Ian Rogers
2022-08-12 23:09 ` [PATCH v5 01/14] perf jevent: Add an 'all' architecture argument Ian Rogers
2022-08-12 23:09   ` Ian Rogers
2022-08-12 23:09 ` [PATCH v5 02/14] perf jevents: Remove the type/version variables Ian Rogers
2022-08-12 23:09   ` Ian Rogers
2022-08-12 23:09 ` Ian Rogers [this message]
2022-08-12 23:09   ` [PATCH v5 03/14] perf jevents: Provide path to json file on error Ian Rogers
2022-08-12 23:09 ` [PATCH v5 04/14] perf jevents: Sort json files entries Ian Rogers
2022-08-12 23:09   ` Ian Rogers
2022-08-12 23:09 ` [PATCH v5 05/14] perf pmu-events: Hide pmu_sys_event_tables Ian Rogers
2022-08-12 23:09   ` Ian Rogers
2022-08-12 23:09 ` [PATCH v5 06/14] perf pmu-events: Avoid passing pmu_events_map Ian Rogers
2022-08-12 23:09   ` Ian Rogers
2022-08-12 23:09 ` [PATCH v5 07/14] perf pmu-events: Hide pmu_events_map Ian Rogers
2022-08-12 23:09   ` Ian Rogers
2022-08-12 23:09 ` [PATCH v5 08/14] perf test: Use full metric resolution Ian Rogers
2022-08-12 23:09   ` Ian Rogers
2022-08-12 23:09 ` [PATCH v5 09/14] perf pmu-events: Move test events/metrics to json Ian Rogers
2022-08-12 23:09   ` Ian Rogers
2022-08-12 23:09 ` [PATCH v5 10/14] perf pmu-events: Don't assume pmu_event is an array Ian Rogers
2022-08-12 23:09   ` Ian Rogers
2022-08-12 23:09 ` [PATCH v5 11/14] perf pmu-events: Hide the pmu_events Ian Rogers
2022-08-12 23:09   ` Ian Rogers
2022-08-12 23:09 ` [PATCH v5 12/14] perf metrics: Copy entire pmu_event in find metric Ian Rogers
2022-08-12 23:09   ` Ian Rogers
2022-08-12 23:09 ` [PATCH v5 13/14] perf jevents: Compress the pmu_events_table Ian Rogers
2022-08-12 23:09   ` Ian Rogers
2022-08-12 23:09 ` [PATCH v5 14/14] perf jevents: Fold strings optimization Ian Rogers
2022-08-12 23:09   ` Ian Rogers
2022-08-13 18:03 ` [PATCH v5 00/14] Compress the pmu_event tables Arnaldo Carvalho de Melo
2022-08-13 18:03   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220812230949.683239-4-irogers@google.com \
    --to=irogers@google.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=eranian@google.com \
    --cc=james.clark@arm.com \
    --cc=john.garry@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=kan.liang@linux.intel.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@linaro.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    --cc=will@kernel.org \
    --cc=zhengjun.xing@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.