From: Christoph Hellwig <hch@lst.de>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org,
Zygo Blaxell <ce3g8jdj@umail.furryterror.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] Revert "btrfs: fix repair of compressed extents" and "btrfs: pass a btrfs_bio to btrfs_repair_one_sector"
Date: Sat, 13 Aug 2022 08:19:01 +0200 [thread overview]
Message-ID: <20220813061901.GA10401@lst.de> (raw)
In-Reply-To: <09b666a5e355472749a243946a9199ce2d6cef77.1660370422.git.wqu@suse.com>
On Sat, Aug 13, 2022 at 02:00:25PM +0800, Qu Wenruo wrote:
> To fix the problem, we need to revert commit 7aa51232e204 ("btrfs: pass
> a btrfs_bio to btrfs_repair_one_sector"), but unfortunately later commit
> 81bd9328ab9f ("btrfs: fix repair of compressed extents") has a
> dependency on that commit.
Let's try to sort this out properly intead of doing a blind revert before
-rc1. I'll cook up a patch to pass an explicit offset ASAP as the quick
fix, but for the longer run: is there such a huge benefit of having
these logically non-contigous bios? They are so different from the
I/O stack in any other file systems that I think we'll keep running into
problems again an again.
next prev parent reply other threads:[~2022-08-13 6:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 6:00 [PATCH] Revert "btrfs: fix repair of compressed extents" and "btrfs: pass a btrfs_bio to btrfs_repair_one_sector" Qu Wenruo
2022-08-13 6:19 ` Christoph Hellwig [this message]
2022-08-13 6:53 ` Qu Wenruo
2022-08-13 6:58 ` Qu Wenruo
2022-08-13 7:02 ` Christoph Hellwig
2022-08-13 7:06 ` Qu Wenruo
2022-08-13 7:12 ` Christoph Hellwig
2022-08-13 6:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220813061901.GA10401@lst.de \
--to=hch@lst.de \
--cc=ce3g8jdj@umail.furryterror.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.