From: Christoph Hellwig <hch@lst.de>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@lst.de>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org,
Zygo Blaxell <ce3g8jdj@umail.furryterror.org>
Subject: Re: [PATCH] Revert "btrfs: fix repair of compressed extents" and "btrfs: pass a btrfs_bio to btrfs_repair_one_sector"
Date: Sat, 13 Aug 2022 09:12:49 +0200 [thread overview]
Message-ID: <20220813071249.GA11285@lst.de> (raw)
In-Reply-To: <f9ccaa97-3616-8611-614b-4ea9f73a38a0@gmx.com>
On Sat, Aug 13, 2022 at 03:06:12PM +0800, Qu Wenruo wrote:
> But my question is, do this behavior has any perf benefit?
>
> IIRC block layer should be more clever than us?
It will slightly reduce memory usage as no other bio is allocated,
and it will save a small number of CPU cycles because there is no
need to perform the merge. But compared to the complexity I doubt
it is worth it.
next prev parent reply other threads:[~2022-08-13 7:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 6:00 [PATCH] Revert "btrfs: fix repair of compressed extents" and "btrfs: pass a btrfs_bio to btrfs_repair_one_sector" Qu Wenruo
2022-08-13 6:19 ` Christoph Hellwig
2022-08-13 6:53 ` Qu Wenruo
2022-08-13 6:58 ` Qu Wenruo
2022-08-13 7:02 ` Christoph Hellwig
2022-08-13 7:06 ` Qu Wenruo
2022-08-13 7:12 ` Christoph Hellwig [this message]
2022-08-13 6:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220813071249.GA11285@lst.de \
--to=hch@lst.de \
--cc=ce3g8jdj@umail.furryterror.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.