From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Stefan Agner <stefan@agner.ch>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/docker-engine: use kernel modules for extra network drivers
Date: Sat, 13 Aug 2022 13:51:37 +0200 [thread overview]
Message-ID: <20220813115137.GA2741326@scaer> (raw)
In-Reply-To: <2ba3394abf87c940fe036b2e18e1afc2a2d37ad0.1660320356.git.stefan@agner.ch>
Stefan, All,
On 2022-08-12 18:07 +0200, Stefan Agner spake thusly:
> Docker network driver "overlay", "macvlan" and "ipvlan" are not used
> by default. Make them a module.
>
> The main aim here is to get rid of the dummy0 network interface which
> is generated by the dummy driver by default. For consistency, make
> all kernel drivers required for Docker network drivers a module. Also
> add the currently missing CONFIG_BRIDGE_VLAN_FILTERING (mandatory
> for the Docker network driver "overlay").
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> package/docker-engine/docker-engine.mk | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/package/docker-engine/docker-engine.mk b/package/docker-engine/docker-engine.mk
> index 293af1858c..730f2e3b86 100644
> --- a/package/docker-engine/docker-engine.mk
> +++ b/package/docker-engine/docker-engine.mk
> @@ -124,10 +124,11 @@ define DOCKER_ENGINE_LINUX_CONFIG_FIXUPS
> $(call KCONFIG_ENABLE_OPT,CONFIG_IP_NF_TARGET_MASQUERADE)
> $(call KCONFIG_ENABLE_OPT,CONFIG_BRIDGE)
> $(call KCONFIG_ENABLE_OPT,CONFIG_NET_CORE)
> - $(call KCONFIG_ENABLE_OPT,CONFIG_DUMMY)
> - $(call KCONFIG_ENABLE_OPT,CONFIG_MACVLAN)
> - $(call KCONFIG_ENABLE_OPT,CONFIG_IPVLAN)
> - $(call KCONFIG_ENABLE_OPT,CONFIG_VXLAN)
> + $(call KCONFIG_SET_OPT,CONFIG_DUMMY,m)
> + $(call KCONFIG_SET_OPT,CONFIG_MACVLAN,m)
> + $(call KCONFIG_SET_OPT,CONFIG_IPVLAN,m)
> + $(call KCONFIG_SET_OPT,CONFIG_VXLAN,m)
> + $(call KCONFIG_SET_OPT,CONFIG_BRIDGE_VLAN_FILTERING,m)
That entirely overrides the options from the configuration file provided
by the user, if they have and require any of those options set as =y.
I think that what we need, is to have a helper KCONFIG_ENABLE_OPT_MOD,
which only sets an option to 'm' if it is not already 'y' (i.e. the
opposite of KCONFIG_ENABLE_OPT).
Regards,
Yann E. MORIN.
> $(call KCONFIG_ENABLE_OPT,CONFIG_VETH)
> $(call KCONFIG_ENABLE_OPT,CONFIG_OVERLAY_FS)
> $(call KCONFIG_ENABLE_OPT,CONFIG_KEYS)
> --
> 2.37.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-13 11:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 16:07 [Buildroot] [PATCH] package/docker-engine: use kernel modules for extra network drivers Stefan Agner
2022-08-13 11:51 ` Yann E. MORIN [this message]
2022-08-14 21:27 ` Arnout Vandecappelle
2022-08-14 21:46 ` Yann E. MORIN
2022-08-15 9:36 ` Thomas Petazzoni via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220813115137.GA2741326@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.