All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Romain Naour <romain.naour@gmail.com>,
	Giulio Benetti <giulio.benetti@benettiengineering.com>,
	Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/binutils: handle gprofng as an optional feature
Date: Sat, 13 Aug 2022 23:43:16 +0200	[thread overview]
Message-ID: <20220813214316.GA2830119@scaer> (raw)
In-Reply-To: <20220813105152.1403602-1-thomas.petazzoni@bootlin.com>

Thomas, All,

On 2022-08-13 12:51 +0200, Thomas Petazzoni via buildroot spake thusly:
> binutils 2.39 added support for gprofng, a new profiler (see
> https://www.phoronix.com/news/GNU-Profiler-gprofng).
> 
> This new profiler is enabled by default, but it requires bison on the
> host.
> 
> In order to handle this, this commit:
> 
>  - Adds a new option BR2_BINUTILS_GPROFNG, which allows to
>    enable/disable gprofng in host-binutils

I was wondering if we should not just unconditionally build it. The
overhead of building host-bison and its dependencies is probably very
low when compared to the rest of the toolchain, especially with TLPB.

But OK, option it is...

> diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
> index a3fece27dc..e4cb19896d 100644
> --- a/package/binutils/binutils.mk
> +++ b/package/binutils/binutils.mk
[--SNIP--]
> @@ -91,6 +92,13 @@ HOST_BINUTILS_CONF_OPTS = \
>  	$(BINUTILS_DISABLE_GDB_CONF_OPTS) \
>  	$(BINUTILS_EXTRA_CONFIG_OPTIONS)
>  
> +ifeq ($(BR2_BINUTILS_GPROFNG),y)
> +HOST_BINUTILS_DEPENDENCIES += host-bison
> +HOST_INBUTILS_CONF_OPTS += --enable-gprofng
> +else
> +HOST_INBUTILS_CONF_OPTS += --disable-gprofng

    $ make check-package
    package/binutils/binutils.mk:97: possible typo: HOST_INBUTILS_CONF_OPTS -> *BINUTILS*
    package/binutils/binutils.mk:99: possible typo: HOST_INBUTILS_CONF_OPTS -> *BINUTILS*

Untested code? ;-)

Applied to next, with the above fixed, thanks.

Regards,
Yann E. MORIN.

> +endif
> +
>  # binutils run configure script of subdirs at make time, so ensure
>  # our TARGET_CONFIGURE_ARGS are taken into consideration for those
>  BINUTILS_MAKE_ENV = $(TARGET_CONFIGURE_ARGS)
> -- 
> 2.37.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-08-13 21:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-13 10:51 [Buildroot] [PATCH] package/binutils: handle gprofng as an optional feature Thomas Petazzoni via buildroot
2022-08-13 21:43 ` Yann E. MORIN [this message]
2022-08-13 21:46   ` Thomas Petazzoni via buildroot
2022-08-14 15:15     ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220813214316.GA2830119@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=romain.naour@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.