From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Romain Naour <romain.naour@gmail.com>,
Giulio Benetti <giulio.benetti@benettiengineering.com>,
Buildroot List <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] package/binutils: handle gprofng as an optional feature
Date: Sat, 13 Aug 2022 23:46:06 +0200 [thread overview]
Message-ID: <20220813234606.7f118c81@windsurf> (raw)
In-Reply-To: <20220813214316.GA2830119@scaer>
Hello,
On Sat, 13 Aug 2022 23:43:16 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > - Adds a new option BR2_BINUTILS_GPROFNG, which allows to
> > enable/disable gprofng in host-binutils
>
> I was wondering if we should not just unconditionally build it. The
> overhead of building host-bison and its dependencies is probably very
> low when compared to the rest of the toolchain, especially with TLPB.
>
> But OK, option it is...
Yes, I agree this question is relevant.
> > diff --git a/package/binutils/binutils.mk b/package/binutils/binutils.mk
> > index a3fece27dc..e4cb19896d 100644
> > --- a/package/binutils/binutils.mk
> > +++ b/package/binutils/binutils.mk
> [--SNIP--]
> > @@ -91,6 +92,13 @@ HOST_BINUTILS_CONF_OPTS = \
> > $(BINUTILS_DISABLE_GDB_CONF_OPTS) \
> > $(BINUTILS_EXTRA_CONFIG_OPTIONS)
> >
> > +ifeq ($(BR2_BINUTILS_GPROFNG),y)
> > +HOST_BINUTILS_DEPENDENCIES += host-bison
> > +HOST_INBUTILS_CONF_OPTS += --enable-gprofng
> > +else
> > +HOST_INBUTILS_CONF_OPTS += --disable-gprofng
>
> $ make check-package
> package/binutils/binutils.mk:97: possible typo: HOST_INBUTILS_CONF_OPTS -> *BINUTILS*
> package/binutils/binutils.mk:99: possible typo: HOST_INBUTILS_CONF_OPTS -> *BINUTILS*
>
> Untested code? ;-)
Meh, weird, I definitely tested it: I got a build failure before, and
not after. Strange. Anyway, thanks for fixing and applying!
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-13 21:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 10:51 [Buildroot] [PATCH] package/binutils: handle gprofng as an optional feature Thomas Petazzoni via buildroot
2022-08-13 21:43 ` Yann E. MORIN
2022-08-13 21:46 ` Thomas Petazzoni via buildroot [this message]
2022-08-14 15:15 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220813234606.7f118c81@windsurf \
--to=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=romain.naour@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.