From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: <stable@vger.kernel.org>, Wei Wang <weiwan@google.com>,
LemmyHuang <hlm3280@163.com>,
Neal Cardwell <ncardwell@google.com>,
"Eric Dumazet" <edumazet@google.com>
Subject: Re: [PATCH stable 5.4] Revert "tcp: change pingpong threshold to 3"
Date: Mon, 15 Aug 2022 18:45:12 -0700 [thread overview]
Message-ID: <20220815184512.515a7fa6@kernel.org> (raw)
In-Reply-To: <20220815205129.6335-1-kuniyu@amazon.com>
On Mon, 15 Aug 2022 20:51:29 +0000 Kuniyuki Iwashima wrote:
> From: Wei Wang <weiwan@google.com>
>
> commit 4d8f24eeedc58d5f87b650ddda73c16e8ba56559 upstream.
>
> This reverts commit 4a41f453bedfd5e9cd040bad509d9da49feb3e2c.
>
> This to-be-reverted commit was meant to apply a stricter rule for the
> stack to enter pingpong mode. However, the condition used to check for
> interactive session "before(tp->lsndtime, icsk->icsk_ack.lrcvtime)" is
> jiffy based and might be too coarse, which delays the stack entering
> pingpong mode.
> We revert this patch so that we no longer use the above condition to
> determine interactive session, and also reduce pingpong threshold to 1.
>
> Fixes: 4a41f453bedf ("tcp: change pingpong threshold to 3")
> Reported-by: LemmyHuang <hlm3280@163.com>
> Suggested-by: Neal Cardwell <ncardwell@google.com>
> Signed-off-by: Wei Wang <weiwan@google.com>
> Acked-by: Neal Cardwell <ncardwell@google.com>
> Reviewed-by: Eric Dumazet <edumazet@google.com>
> Link: https://lore.kernel.org/r/20220721204404.388396-1-weiwan@google.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Should we wait for the resolution in the original thread first?
https://lore.kernel.org/all/ca408271-8730-eb2b-f12e-3f66df2e643a@kernel.org/
next prev parent reply other threads:[~2022-08-16 6:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-30 15:24 FAILED: patch "[PATCH] Revert "tcp: change pingpong threshold to 3"" failed to apply to 5.4-stable tree gregkh
2022-08-15 20:51 ` [PATCH stable 5.4] Revert "tcp: change pingpong threshold to 3" Kuniyuki Iwashima
2022-08-16 1:45 ` Jakub Kicinski [this message]
2022-08-16 5:49 ` Jiri Slaby
2022-08-17 12:04 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2022-08-16 2:36 Iwashima, Kuniyuki
2022-08-16 2:52 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220815184512.515a7fa6@kernel.org \
--to=kuba@kernel.org \
--cc=edumazet@google.com \
--cc=hlm3280@163.com \
--cc=kuniyu@amazon.com \
--cc=ncardwell@google.com \
--cc=stable@vger.kernel.org \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.