All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>,
	stable@vger.kernel.org, Wei Wang <weiwan@google.com>,
	LemmyHuang <hlm3280@163.com>,
	Neal Cardwell <ncardwell@google.com>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH stable 5.4] Revert "tcp: change pingpong threshold to 3"
Date: Wed, 17 Aug 2022 14:04:23 +0200	[thread overview]
Message-ID: <YvzZR4busDunw1Cd@kroah.com> (raw)
In-Reply-To: <47081c01-9e03-8505-6ff9-c6d3def2cc06@kernel.org>

On Tue, Aug 16, 2022 at 07:49:17AM +0200, Jiri Slaby wrote:
> On 15. 08. 22, 22:51, Kuniyuki Iwashima wrote:
> > From: Wei Wang <weiwan@google.com>
> > 
> > commit 4d8f24eeedc58d5f87b650ddda73c16e8ba56559 upstream.
> > 
> > This reverts commit 4a41f453bedfd5e9cd040bad509d9da49feb3e2c.
> > 
> > This to-be-reverted commit was meant to apply a stricter rule for the
> > stack to enter pingpong mode. However, the condition used to check for
> > interactive session "before(tp->lsndtime, icsk->icsk_ack.lrcvtime)" is
> > jiffy based and might be too coarse, which delays the stack entering
> > pingpong mode.
> > We revert this patch so that we no longer use the above condition to
> > determine interactive session, and also reduce pingpong threshold to 1.
> 
> I would wait a bit before backporting this to stable:
> https://lore.kernel.org/all/ca408271-8730-eb2b-f12e-3f66df2e643a@kernel.org/

Looks like all is good, so I'll leave this be for now.

thanks,

greg k-h

  reply	other threads:[~2022-08-17 12:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-30 15:24 FAILED: patch "[PATCH] Revert "tcp: change pingpong threshold to 3"" failed to apply to 5.4-stable tree gregkh
2022-08-15 20:51 ` [PATCH stable 5.4] Revert "tcp: change pingpong threshold to 3" Kuniyuki Iwashima
2022-08-16  1:45   ` Jakub Kicinski
2022-08-16  5:49   ` Jiri Slaby
2022-08-17 12:04     ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-08-16  2:36 Iwashima, Kuniyuki
2022-08-16  2:52 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YvzZR4busDunw1Cd@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=edumazet@google.com \
    --cc=hlm3280@163.com \
    --cc=jirislaby@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@amazon.com \
    --cc=ncardwell@google.com \
    --cc=stable@vger.kernel.org \
    --cc=weiwan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.