All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: netdev@vger.kernel.org, kbuild-all@lists.01.org,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: [mst-vhost:vhost 5/8] drivers/virtio/virtio_vdpa.c:291:61: error: 'sizes' undeclared
Date: Tue, 16 Aug 2022 11:28:29 +0800	[thread overview]
Message-ID: <202208161151.sMYdFPvS-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head:   43ab8a34f3f0c7301813343b9fed2da33c37754a
commit: 71545b3c933acbf165e6596d5cfa4fd15e1ef543 [5/8] virtio: Revert "virtio: find_vqs() add arg sizes"
config: i386-buildonly-randconfig-r004-20220815 (https://download.01.org/0day-ci/archive/20220816/202208161151.sMYdFPvS-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/commit/?id=71545b3c933acbf165e6596d5cfa4fd15e1ef543
        git remote add mst-vhost https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git
        git fetch --no-tags mst-vhost vhost
        git checkout 71545b3c933acbf165e6596d5cfa4fd15e1ef543
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/virtio/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/virtio/virtio_vdpa.c: In function 'virtio_vdpa_find_vqs':
>> drivers/virtio/virtio_vdpa.c:291:61: error: 'sizes' undeclared (first use in this function)
     291 |                                                   names[i], sizes ? sizes[i] : 0,
         |                                                             ^~~~~
   drivers/virtio/virtio_vdpa.c:291:61: note: each undeclared identifier is reported only once for each function it appears in


vim +/sizes +291 drivers/virtio/virtio_vdpa.c

c043b4a8cf3b16 Jason Wang  2020-03-26  270  
3153234097f6a0 Solomon Tan 2022-04-18  271  static int virtio_vdpa_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
c043b4a8cf3b16 Jason Wang  2020-03-26  272  				struct virtqueue *vqs[],
c043b4a8cf3b16 Jason Wang  2020-03-26  273  				vq_callback_t *callbacks[],
c043b4a8cf3b16 Jason Wang  2020-03-26  274  				const char * const names[],
c043b4a8cf3b16 Jason Wang  2020-03-26  275  				const bool *ctx,
c043b4a8cf3b16 Jason Wang  2020-03-26  276  				struct irq_affinity *desc)
c043b4a8cf3b16 Jason Wang  2020-03-26  277  {
c043b4a8cf3b16 Jason Wang  2020-03-26  278  	struct virtio_vdpa_device *vd_dev = to_virtio_vdpa_device(vdev);
c043b4a8cf3b16 Jason Wang  2020-03-26  279  	struct vdpa_device *vdpa = vd_get_vdpa(vdev);
c043b4a8cf3b16 Jason Wang  2020-03-26  280  	const struct vdpa_config_ops *ops = vdpa->config;
c043b4a8cf3b16 Jason Wang  2020-03-26  281  	struct vdpa_callback cb;
c043b4a8cf3b16 Jason Wang  2020-03-26  282  	int i, err, queue_idx = 0;
c043b4a8cf3b16 Jason Wang  2020-03-26  283  
c043b4a8cf3b16 Jason Wang  2020-03-26  284  	for (i = 0; i < nvqs; ++i) {
c043b4a8cf3b16 Jason Wang  2020-03-26  285  		if (!names[i]) {
c043b4a8cf3b16 Jason Wang  2020-03-26  286  			vqs[i] = NULL;
c043b4a8cf3b16 Jason Wang  2020-03-26  287  			continue;
c043b4a8cf3b16 Jason Wang  2020-03-26  288  		}
c043b4a8cf3b16 Jason Wang  2020-03-26  289  
99e8927d8a4da8 Bo Liu      2022-08-10  290  		vqs[i] = virtio_vdpa_setup_vq(vdev, queue_idx++, callbacks[i],
99e8927d8a4da8 Bo Liu      2022-08-10 @291  						  names[i], sizes ? sizes[i] : 0,
99e8927d8a4da8 Bo Liu      2022-08-10  292  						  ctx ? ctx[i] : false);
c043b4a8cf3b16 Jason Wang  2020-03-26  293  		if (IS_ERR(vqs[i])) {
c043b4a8cf3b16 Jason Wang  2020-03-26  294  			err = PTR_ERR(vqs[i]);
c043b4a8cf3b16 Jason Wang  2020-03-26  295  			goto err_setup_vq;
c043b4a8cf3b16 Jason Wang  2020-03-26  296  		}
c043b4a8cf3b16 Jason Wang  2020-03-26  297  	}
c043b4a8cf3b16 Jason Wang  2020-03-26  298  
c043b4a8cf3b16 Jason Wang  2020-03-26  299  	cb.callback = virtio_vdpa_config_cb;
c043b4a8cf3b16 Jason Wang  2020-03-26  300  	cb.private = vd_dev;
c043b4a8cf3b16 Jason Wang  2020-03-26  301  	ops->set_config_cb(vdpa, &cb);
c043b4a8cf3b16 Jason Wang  2020-03-26  302  
c043b4a8cf3b16 Jason Wang  2020-03-26  303  	return 0;
c043b4a8cf3b16 Jason Wang  2020-03-26  304  
c043b4a8cf3b16 Jason Wang  2020-03-26  305  err_setup_vq:
c043b4a8cf3b16 Jason Wang  2020-03-26  306  	virtio_vdpa_del_vqs(vdev);
c043b4a8cf3b16 Jason Wang  2020-03-26  307  	return err;
c043b4a8cf3b16 Jason Wang  2020-03-26  308  }
c043b4a8cf3b16 Jason Wang  2020-03-26  309  

:::::: The code at line 291 was first introduced by commit
:::::: 99e8927d8a4da8eb8a8a5904dc13a3156be8e7c0 virtio_vdpa: support the arg sizes of find_vqs()

:::::: TO: Bo Liu <liubo03@inspur.com>
:::::: CC: Michael S. Tsirkin <mst@redhat.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kbuild-all@lists.01.org, kvm@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: [mst-vhost:vhost 5/8] drivers/virtio/virtio_vdpa.c:291:61: error: 'sizes' undeclared
Date: Tue, 16 Aug 2022 11:28:29 +0800	[thread overview]
Message-ID: <202208161151.sMYdFPvS-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost
head:   43ab8a34f3f0c7301813343b9fed2da33c37754a
commit: 71545b3c933acbf165e6596d5cfa4fd15e1ef543 [5/8] virtio: Revert "virtio: find_vqs() add arg sizes"
config: i386-buildonly-randconfig-r004-20220815 (https://download.01.org/0day-ci/archive/20220816/202208161151.sMYdFPvS-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git/commit/?id=71545b3c933acbf165e6596d5cfa4fd15e1ef543
        git remote add mst-vhost https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git
        git fetch --no-tags mst-vhost vhost
        git checkout 71545b3c933acbf165e6596d5cfa4fd15e1ef543
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/virtio/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/virtio/virtio_vdpa.c: In function 'virtio_vdpa_find_vqs':
>> drivers/virtio/virtio_vdpa.c:291:61: error: 'sizes' undeclared (first use in this function)
     291 |                                                   names[i], sizes ? sizes[i] : 0,
         |                                                             ^~~~~
   drivers/virtio/virtio_vdpa.c:291:61: note: each undeclared identifier is reported only once for each function it appears in


vim +/sizes +291 drivers/virtio/virtio_vdpa.c

c043b4a8cf3b16 Jason Wang  2020-03-26  270  
3153234097f6a0 Solomon Tan 2022-04-18  271  static int virtio_vdpa_find_vqs(struct virtio_device *vdev, unsigned int nvqs,
c043b4a8cf3b16 Jason Wang  2020-03-26  272  				struct virtqueue *vqs[],
c043b4a8cf3b16 Jason Wang  2020-03-26  273  				vq_callback_t *callbacks[],
c043b4a8cf3b16 Jason Wang  2020-03-26  274  				const char * const names[],
c043b4a8cf3b16 Jason Wang  2020-03-26  275  				const bool *ctx,
c043b4a8cf3b16 Jason Wang  2020-03-26  276  				struct irq_affinity *desc)
c043b4a8cf3b16 Jason Wang  2020-03-26  277  {
c043b4a8cf3b16 Jason Wang  2020-03-26  278  	struct virtio_vdpa_device *vd_dev = to_virtio_vdpa_device(vdev);
c043b4a8cf3b16 Jason Wang  2020-03-26  279  	struct vdpa_device *vdpa = vd_get_vdpa(vdev);
c043b4a8cf3b16 Jason Wang  2020-03-26  280  	const struct vdpa_config_ops *ops = vdpa->config;
c043b4a8cf3b16 Jason Wang  2020-03-26  281  	struct vdpa_callback cb;
c043b4a8cf3b16 Jason Wang  2020-03-26  282  	int i, err, queue_idx = 0;
c043b4a8cf3b16 Jason Wang  2020-03-26  283  
c043b4a8cf3b16 Jason Wang  2020-03-26  284  	for (i = 0; i < nvqs; ++i) {
c043b4a8cf3b16 Jason Wang  2020-03-26  285  		if (!names[i]) {
c043b4a8cf3b16 Jason Wang  2020-03-26  286  			vqs[i] = NULL;
c043b4a8cf3b16 Jason Wang  2020-03-26  287  			continue;
c043b4a8cf3b16 Jason Wang  2020-03-26  288  		}
c043b4a8cf3b16 Jason Wang  2020-03-26  289  
99e8927d8a4da8 Bo Liu      2022-08-10  290  		vqs[i] = virtio_vdpa_setup_vq(vdev, queue_idx++, callbacks[i],
99e8927d8a4da8 Bo Liu      2022-08-10 @291  						  names[i], sizes ? sizes[i] : 0,
99e8927d8a4da8 Bo Liu      2022-08-10  292  						  ctx ? ctx[i] : false);
c043b4a8cf3b16 Jason Wang  2020-03-26  293  		if (IS_ERR(vqs[i])) {
c043b4a8cf3b16 Jason Wang  2020-03-26  294  			err = PTR_ERR(vqs[i]);
c043b4a8cf3b16 Jason Wang  2020-03-26  295  			goto err_setup_vq;
c043b4a8cf3b16 Jason Wang  2020-03-26  296  		}
c043b4a8cf3b16 Jason Wang  2020-03-26  297  	}
c043b4a8cf3b16 Jason Wang  2020-03-26  298  
c043b4a8cf3b16 Jason Wang  2020-03-26  299  	cb.callback = virtio_vdpa_config_cb;
c043b4a8cf3b16 Jason Wang  2020-03-26  300  	cb.private = vd_dev;
c043b4a8cf3b16 Jason Wang  2020-03-26  301  	ops->set_config_cb(vdpa, &cb);
c043b4a8cf3b16 Jason Wang  2020-03-26  302  
c043b4a8cf3b16 Jason Wang  2020-03-26  303  	return 0;
c043b4a8cf3b16 Jason Wang  2020-03-26  304  
c043b4a8cf3b16 Jason Wang  2020-03-26  305  err_setup_vq:
c043b4a8cf3b16 Jason Wang  2020-03-26  306  	virtio_vdpa_del_vqs(vdev);
c043b4a8cf3b16 Jason Wang  2020-03-26  307  	return err;
c043b4a8cf3b16 Jason Wang  2020-03-26  308  }
c043b4a8cf3b16 Jason Wang  2020-03-26  309  

:::::: The code at line 291 was first introduced by commit
:::::: 99e8927d8a4da8eb8a8a5904dc13a3156be8e7c0 virtio_vdpa: support the arg sizes of find_vqs()

:::::: TO: Bo Liu <liubo03@inspur.com>
:::::: CC: Michael S. Tsirkin <mst@redhat.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

             reply	other threads:[~2022-08-16  3:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16  3:28 kernel test robot [this message]
2022-08-16  3:28 ` [mst-vhost:vhost 5/8] drivers/virtio/virtio_vdpa.c:291:61: error: 'sizes' undeclared kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202208161151.sMYdFPvS-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.