Re: [Buildroot] [PATCH v1 1/1] package/pkg-meson.mk: handle possibly non existing compilers

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: buildroot@busybox.net,
	"Guillaume W. Bres" <guillaume.bressaix@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH v1 1/1] package/pkg-meson.mk: handle possibly non existing compilers
Date: Tue, 16 Aug 2022 23:10:21 +0200	[thread overview]
Message-ID: <20220816211021.GQ2854108@scaer> (raw)
In-Reply-To: <5bf3b48f-bfae-444c-3c2e-73235a0d523c@mind.be>

Guillaume, Arnout, All,

On 2022-08-16 22:54 +0200, Arnout Vandecappelle spake thusly:
> On 16/08/2022 12:37, Guillaume W. Bres wrote:
> >To avoid populating the cross-file with non existing compilers,
> >we tie them to /bin/false

Guillaume, you should probably have copied in the commit log, the
explanations I provided where I reported the suggestion from the
meson guys.

> >Signed-off-by: Guillaume W. Bres <guillaume.bressaix@gmail.com>
> >---
> >  package/pkg-meson.mk | 18 ++++++++++++++++--
> >  1 file changed, 16 insertions(+), 2 deletions(-)
> >
> >diff --git a/package/pkg-meson.mk b/package/pkg-meson.mk
> >index 0632ab21cf..d675f7f733 100644
> >--- a/package/pkg-meson.mk
> >+++ b/package/pkg-meson.mk
> >@@ -68,15 +68,29 @@ else
[--SNIP--]
>  Perhaps we should do this in package/Makefile.in instead? I.e. define
> TARGET_CXX itself as false.
>  This does have rather heavy implications, but I *think* it should be
> fine... And anyway, the autobuilders will tell us :-)

Please, no. This goes contrary to what I explained in the other thread.

Disabling or forcing detection of a tool should be part of the
infrastructure. meson has its way (do not set it, or poison it with
/bin/false as suggested by them). auotools has its own way (set it to
no). cmake has probably a way of its own...

And even if they eventually come to be all use /binfalse except
autotools,  would still prefer that, because it semantically belong to
that buildsystem infra.

Regards,
Yann E. MORIN.

>  Regards,
>  Arnout
> 
> >+
> >  # Generates sed patterns for patching the cross-compilation.conf template,
> >  # since Flags might contain commas the arguments are passed indirectly by
> >  # variable name (stripped to deal with whitespaces).
> >  # Arguments are variable containing cflags, cxxflags, ldflags, fcflags
> >  define PKG_MESON_CROSSCONFIG_SED
> >          -e "s%@TARGET_CC@%$(TARGET_CC)%g" \
> >-        -e "s%@TARGET_CXX@%$(TARGET_CXX)%g" \
> >+        -e "s%@TARGET_CXX@%$(PKG_MESON_TARGET_CXX)%g" \
> >          -e "s%@TARGET_AR@%$(TARGET_AR)%g" \
> >-        -e "s%@TARGET_FC@%$(TARGET_FC)%g" \
> >+        -e "s%@TARGET_FC@%$(PKG_MESON_TARGET_FC)%g" \
> >          -e "s%@TARGET_STRIP@%$(TARGET_STRIP)%g" \
> >          -e "s%@TARGET_ARCH@%$(PKG_MESON_TARGET_CPU_FAMILY)%g" \
> >          -e "s%@TARGET_CPU@%$(GCC_TARGET_CPU)%g" \
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot