From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: buildroot@busybox.net,
"Guillaume W. Bres" <guillaume.bressaix@gmail.com>,
Yann Morin <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [PATCH v1 1/1] package/pkg-meson.mk: handle possibly non existing compilers
Date: Tue, 16 Aug 2022 23:24:05 +0200 [thread overview]
Message-ID: <20220816232405.0ca636d9@windsurf> (raw)
In-Reply-To: <5bf3b48f-bfae-444c-3c2e-73235a0d523c@mind.be>
On Tue, 16 Aug 2022 22:54:04 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:
> > +# To avoid populating the cross-file with non existing compilers,
> > +# we tie them to /bin/false
> > +ifeq ($(BR2_INSTALL_LIBSTDCPP),y)
> > +PKG_MESON_TARGET_CXX = $(TARGET_CXX)
> > +else
> > +PKG_MESON_TARGET_CXX = /bin/false
> > +endif
> > +
> > +ifeq ($(BR2_TOOLCHAIN_HAS_FORTRAN),y)
> > +PKG_MESON_TARGET_FC = $(TARGET_FC)
> > +else
> > +PKG_MESON_TARGET_FC = /bin/false
> > +endif
>
> Perhaps we should do this in package/Makefile.in instead? I.e. define
> TARGET_CXX itself as false.
>
> This does have rather heavy implications, but I *think* it should be fine...
> And anyway, the autobuilders will tell us :-)
See the discussion on the RFC of this patch, where I proposed exactly
this, and Yann gave a recollection of historical details that showed
that no, it's not a good idea to do it in package/Makefile.in,
unfortunately.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-08-16 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 10:37 [Buildroot] [PATCH v1 1/1] package/pkg-meson.mk: handle possibly non existing compilers Guillaume W. Bres
2022-08-16 20:54 ` Arnout Vandecappelle
2022-08-16 21:10 ` Yann E. MORIN
2022-08-16 21:24 ` Thomas Petazzoni via buildroot [this message]
2022-08-20 21:01 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220816232405.0ca636d9@windsurf \
--to=buildroot@buildroot.org \
--cc=arnout@mind.be \
--cc=buildroot@busybox.net \
--cc=guillaume.bressaix@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.