From: "Marek Behún" <kabel@kernel.org>
To: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Linux Phy <linux-phy@lists.infradead.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Kees Cook <keescook@chromium.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-kernel@vger.kernel.org, pali@kernel.org,
josef.schlehofer@nic.cz
Subject: Re: [PATCH linux-phy 3/4] phy: marvell: phy-mvebu-a3700-comphy: Support changing tx amplitude for ethernet
Date: Wed, 17 Aug 2022 21:47:22 +0200 [thread overview]
Message-ID: <20220817214722.461b18c1@thinkpad> (raw)
In-Reply-To: <20220817193119.4463-4-kabel@kernel.org>
On Wed, 17 Aug 2022 21:31:18 +0200
Marek Behún <kabel@kernel.org> wrote:
> +static u8 comphy_find_best_tx_amp(bool full_swing, u32 amp, u32 *true_amp)
...
> + tx_amp = comphy_find_best_tx_amp(tx_amp_mv, full_swing,
> + &true_tx_amp_mv);
OMG, I changed the full_swing parameter to be the first one at the
last minute and forgot to also do it in the function call.
Will send v2.
Sorry.
Marek
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: "Marek Behún" <kabel@kernel.org>
To: Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Linux Phy <linux-phy@lists.infradead.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Daniel Scally <djrscally@gmail.com>,
Gregory Clement <gregory.clement@bootlin.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Kees Cook <keescook@chromium.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-kernel@vger.kernel.org, pali@kernel.org,
josef.schlehofer@nic.cz
Subject: Re: [PATCH linux-phy 3/4] phy: marvell: phy-mvebu-a3700-comphy: Support changing tx amplitude for ethernet
Date: Wed, 17 Aug 2022 21:47:22 +0200 [thread overview]
Message-ID: <20220817214722.461b18c1@thinkpad> (raw)
In-Reply-To: <20220817193119.4463-4-kabel@kernel.org>
On Wed, 17 Aug 2022 21:31:18 +0200
Marek Behún <kabel@kernel.org> wrote:
> +static u8 comphy_find_best_tx_amp(bool full_swing, u32 amp, u32 *true_amp)
...
> + tx_amp = comphy_find_best_tx_amp(tx_amp_mv, full_swing,
> + &true_tx_amp_mv);
OMG, I changed the full_swing parameter to be the first one at the
last minute and forgot to also do it in the function call.
Will send v2.
Sorry.
Marek
next prev parent reply other threads:[~2022-08-17 19:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 19:31 [PATCH linux-phy 0/4] mvebu a3720 comphy: Fix serdes transmit amplitude Marek Behún
2022-08-17 19:31 ` Marek Behún
2022-08-17 19:31 ` [PATCH linux-phy 1/4] string.h: Add str_has_proper_prefix() Marek Behún
2022-08-17 19:31 ` Marek Behún
2022-08-17 19:31 ` [PATCH linux-phy 2/4] device property: Add {fwnode/device}_get_tx_p2p_amplitude() Marek Behún
2022-08-17 19:31 ` Marek Behún
2022-08-17 19:31 ` [PATCH linux-phy 3/4] phy: marvell: phy-mvebu-a3700-comphy: Support changing tx amplitude for ethernet Marek Behún
2022-08-17 19:31 ` Marek Behún
2022-08-17 19:47 ` Marek Behún [this message]
2022-08-17 19:47 ` Marek Behún
2022-08-17 19:31 ` [PATCH linux-phy 4/4] arm64: dts: armada-3720-turris-mox: Change comphy tx amplitude for 2500base-x mode Marek Behún
2022-08-17 19:31 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220817214722.461b18c1@thinkpad \
--to=kabel@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=djrscally@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=josef.schlehofer@nic.cz \
--cc=keescook@chromium.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=pali@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.