From: Rob Herring <robh@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-msm@vger.kernel.org,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
broonie@kernel.org, krzysztof.kozlowski+dt@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] ASoC: codecs: wsa-macro: add support for sm8450 and sc8280xp
Date: Thu, 18 Aug 2022 11:12:22 -0600 [thread overview]
Message-ID: <20220818171222.GG1978870-robh@kernel.org> (raw)
In-Reply-To: <20220818134619.3432-3-srinivas.kandagatla@linaro.org>
On Thu, Aug 18, 2022 at 02:46:15PM +0100, Srinivas Kandagatla wrote:
> Add compatible for sm8450 and sc8280xp.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> sound/soc/codecs/lpass-wsa-macro.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c
> index 27da6c6c3c5a..f82c297ea3ab 100644
> --- a/sound/soc/codecs/lpass-wsa-macro.c
> +++ b/sound/soc/codecs/lpass-wsa-macro.c
> @@ -2561,6 +2561,8 @@ static const struct dev_pm_ops wsa_macro_pm_ops = {
> static const struct of_device_id wsa_macro_dt_match[] = {
> {.compatible = "qcom,sc7280-lpass-wsa-macro"},
> {.compatible = "qcom,sm8250-lpass-wsa-macro"},
> + {.compatible = "qcom,sm8450-lpass-wsa-macro"},
> + {.compatible = "qcom,sc8280xp-lpass-wsa-macro" },
Looks like these are backwards compatible with the existing versions,
why not reflect that in the binding?
Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: broonie@kernel.org, krzysztof.kozlowski+dt@linaro.org,
perex@perex.cz, tiwai@suse.com,
pierre-louis.bossart@linux.intel.com,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] ASoC: codecs: wsa-macro: add support for sm8450 and sc8280xp
Date: Thu, 18 Aug 2022 11:12:22 -0600 [thread overview]
Message-ID: <20220818171222.GG1978870-robh@kernel.org> (raw)
In-Reply-To: <20220818134619.3432-3-srinivas.kandagatla@linaro.org>
On Thu, Aug 18, 2022 at 02:46:15PM +0100, Srinivas Kandagatla wrote:
> Add compatible for sm8450 and sc8280xp.
>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> sound/soc/codecs/lpass-wsa-macro.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/codecs/lpass-wsa-macro.c b/sound/soc/codecs/lpass-wsa-macro.c
> index 27da6c6c3c5a..f82c297ea3ab 100644
> --- a/sound/soc/codecs/lpass-wsa-macro.c
> +++ b/sound/soc/codecs/lpass-wsa-macro.c
> @@ -2561,6 +2561,8 @@ static const struct dev_pm_ops wsa_macro_pm_ops = {
> static const struct of_device_id wsa_macro_dt_match[] = {
> {.compatible = "qcom,sc7280-lpass-wsa-macro"},
> {.compatible = "qcom,sm8250-lpass-wsa-macro"},
> + {.compatible = "qcom,sm8450-lpass-wsa-macro"},
> + {.compatible = "qcom,sc8280xp-lpass-wsa-macro" },
Looks like these are backwards compatible with the existing versions,
why not reflect that in the binding?
Rob
next prev parent reply other threads:[~2022-08-18 17:13 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 13:46 [PATCH 0/6] ASoC: codecs: lpass: add support fro sm8450 and sc8280xp Srinivas Kandagatla
2022-08-18 13:46 ` Srinivas Kandagatla
2022-08-18 13:46 ` [PATCH 1/6] ASoC: qcom: dt-bindings: add sm8450 and sc8280xp compatibles Srinivas Kandagatla
2022-08-18 13:46 ` Srinivas Kandagatla
2022-08-18 17:11 ` Rob Herring
2022-08-18 17:11 ` Rob Herring
2022-08-18 13:46 ` [PATCH 2/6] ASoC: codecs: wsa-macro: add support for sm8450 and sc8280xp Srinivas Kandagatla
2022-08-18 13:46 ` Srinivas Kandagatla
2022-08-18 17:12 ` Rob Herring [this message]
2022-08-18 17:12 ` Rob Herring
2022-08-31 9:17 ` Srinivas Kandagatla
2022-08-31 9:17 ` Srinivas Kandagatla
2022-08-31 9:19 ` Krzysztof Kozlowski
2022-08-31 9:19 ` Krzysztof Kozlowski
2022-08-31 9:20 ` Krzysztof Kozlowski
2022-08-31 9:20 ` Krzysztof Kozlowski
2022-08-31 10:37 ` Srinivas Kandagatla
2022-08-31 10:37 ` Srinivas Kandagatla
2022-09-01 7:28 ` Krzysztof Kozlowski
2022-09-01 7:28 ` Krzysztof Kozlowski
2022-08-18 13:46 ` [PATCH 3/6] ASoC: codecs: tx-macro: " Srinivas Kandagatla
2022-08-18 13:46 ` Srinivas Kandagatla
2022-08-18 13:46 ` [PATCH 4/6] ASoC: codecs: rx-macro: " Srinivas Kandagatla
2022-08-18 13:46 ` Srinivas Kandagatla
2022-08-18 13:46 ` [PATCH 5/6] ASoC: codecs: va-macro: clear the frame sync counter before enabling Srinivas Kandagatla
2022-08-18 13:46 ` Srinivas Kandagatla
2022-08-18 13:46 ` [PATCH 6/6] ASoC: codecs: tx-macro: add support for sm8450 and sc8280xp Srinivas Kandagatla
2022-08-18 13:46 ` Srinivas Kandagatla
2022-09-01 7:30 ` Krzysztof Kozlowski
2022-09-01 7:30 ` Krzysztof Kozlowski
2022-09-01 8:50 ` Srinivas Kandagatla
2022-09-01 8:50 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220818171222.GG1978870-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.