From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@fb.com>
Cc: linux-nvme@lists.infradead.org, hch@lst.de,
Keith Busch <kbusch@kernel.org>,
Jonathan Derrick <Jonathan.Derrick@solidigm.com>
Subject: Re: [PATCH] nvme: don't flush scan work with non-idle request
Date: Sun, 21 Aug 2022 16:40:39 +0200 [thread overview]
Message-ID: <20220821144039.GA3384@lst.de> (raw)
In-Reply-To: <20220812182147.1564958-1-kbusch@fb.com>
With this the flush_work is lost for the target passthrough case.
I also don't really like the double call to nvme_command_effects().
What about just removing nvme_execute_passthru_rq() and open coding
it in the two calles, with the nvme_passthru_end call moved until
after freeing the request?
next prev parent reply other threads:[~2022-08-21 14:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 18:21 [PATCH] nvme: don't flush scan work with non-idle request Keith Busch
2022-08-12 19:12 ` Jonathan Derrick
2022-08-16 8:53 ` Chao Leng
2022-08-17 10:29 ` Sagi Grimberg
2022-08-17 15:07 ` Keith Busch
2022-08-17 15:39 ` Sagi Grimberg
2022-08-21 14:40 ` Christoph Hellwig [this message]
2022-08-22 15:09 ` Keith Busch
2022-08-23 16:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220821144039.GA3384@lst.de \
--to=hch@lst.de \
--cc=Jonathan.Derrick@solidigm.com \
--cc=kbusch@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.