From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@fb.com>,
linux-nvme@lists.infradead.org,
Jonathan Derrick <Jonathan.Derrick@solidigm.com>
Subject: Re: [PATCH] nvme: don't flush scan work with non-idle request
Date: Mon, 22 Aug 2022 09:09:10 -0600 [thread overview]
Message-ID: <YwOcFmTPQeDAl0Og@kbusch-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20220821144039.GA3384@lst.de>
On Sun, Aug 21, 2022 at 04:40:39PM +0200, Christoph Hellwig wrote:
> With this the flush_work is lost for the target passthrough case.
>
> I also don't really like the double call to nvme_command_effects().
>
> What about just removing nvme_execute_passthru_rq() and open coding
> it in the two calles, with the nvme_passthru_end call moved until
> after freeing the request?
I didn't think it mattered for passthrough because the host needs to flush the
scan work on its side before safely using the changed namespace. It doesn't
matter if the target side has flushed out the new namespace format because it's
not the one creating LBA command parameters.
Never-the-less, if you do prefer to have each caller open code the sequence, I
have that patch ready to send.
next prev parent reply other threads:[~2022-08-22 15:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 18:21 [PATCH] nvme: don't flush scan work with non-idle request Keith Busch
2022-08-12 19:12 ` Jonathan Derrick
2022-08-16 8:53 ` Chao Leng
2022-08-17 10:29 ` Sagi Grimberg
2022-08-17 15:07 ` Keith Busch
2022-08-17 15:39 ` Sagi Grimberg
2022-08-21 14:40 ` Christoph Hellwig
2022-08-22 15:09 ` Keith Busch [this message]
2022-08-23 16:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YwOcFmTPQeDAl0Og@kbusch-mbp.dhcp.thefacebook.com \
--to=kbusch@kernel.org \
--cc=Jonathan.Derrick@solidigm.com \
--cc=hch@lst.de \
--cc=kbusch@fb.com \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.