From: Dan Carpenter <dan.carpenter@oracle.com>
To: Nam Cao <namcaov@gmail.com>
Cc: lkp@intel.com, Larry.Finger@lwfinger.net,
gregkh@linuxfoundation.org, hdegoede@redhat.com,
kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH v2 1/8] staging: rtl8723bs: remove function rtw_odm_dbg_comp_msg
Date: Mon, 22 Aug 2022 10:33:52 +0300 [thread overview]
Message-ID: <20220822073352.GA2695@kadam> (raw)
In-Reply-To: <7ff2d658863db4fd5eecc1a53f682510c2765c3f.1660916523.git.namcaov@gmail.com>
On Fri, Aug 19, 2022 at 03:49:35PM +0200, Nam Cao wrote:
> because this function is not used.
>
> Signed-off-by: Nam Cao <namcaov@gmail.com>
This patch is fine, but in the future can you please treat the subject
as separate from the commit message. "because it is not used" is a
sucky commit message. What is not used? What are you doing to it? It
doesn't start with a capital letter.
Here is how your email looks like on lore.
https://lore.kernel.org/all/7ff2d658863db4fd5eecc1a53f682510c2765c3f.1660916523.git.namcaov@gmail.com/
Try to find the subject in the middle of the block of text. People are
often only going to read the body of the email.
[PATCH v2 1/8] staging: rtl8723bs: remove rtw_odm_dbg_comp_msg()
The rtw_odm_dbg_comp_msg() function is not used. Delete it.
Signed-off-by:
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v2 1/8] staging: rtl8723bs: remove function rtw_odm_dbg_comp_msg
Date: Mon, 22 Aug 2022 10:33:52 +0300 [thread overview]
Message-ID: <20220822073352.GA2695@kadam> (raw)
In-Reply-To: <7ff2d658863db4fd5eecc1a53f682510c2765c3f.1660916523.git.namcaov@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
On Fri, Aug 19, 2022 at 03:49:35PM +0200, Nam Cao wrote:
> because this function is not used.
>
> Signed-off-by: Nam Cao <namcaov@gmail.com>
This patch is fine, but in the future can you please treat the subject
as separate from the commit message. "because it is not used" is a
sucky commit message. What is not used? What are you doing to it? It
doesn't start with a capital letter.
Here is how your email looks like on lore.
https://lore.kernel.org/all/7ff2d658863db4fd5eecc1a53f682510c2765c3f.1660916523.git.namcaov(a)gmail.com/
Try to find the subject in the middle of the block of text. People are
often only going to read the body of the email.
[PATCH v2 1/8] staging: rtl8723bs: remove rtw_odm_dbg_comp_msg()
The rtw_odm_dbg_comp_msg() function is not used. Delete it.
Signed-off-by:
regards,
dan carpenter
next prev parent reply other threads:[~2022-08-22 7:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-19 8:52 [PATCH 0/7] staging: rtl8723bs: remove dead functions Nam Cao
2022-08-19 8:52 ` [PATCH 1/7] staging: rtl8723bs: remove function rtw_odm_dbg_comp_msg Nam Cao
2022-08-19 13:07 ` kernel test robot
2022-08-19 13:49 ` [PATCH v2 0/8] remove some dead code Nam Cao
2022-08-19 13:49 ` Nam Cao
2022-08-19 13:49 ` [PATCH v2 1/8] staging: rtl8723bs: remove function rtw_odm_dbg_comp_msg Nam Cao
2022-08-19 13:49 ` Nam Cao
2022-08-22 7:33 ` Dan Carpenter [this message]
2022-08-22 7:33 ` Dan Carpenter
2022-08-22 7:47 ` Nam Cao
2022-08-22 7:47 ` Nam Cao
2022-08-19 13:49 ` [PATCH v2 2/8] staging: rtl8723bs: remove function rtw_get_ch_setting_union Nam Cao
2022-08-19 13:49 ` Nam Cao
2022-08-19 13:49 ` [PATCH v2 3/8] staging: rtl8723bs: remove function rtw_odm_ability_set Nam Cao
2022-08-19 13:49 ` Nam Cao
2022-08-19 13:49 ` [PATCH v2 4/8] staging: rtl8723bs: remove function GetFractionValueFromString Nam Cao
2022-08-19 13:49 ` Nam Cao
2022-08-19 13:49 ` [PATCH v2 5/8] staging: rtl8723bs: remove function IsCommentString Nam Cao
2022-08-19 13:49 ` Nam Cao
2022-08-19 13:49 ` [PATCH v2 6/8] staging: rtl8723bs: remove function rtw_odm_adaptivity_parm_msg Nam Cao
2022-08-19 13:49 ` Nam Cao
2022-08-19 13:49 ` [PATCH v2 7/8] staging: rtl8723bs: remove function rtw_odm_dbg_comp_set Nam Cao
2022-08-19 13:49 ` Nam Cao
2022-08-19 13:49 ` [PATCH v2 8/8] staging: rtl8723bs: remove static const variable odm_comp_str Nam Cao
2022-08-19 13:49 ` Nam Cao
2022-08-19 14:25 ` [PATCH v2 0/8] remove some dead code Hans de Goede
2022-08-19 14:25 ` Hans de Goede
2022-08-19 8:52 ` [PATCH 2/7] staging: rtl8723bs: remove function rtw_get_ch_setting_union Nam Cao
2022-08-19 8:52 ` [PATCH 3/7] staging: rtl8723bs: remove function rtw_odm_ability_set Nam Cao
2022-08-19 8:52 ` [PATCH 4/7] staging: rtl8723bs: remove function GetFractionValueFromString Nam Cao
2022-08-19 8:52 ` [PATCH 5/7] staging: rtl8723bs: remove function IsCommentString Nam Cao
2022-08-19 8:52 ` [PATCH 6/7] staging: rtl8723bs: remove function rtw_odm_adaptivity_parm_msg Nam Cao
2022-08-19 8:52 ` [PATCH 7/7] staging: rtl8723bs: remove function rtw_odm_dbg_comp_set Nam Cao
2022-08-19 9:06 ` [PATCH 0/7] staging: rtl8723bs: remove dead functions Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822073352.GA2695@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lkp@intel.com \
--cc=namcaov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.