From: Stephen Boyd <sboyd@kernel.org>
To: Chen-Yu Tsai <wenst@chromium.org>,
Michael Turquette <mturquette@baylibre.com>
Cc: "Chen-Yu Tsai" <wenst@chromium.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2 1/2] clk: core: Honor CLK_OPS_PARENT_ENABLE for clk gate ops
Date: Mon, 22 Aug 2022 16:18:07 -0700 [thread overview]
Message-ID: <20220822231808.CFCD1C433C1@smtp.kernel.org> (raw)
In-Reply-To: <20220822081424.1310926-2-wenst@chromium.org>
Quoting Chen-Yu Tsai (2022-08-22 01:14:23)
> In the previous commits that added CLK_OPS_PARENT_ENABLE, support for
> this flag was only added to rate change operations (rate setting and
> reparent) and disabling unused subtree. It was not added to the
> clock gate related operations. Any hardware driver that needs it for
> these operations will either see bogus results, or worse, hang.
>
> This has been seen on MT8192 and MT8195, where the imp_ii2_* clk
> drivers set this, but dumping debugfs clk_summary would cause it
> to hang.
>
> Fixes: fc8726a2c021 ("clk: core: support clocks which requires parents enable (part 2)")
> Fixes: a4b3518d146f ("clk: core: support clocks which requires parents enable (part 1)")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> ---
Applied to clk-fixes
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-22 23:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 8:14 [PATCH RESEND v2 0/2] clk: Fix CLK_OPS_PARENT_ENABLE and runtime PM Chen-Yu Tsai
2022-08-22 8:14 ` Chen-Yu Tsai
2022-08-22 8:14 ` [PATCH RESEND v2 1/2] clk: core: Honor CLK_OPS_PARENT_ENABLE for clk gate ops Chen-Yu Tsai
2022-08-22 8:14 ` Chen-Yu Tsai
2022-08-22 23:18 ` Stephen Boyd [this message]
2022-08-26 12:28 ` Alexander Stein
2022-08-26 12:28 ` Alexander Stein
2022-08-29 9:22 ` Chen-Yu Tsai
2022-08-29 9:22 ` Chen-Yu Tsai
2022-08-29 21:03 ` Stephen Boyd
2022-08-30 12:37 ` Alexander Stein
2022-08-30 12:37 ` Alexander Stein
2022-08-30 13:40 ` Chen-Yu Tsai
2022-08-30 13:40 ` Chen-Yu Tsai
2022-08-31 7:40 ` Alexander Stein
2022-08-31 7:40 ` Alexander Stein
2022-08-31 13:51 ` Marcel Ziswiler
2022-08-31 13:51 ` Marcel Ziswiler
2022-08-22 8:14 ` [PATCH RESEND v2 2/2] clk: core: Fix runtime PM sequence in clk_core_unprepare() Chen-Yu Tsai
2022-08-22 8:14 ` Chen-Yu Tsai
2022-08-22 23:18 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220822231808.CFCD1C433C1@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.