From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: "Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2 1/2] clk: core: Honor CLK_OPS_PARENT_ENABLE for clk gate ops
Date: Tue, 30 Aug 2022 14:37:55 +0200 [thread overview]
Message-ID: <2254919.ElGaqSPkdT@steina-w> (raw)
In-Reply-To: <CAGXv+5E788T01XJF-dYRW6ZB5-TTU_L5=0hT3AQ0g+zA=LzG2w@mail.gmail.com>
Hi,
Am Montag, 29. August 2022, 11:22:16 CEST schrieb Chen-Yu Tsai:
> Hi,
>
> On Fri, Aug 26, 2022 at 8:28 PM Alexander Stein
>
> <alexander.stein@ew.tq-group.com> wrote:
> > Hi everybody,
> >
> > Am Montag, 22. August 2022, 10:14:23 CEST schrieb Chen-Yu Tsai:
> > > In the previous commits that added CLK_OPS_PARENT_ENABLE, support for
> > > this flag was only added to rate change operations (rate setting and
> > > reparent) and disabling unused subtree. It was not added to the
> > > clock gate related operations. Any hardware driver that needs it for
> > > these operations will either see bogus results, or worse, hang.
> > >
> > > This has been seen on MT8192 and MT8195, where the imp_ii2_* clk
> > > drivers set this, but dumping debugfs clk_summary would cause it
> > > to hang.
> > >
> > > Fixes: fc8726a2c021 ("clk: core: support clocks which requires parents
> > > enable (part 2)") Fixes: a4b3518d146f ("clk: core: support clocks which
> > > requires parents enable (part 1)") Signed-off-by: Chen-Yu Tsai
> > > <wenst@chromium.org>
> > > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > > Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > > ---
> > >
> > > drivers/clk/clk.c | 28 ++++++++++++++++++++++++++++
> > > 1 file changed, 28 insertions(+)
> > >
> > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > > index 7fc191c15507..9b365cd6d14b 100644
> > > --- a/drivers/clk/clk.c
> > > +++ b/drivers/clk/clk.c
> > > @@ -196,6 +196,9 @@ static bool clk_core_rate_is_protected(struct
> > > clk_core
> > > *core) return core->protect_count;
> > >
> > > }
> > >
> > > +static int clk_core_prepare_enable(struct clk_core *core);
> > > +static void clk_core_disable_unprepare(struct clk_core *core);
> > > +
> > >
> > > static bool clk_core_is_prepared(struct clk_core *core)
> > > {
> > >
> > > bool ret = false;
> > >
> > > @@ -208,7 +211,11 @@ static bool clk_core_is_prepared(struct clk_core
> > > *core) return core->prepare_count;
> > >
> > > if (!clk_pm_runtime_get(core)) {
> > >
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_prepare_enable(core->parent);
> > >
> > > ret = core->ops->is_prepared(core->hw);
> > >
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_disable_unprepare(core->parent);
> > >
> > > clk_pm_runtime_put(core);
> > >
> > > }
> > >
> > > @@ -244,7 +251,13 @@ static bool clk_core_is_enabled(struct clk_core
> > > *core)
> > >
> > > }
> > >
> > > }
> > >
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_prepare_enable(core->parent);
> > > +
> > >
> > > ret = core->ops->is_enabled(core->hw);
> > >
> > > +
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_disable_unprepare(core->parent);
> > >
> > > done:
> > > if (core->rpm_enabled)
> > >
> > > pm_runtime_put(core->dev);
> > >
> > > @@ -812,6 +825,9 @@ int clk_rate_exclusive_get(struct clk *clk)
> > >
> > > }
> > > EXPORT_SYMBOL_GPL(clk_rate_exclusive_get);
> > >
> > > +static int clk_core_enable_lock(struct clk_core *core);
> > > +static void clk_core_disable_lock(struct clk_core *core);
> > > +
> > >
> > > static void clk_core_unprepare(struct clk_core *core)
> > > {
> > >
> > > lockdep_assert_held(&prepare_lock);
> > >
> > > @@ -835,6 +851,9 @@ static void clk_core_unprepare(struct clk_core
> > > *core)
> > >
> > > WARN(core->enable_count > 0, "Unpreparing enabled %s\n", core-
> > >
> > >name);
> > >
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_enable_lock(core->parent);
> > > +
> > >
> > > trace_clk_unprepare(core);
> > >
> > > if (core->ops->unprepare)
> > >
> > > @@ -843,6 +862,9 @@ static void clk_core_unprepare(struct clk_core
> > > *core)
> > >
> > > clk_pm_runtime_put(core);
> > >
> > > trace_clk_unprepare_complete(core);
> > >
> > > +
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_disable_lock(core->parent);
> > >
> > > clk_core_unprepare(core->parent);
> > >
> > > }
> > >
> > > @@ -891,6 +913,9 @@ static int clk_core_prepare(struct clk_core *core)
> > >
> > > if (ret)
> > >
> > > goto runtime_put;
> > >
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_enable_lock(core->parent);
> > > +
> > >
> > > trace_clk_prepare(core);
> > >
> > > if (core->ops->prepare)
> > >
> > > @@ -898,6 +923,9 @@ static int clk_core_prepare(struct clk_core *core)
> > >
> > > trace_clk_prepare_complete(core);
> > >
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_disable_lock(core->parent);
> > > +
> > >
> > > if (ret)
> > >
> > > goto unprepare;
> > >
> > > }
> >
> > Unfortunately this completely locks up my i.MX8M Plus based board during
> > early boot.
> > I'm currently running on next-20220826 using
> > arch/arm64/boot/dts/freescale/
> > imx8mp-tqma8mpql-mba8mpxl.dts
> > Reverting this patch gets my board booting again. dmesg until hard lockup
> > below.
>
> The standard logs don't have anything to go on. Could you add some printk
> calls to the clk core around the areas this patch touchs? That would help.
>
> Could you also provide a dump of /sys/kernel/debug/clk/clk_summary? That
> would help to understand the clock tree.
Sure,
These are the last kernel log lines before hard lockup:
[ 0.686357] io scheduler mq-deadline registered
[ 0.690907] io scheduler kyber registered
[ 0.699275] clk_core_prepare: clk: main_axi CLK_OPS_PARENT_ENABLE
main_axi is also the only debug output up to this point. This is the used
patch for debugging:
---8<---
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -211,8 +211,10 @@ static bool clk_core_is_prepared(struct clk_core *core)
return core->prepare_count;
if (!clk_pm_runtime_get(core)) {
- if (core->flags & CLK_OPS_PARENT_ENABLE)
+ if (core->flags & CLK_OPS_PARENT_ENABLE) {
+ pr_info("%s: clk: %s CLK_OPS_PARENT_ENABLE\n",
__func__, core->name);
clk_core_prepare_enable(core->parent);
+ }
ret = core->ops->is_prepared(core->hw);
if (core->flags & CLK_OPS_PARENT_ENABLE)
clk_core_disable_unprepare(core->parent);
@@ -251,8 +253,10 @@ static bool clk_core_is_enabled(struct clk_core *core)
}
}
- if (core->flags & CLK_OPS_PARENT_ENABLE)
+ if (core->flags & CLK_OPS_PARENT_ENABLE) {
+ pr_info("%s: clk: %s CLK_OPS_PARENT_ENABLE\n", __func__, core-
>name);
clk_core_prepare_enable(core->parent);
+ }
ret = core->ops->is_enabled(core->hw);
@@ -851,8 +855,10 @@ static void clk_core_unprepare(struct clk_core *core)
WARN(core->enable_count > 0, "Unpreparing enabled %s\n", core->name);
- if (core->flags & CLK_OPS_PARENT_ENABLE)
+ if (core->flags & CLK_OPS_PARENT_ENABLE) {
+ pr_info("%s: clk: %s CLK_OPS_PARENT_ENABLE\n", __func__, core-
>name);
clk_core_enable_lock(core->parent);
+ }
trace_clk_unprepare(core);
@@ -912,8 +918,10 @@ static int clk_core_prepare(struct clk_core *core)
if (ret)
goto runtime_put;
- if (core->flags & CLK_OPS_PARENT_ENABLE)
+ if (core->flags & CLK_OPS_PARENT_ENABLE) {
+ pr_info("%s: clk: %s CLK_OPS_PARENT_ENABLE\n",
__func__, core->name);
clk_core_enable_lock(core->parent);
+ }
trace_clk_prepare(core);
---8<---
And here is the output of clk_summary with 35b0fac808b9 reverted:
enable prepare protect
duty hardware
clock count count count rate
accuracy phase cycle enable
-------------------------------------------------------------------------------------------------------
pcf85063-clkout 0 0 0 0
0 0 50000 Y
dummy 0 0 0 0
0 0 50000 Y
clk_ext4 0 0 0 133000000
0 0 50000 Y
clk_ext3 0 0 0 133000000
0 0 50000 Y
clk_ext2 0 0 0 133000000
0 0 50000 Y
clk_ext1 0 0 0 133000000
0 0 50000 Y
osc_24m 8 12 0 24000000
0 0 50000 Y
sai7 0 0 0 24000000
0 0 50000 N
vpu_vc8000e 0 0 0 24000000
0 0 50000 N
vpu_vc8ke_root_clk 0 0 0 24000000
0 0 50000 N
pdm 0 0 0 24000000
0 0 50000 N
media_mipi_test_byte 0 0 0 24000000
0 0 50000 N
mem_repair 1 1 0 24000000
0 0 50000 Y
media_ldb 0 0 0 24000000
0 0 50000 N
media_cam2_pix 0 0 0 24000000
0 0 50000 N
media_cam2_pix_root_clk 0 0 0 24000000
0 0 50000 N
media_disp1_pix 0 0 0 24000000
0 0 50000 N
media_disp1_pix_root_clk 0 0 0 24000000
0 0 50000 N
media_cam1_pix 0 0 0 24000000
0 0 50000 N
media_cam1_pix_root_clk 0 0 0 24000000
0 0 50000 N
hdmi_ref_266m 0 0 0 24000000
0 0 50000 N
hdmi_24m 0 0 0 24000000
0 0 50000 N
hdmi_fdcc_tst 0 0 0 24000000
0 0 50000 N
ipp_do_clko2 0 0 0 24000000
0 0 50000 N
ipp_do_clko1 0 0 0 24000000
0 0 50000 N
wdog 1 1 0 24000000
0 0 50000 Y
wdog3_root_clk 0 0 0 24000000
0 0 50000 N
wdog2_root_clk 0 0 0 24000000
0 0 50000 N
wdog1_root_clk 1 1 0 24000000
0 0 50000 Y
gpt6 0 0 0 24000000
0 0 50000 N
gpt6_root_clk 0 0 0 24000000
0 0 50000 N
gpt5 0 0 0 24000000
0 0 50000 N
gpt5_root_clk 0 0 0 24000000
0 0 50000 N
gpt4 0 0 0 24000000
0 0 50000 N
gpt4_root_clk 0 0 0 24000000
0 0 50000 N
gpt3 0 0 0 24000000
0 0 50000 N
gpt3_root_clk 0 0 0 24000000
0 0 50000 N
gpt2 0 0 0 24000000
0 0 50000 N
gpt2_root_clk 0 0 0 24000000
0 0 50000 N
gpt1 0 0 0 24000000
0 0 50000 N
gpt1_root_clk 0 0 0 24000000
0 0 50000 N
pwm4 0 0 0 24000000
0 0 50000 N
pwm4_root_clk 0 0 0 24000000
0 0 50000 N
pwm3 0 0 0 24000000
0 0 50000 N
pwm3_root_clk 0 0 0 24000000
0 0 50000 N
pwm2 0 0 0 24000000
0 0 50000 N
pwm2_root_clk 0 0 0 24000000
0 0 50000 N
pwm1 0 0 0 24000000
0 0 50000 N
pwm1_root_clk 0 0 0 24000000
0 0 50000 N
usb_core_ref 0 0 0 24000000
0 0 50000 N
uart4 1 1 0 24000000
0 0 50000 Y
uart4_root_clk 4 4 0 24000000
0 0 50000 Y
i2c4 0 1 0 24000000
0 0 50000 N
i2c4_root_clk 0 1 0 24000000
0 0 50000 N
i2c3 0 0 0 24000000
0 0 50000 N
i2c3_root_clk 0 0 0 24000000
0 0 50000 N
i2c2 0 1 0 24000000
0 0 50000 N
i2c2_root_clk 0 1 0 24000000
0 0 50000 N
i2c1 0 1 0 24000000
0 0 50000 N
i2c1_root_clk 0 1 0 24000000
0 0 50000 N
sai6 0 0 0 24000000
0 0 50000 N
sai5 0 0 0 24000000
0 0 50000 N
sai4 0 0 0 24000000
0 0 50000 N
sai3 0 0 0 24000000
0 0 50000 N
sai2 0 0 0 24000000
0 0 50000 N
sai1 0 0 0 24000000
0 0 50000 N
i2c6 0 1 0 24000000
0 0 50000 N
i2c6_root_clk 0 1 0 24000000
0 0 50000 N
i2c5 0 0 0 24000000
0 0 50000 N
i2c5_root_clk 0 0 0 24000000
0 0 50000 N
pcie_aux 0 0 0 24000000
0 0 50000 N
pcie_root_clk 0 0 0 24000000
0 0 50000 N
vpu_g2 0 0 0 24000000
0 0 50000 N
vpu_g2_root_clk 0 0 0 24000000
0 0 50000 N
vpu_g1 0 0 0 24000000
0 0 50000 N
vpu_g1_root_clk 0 0 0 24000000
0 0 50000 N
media_disp2_pix 0 0 0 24000000
0 0 50000 N
media_disp2_pix_root_clk 0 0 0 24000000
0 0 50000 N
mipi_dsi_esc_rx 0 0 0 24000000
0 0 50000 N
ml_ahb 0 0 0 24000000
0 0 50000 N
ml_axi 0 0 0 24000000
0 0 50000 N
hdmi_axi 0 0 0 24000000
0 0 50000 N
hdmi_root_clk 0 0 0 24000000
0 0 50000 N
vpu_bus 0 0 0 24000000
0 0 50000 N
vpu_root_clk 0 0 0 24000000
0 0 50000 N
media_isp 0 0 0 24000000
0 0 50000 N
media_isp_root_clk 0 0 0 24000000
0 0 50000 N
ml_core 0 0 0 24000000
0 0 50000 N
npu_root_clk 0 0 0 24000000
0 0 50000 N
sys_pll3_ref_sel 0 0 0 24000000
0 0 50000 Y
sys_pll3 0 0 0 600000000
0 0 50000 Y
sys_pll3_bypass 0 0 0 600000000
0 0 50000 Y
sys_pll3_out 0 0 0 600000000
0 0 50000 N
sys_pll2_ref_sel 1 1 0 24000000
0 0 50000 Y
sys_pll2 1 1 0 1000000000
0 0 50000 Y
sys_pll2_bypass 1 1 0 1000000000
0 0 50000 Y
sys_pll2_out 5 5 0 1000000000
0 0 50000 Y
sys_pll2_1000m 1 1 0 1000000000
0 0 50000 Y
noc 1 1 0 1000000000
0 0 50000 Y
media_axi 0 0 0 500000000
0 0 50000 N
media_axi_root_clk 0 0 0 500000000
0 0 50000 N
sys_pll2_500m 1 1 0 500000000
0 0 50000 Y
hsio_axi 0 0 0 500000000
0 0 50000 N
usb_root_clk 0 0 0 500000000
0 0 50000 N
gic 1 1 0 500000000
0 0 50000 Y
nand 0 0 0 500000000
0 0 50000 N
nand_root_clk 0 0 0 500000000
0 0 50000 N
sys_pll2_333m 0 0 0 333333333
0 0 50000 Y
sys_pll2_250m 0 0 0 250000000
0 0 50000 Y
sys_pll2_200m 0 0 0 200000000
0 0 50000 Y
ecspi3 0 0 0 50000000
0 0 50000 N
ecspi3_root_clk 0 0 0 50000000
0 0 50000 N
ecspi2 0 0 0 50000000
0 0 50000 N
ecspi2_root_clk 0 0 0 50000000
0 0 50000 N
ecspi1 0 0 0 50000000
0 0 50000 N
ecspi1_root_clk 0 0 0 50000000
0 0 50000 N
m7_core 0 0 0 200000000
0 0 50000 N
sys_pll2_166m 0 0 0 166666666
0 0 50000 Y
sys_pll2_125m 2 2 0 125000000
0 0 50000 Y
enet_ref 1 1 0 125000000
0 0 50000 Y
enet_qos 1 1 0 125000000
0 0 50000 Y
hdmi_apb 0 0 0 125000000
0 0 50000 N
sys_pll2_100m 2 2 0 100000000
0 0 50000 Y
enet_timer 1 1 0 100000000
0 0 50000 Y
enet_qos_timer 1 1 0 100000000
0 0 50000 Y
sys_pll2_50m 1 1 0 50000000
0 0 50000 Y
enet_phy_ref 1 1 0 50000000
0 0 50000 Y
sys_pll1_ref_sel 1 1 0 24000000
0 0 50000 Y
sys_pll1 1 1 0 800000000
0 0 50000 Y
sys_pll1_bypass 1 1 0 800000000
0 0 50000 Y
sys_pll1_out 5 5 0 800000000
0 0 50000 Y
sys_pll1_800m 3 3 0 800000000
0 0 50000 Y
gpu2d_core 0 0 0 800000000
0 0 50000 N
gpu2d_root_clk 0 0 0 800000000
0 0 50000 N
gpu3d_shader_core 0 0 0 800000000
0 0 50000 N
gpu3d_core 0 0 0 800000000
0 0 50000 N
gpu3d_root_clk 0 0 0 800000000
0 0 50000 N
gpu_ahb 0 0 0 400000000
0 0 50000 N
gpu_axi 0 0 0 800000000
0 0 50000 N
gpu_root_clk 0 0 0 800000000
0 0 50000 N
audio_axi 0 0 0 800000000
0 0 50000 N
audio_ahb 0 0 0 400000000
0 0 50000 N
audio_root_clk 0 0 0 400000000
0 0 50000 N
noc_io 1 1 0 800000000
0 0 50000 Y
arm_a53_div 0 0 0 800000000
0 0 50000 N
dram_apb 1 1 0 160000000
0 0 50000 Y
media_apb 0 0 0 200000000
0 0 50000 N
media_apb_root_clk 0 0 0 200000000
0 0 50000 N
main_axi 1 1 0 400000000
0 0 50000 Y
sys_pll1_400m 0 0 0 400000000
0 0 50000 Y
usdhc3 0 0 0 400000000
0 0 50000 N
usdhc3_root_clk 0 0 0 400000000
0 0 50000 N
usdhc2 0 0 0 400000000
0 0 50000 N
usdhc2_root_clk 0 0 0 400000000
0 0 50000 N
usdhc1 0 0 0 200000000
0 0 50000 N
usdhc1_root_clk 0 0 0 200000000
0 0 50000 N
sys_pll1_266m 2 2 0 266666666
0 0 50000 Y
nand_usdhc_bus 1 1 0 266666666
0 0 50000 Y
nand_usdhc_rawnand_clk 0 0 0
266666666 0 0 50000 N
enet_axi 2 2 0 266666666
0 0 50000 Y
sim_enet_root_clk 2 2 0 266666666
0 0 50000 Y
enet_qos_root_clk 1 1 0
266666666 0 0 50000 Y
enet1_root_clk 1 1 0 266666666
0 0 50000 Y
sys_pll1_200m 0 0 0 200000000
0 0 50000 Y
sys_pll1_160m 0 0 0 160000000
0 0 50000 Y
sys_pll1_133m 1 1 0 133333333
0 0 50000 Y
ahb_root 9 4 0 133333333
0 0 50000 Y
ipg_root 11 11 0 66666667
0 0 50000 Y
tsensor_root_clk 1 1 0
66666667 0 0 50000 Y
hsio_root_clk 0 0 0 66666667
0 0 50000 N
sdma1_root_clk 6 1 0 66666667
0 0 50000 Y
qos_enet_root_clk 1 1 0
66666667 0 0 50000 Y
qos_root_clk 0 0 0 66666667
0 0 50000 N
ocotp_root_clk 0 0 0 66666667
0 0 50000 N
mu_root_clk 0 0 0 66666667
0 0 50000 N
gpio5_root_clk 1 1 0 66666667
0 0 50000 Y
gpio4_root_clk 1 1 0 66666667
0 0 50000 Y
gpio3_root_clk 1 1 0 66666667
0 0 50000 Y
gpio2_root_clk 1 1 0 66666667
0 0 50000 Y
gpio1_root_clk 1 1 0 66666667
0 0 50000 Y
sys_pll1_100m 1 1 0 100000000
0 0 50000 Y
usb_phy_ref 0 0 0 100000000
0 0 50000 N
usb_phy_root_clk 0 0 0 100000000
0 0 50000 N
qspi 1 1 0 100000000
0 0 50000 Y
qspi_root_clk 2 2 0 100000000
0 0 50000 Y
dram_alt 0 0 0 100000000
0 0 50000 N
dram_alt_root 0 0 0 25000000
0 0 50000 Y
sys_pll1_80m 0 0 0 80000000
0 0 50000 Y
uart2 0 0 0 80000000
0 0 50000 N
uart2_root_clk 0 0 0 80000000
0 0 50000 N
uart3 0 0 0 80000000
0 0 50000 N
uart3_root_clk 0 0 0 80000000
0 0 50000 N
uart1 0 0 0 80000000
0 0 50000 N
uart1_root_clk 0 0 0 80000000
0 0 50000 N
sys_pll1_40m 2 2 0 40000000
0 0 50000 Y
can2 1 1 0 40000000
0 0 50000 Y
can2_root_clk 1 1 0 40000000
0 0 50000 Y
can1 1 1 0 40000000
0 0 50000 Y
can1_root_clk 1 1 0 40000000
0 0 50000 Y
wrclk 0 0 0 40000000
0 0 50000 N
arm_pll_ref_sel 1 1 0 24000000
0 0 50000 Y
arm_pll 1 1 0 1200000000
0 0 50000 Y
arm_pll_bypass 1 1 0 1200000000
0 0 50000 Y
arm_pll_out 1 1 0 1200000000
0 0 50000 Y
arm_a53_core 1 1 0 1200000000
0 0 50000 Y
arm 1 1 0 1200000000
0 0 50000 Y
vpu_pll_ref_sel 0 0 0 24000000
0 0 50000 Y
vpu_pll 0 0 0 800000000
0 0 50000 Y
vpu_pll_bypass 0 0 0 800000000
0 0 50000 Y
vpu_pll_out 0 0 0 800000000
0 0 50000 N
gpu_pll_ref_sel 0 0 0 24000000
0 0 50000 Y
gpu_pll 0 0 0 1000000000
0 0 50000 Y
gpu_pll_bypass 0 0 0 1000000000
0 0 50000 Y
gpu_pll_out 0 0 0 1000000000
0 0 50000 N
dram_pll_ref_sel 1 1 0 24000000
0 0 50000 Y
dram_pll 1 1 0 1000000000
0 0 50000 Y
dram_pll_bypass 1 1 0 1000000000
0 0 50000 Y
dram_pll_out 1 1 0 1000000000
0 0 50000 Y
dram_core_clk 2 2 0 1000000000
0 0 50000 Y
dram1_root_clk 1 1 0 1000000000
0 0 50000 Y
video_pll1_ref_sel 0 0 0 24000000
0 0 50000 Y
video_pll1 0 0 0 594000000
0 0 50000 Y
video_pll1_bypass 0 0 0 594000000
0 0 50000 Y
video_pll1_out 0 0 0 594000000
0 0 50000 N
media_mipi_phy1_ref 0 0 0 27000000
0 0 50000 N
media_mipi_phy1_ref_root 0 0 0
27000000 0 0 50000 N
audio_pll2_ref_sel 0 0 0 24000000
0 0 50000 Y
audio_pll2 0 0 0 361267196
0 0 50000 Y
audio_pll2_bypass 0 0 0 361267196
0 0 50000 Y
audio_pll2_out 0 0 0 361267196
0 0 50000 N
audio_pll1_ref_sel 0 0 0 24000000
0 0 50000 Y
audio_pll1 0 0 0 393215995
0 0 50000 Y
audio_pll1_bypass 0 0 0 393215995
0 0 50000 Y
audio_pll1_out 0 0 0 393215995
0 0 50000 N
clkout2_sel 0 0 0 393215995
0 0 50000 Y
clkout2_div 0 0 0 393215995
0 0 50000 Y
clkout2 0 0 0 393215995
0 0 50000 N
clkout1_sel 0 0 0 393215995
0 0 50000 Y
clkout1_div 0 0 0 393215995
0 0 50000 Y
clkout1 0 0 0 393215995
0 0 50000 N
osc_32k 0 0 0 32768
0 0 50000 Y
Thanks for the work and best regards,
Alexander
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: "Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Nícolas F . R . A . Prado" <nfraprado@collabora.com>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v2 1/2] clk: core: Honor CLK_OPS_PARENT_ENABLE for clk gate ops
Date: Tue, 30 Aug 2022 14:37:55 +0200 [thread overview]
Message-ID: <2254919.ElGaqSPkdT@steina-w> (raw)
In-Reply-To: <CAGXv+5E788T01XJF-dYRW6ZB5-TTU_L5=0hT3AQ0g+zA=LzG2w@mail.gmail.com>
Hi,
Am Montag, 29. August 2022, 11:22:16 CEST schrieb Chen-Yu Tsai:
> Hi,
>
> On Fri, Aug 26, 2022 at 8:28 PM Alexander Stein
>
> <alexander.stein@ew.tq-group.com> wrote:
> > Hi everybody,
> >
> > Am Montag, 22. August 2022, 10:14:23 CEST schrieb Chen-Yu Tsai:
> > > In the previous commits that added CLK_OPS_PARENT_ENABLE, support for
> > > this flag was only added to rate change operations (rate setting and
> > > reparent) and disabling unused subtree. It was not added to the
> > > clock gate related operations. Any hardware driver that needs it for
> > > these operations will either see bogus results, or worse, hang.
> > >
> > > This has been seen on MT8192 and MT8195, where the imp_ii2_* clk
> > > drivers set this, but dumping debugfs clk_summary would cause it
> > > to hang.
> > >
> > > Fixes: fc8726a2c021 ("clk: core: support clocks which requires parents
> > > enable (part 2)") Fixes: a4b3518d146f ("clk: core: support clocks which
> > > requires parents enable (part 1)") Signed-off-by: Chen-Yu Tsai
> > > <wenst@chromium.org>
> > > Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > > Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
> > > ---
> > >
> > > drivers/clk/clk.c | 28 ++++++++++++++++++++++++++++
> > > 1 file changed, 28 insertions(+)
> > >
> > > diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> > > index 7fc191c15507..9b365cd6d14b 100644
> > > --- a/drivers/clk/clk.c
> > > +++ b/drivers/clk/clk.c
> > > @@ -196,6 +196,9 @@ static bool clk_core_rate_is_protected(struct
> > > clk_core
> > > *core) return core->protect_count;
> > >
> > > }
> > >
> > > +static int clk_core_prepare_enable(struct clk_core *core);
> > > +static void clk_core_disable_unprepare(struct clk_core *core);
> > > +
> > >
> > > static bool clk_core_is_prepared(struct clk_core *core)
> > > {
> > >
> > > bool ret = false;
> > >
> > > @@ -208,7 +211,11 @@ static bool clk_core_is_prepared(struct clk_core
> > > *core) return core->prepare_count;
> > >
> > > if (!clk_pm_runtime_get(core)) {
> > >
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_prepare_enable(core->parent);
> > >
> > > ret = core->ops->is_prepared(core->hw);
> > >
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_disable_unprepare(core->parent);
> > >
> > > clk_pm_runtime_put(core);
> > >
> > > }
> > >
> > > @@ -244,7 +251,13 @@ static bool clk_core_is_enabled(struct clk_core
> > > *core)
> > >
> > > }
> > >
> > > }
> > >
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_prepare_enable(core->parent);
> > > +
> > >
> > > ret = core->ops->is_enabled(core->hw);
> > >
> > > +
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_disable_unprepare(core->parent);
> > >
> > > done:
> > > if (core->rpm_enabled)
> > >
> > > pm_runtime_put(core->dev);
> > >
> > > @@ -812,6 +825,9 @@ int clk_rate_exclusive_get(struct clk *clk)
> > >
> > > }
> > > EXPORT_SYMBOL_GPL(clk_rate_exclusive_get);
> > >
> > > +static int clk_core_enable_lock(struct clk_core *core);
> > > +static void clk_core_disable_lock(struct clk_core *core);
> > > +
> > >
> > > static void clk_core_unprepare(struct clk_core *core)
> > > {
> > >
> > > lockdep_assert_held(&prepare_lock);
> > >
> > > @@ -835,6 +851,9 @@ static void clk_core_unprepare(struct clk_core
> > > *core)
> > >
> > > WARN(core->enable_count > 0, "Unpreparing enabled %s\n", core-
> > >
> > >name);
> > >
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_enable_lock(core->parent);
> > > +
> > >
> > > trace_clk_unprepare(core);
> > >
> > > if (core->ops->unprepare)
> > >
> > > @@ -843,6 +862,9 @@ static void clk_core_unprepare(struct clk_core
> > > *core)
> > >
> > > clk_pm_runtime_put(core);
> > >
> > > trace_clk_unprepare_complete(core);
> > >
> > > +
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_disable_lock(core->parent);
> > >
> > > clk_core_unprepare(core->parent);
> > >
> > > }
> > >
> > > @@ -891,6 +913,9 @@ static int clk_core_prepare(struct clk_core *core)
> > >
> > > if (ret)
> > >
> > > goto runtime_put;
> > >
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_enable_lock(core->parent);
> > > +
> > >
> > > trace_clk_prepare(core);
> > >
> > > if (core->ops->prepare)
> > >
> > > @@ -898,6 +923,9 @@ static int clk_core_prepare(struct clk_core *core)
> > >
> > > trace_clk_prepare_complete(core);
> > >
> > > + if (core->flags & CLK_OPS_PARENT_ENABLE)
> > > + clk_core_disable_lock(core->parent);
> > > +
> > >
> > > if (ret)
> > >
> > > goto unprepare;
> > >
> > > }
> >
> > Unfortunately this completely locks up my i.MX8M Plus based board during
> > early boot.
> > I'm currently running on next-20220826 using
> > arch/arm64/boot/dts/freescale/
> > imx8mp-tqma8mpql-mba8mpxl.dts
> > Reverting this patch gets my board booting again. dmesg until hard lockup
> > below.
>
> The standard logs don't have anything to go on. Could you add some printk
> calls to the clk core around the areas this patch touchs? That would help.
>
> Could you also provide a dump of /sys/kernel/debug/clk/clk_summary? That
> would help to understand the clock tree.
Sure,
These are the last kernel log lines before hard lockup:
[ 0.686357] io scheduler mq-deadline registered
[ 0.690907] io scheduler kyber registered
[ 0.699275] clk_core_prepare: clk: main_axi CLK_OPS_PARENT_ENABLE
main_axi is also the only debug output up to this point. This is the used
patch for debugging:
---8<---
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -211,8 +211,10 @@ static bool clk_core_is_prepared(struct clk_core *core)
return core->prepare_count;
if (!clk_pm_runtime_get(core)) {
- if (core->flags & CLK_OPS_PARENT_ENABLE)
+ if (core->flags & CLK_OPS_PARENT_ENABLE) {
+ pr_info("%s: clk: %s CLK_OPS_PARENT_ENABLE\n",
__func__, core->name);
clk_core_prepare_enable(core->parent);
+ }
ret = core->ops->is_prepared(core->hw);
if (core->flags & CLK_OPS_PARENT_ENABLE)
clk_core_disable_unprepare(core->parent);
@@ -251,8 +253,10 @@ static bool clk_core_is_enabled(struct clk_core *core)
}
}
- if (core->flags & CLK_OPS_PARENT_ENABLE)
+ if (core->flags & CLK_OPS_PARENT_ENABLE) {
+ pr_info("%s: clk: %s CLK_OPS_PARENT_ENABLE\n", __func__, core-
>name);
clk_core_prepare_enable(core->parent);
+ }
ret = core->ops->is_enabled(core->hw);
@@ -851,8 +855,10 @@ static void clk_core_unprepare(struct clk_core *core)
WARN(core->enable_count > 0, "Unpreparing enabled %s\n", core->name);
- if (core->flags & CLK_OPS_PARENT_ENABLE)
+ if (core->flags & CLK_OPS_PARENT_ENABLE) {
+ pr_info("%s: clk: %s CLK_OPS_PARENT_ENABLE\n", __func__, core-
>name);
clk_core_enable_lock(core->parent);
+ }
trace_clk_unprepare(core);
@@ -912,8 +918,10 @@ static int clk_core_prepare(struct clk_core *core)
if (ret)
goto runtime_put;
- if (core->flags & CLK_OPS_PARENT_ENABLE)
+ if (core->flags & CLK_OPS_PARENT_ENABLE) {
+ pr_info("%s: clk: %s CLK_OPS_PARENT_ENABLE\n",
__func__, core->name);
clk_core_enable_lock(core->parent);
+ }
trace_clk_prepare(core);
---8<---
And here is the output of clk_summary with 35b0fac808b9 reverted:
enable prepare protect
duty hardware
clock count count count rate
accuracy phase cycle enable
-------------------------------------------------------------------------------------------------------
pcf85063-clkout 0 0 0 0
0 0 50000 Y
dummy 0 0 0 0
0 0 50000 Y
clk_ext4 0 0 0 133000000
0 0 50000 Y
clk_ext3 0 0 0 133000000
0 0 50000 Y
clk_ext2 0 0 0 133000000
0 0 50000 Y
clk_ext1 0 0 0 133000000
0 0 50000 Y
osc_24m 8 12 0 24000000
0 0 50000 Y
sai7 0 0 0 24000000
0 0 50000 N
vpu_vc8000e 0 0 0 24000000
0 0 50000 N
vpu_vc8ke_root_clk 0 0 0 24000000
0 0 50000 N
pdm 0 0 0 24000000
0 0 50000 N
media_mipi_test_byte 0 0 0 24000000
0 0 50000 N
mem_repair 1 1 0 24000000
0 0 50000 Y
media_ldb 0 0 0 24000000
0 0 50000 N
media_cam2_pix 0 0 0 24000000
0 0 50000 N
media_cam2_pix_root_clk 0 0 0 24000000
0 0 50000 N
media_disp1_pix 0 0 0 24000000
0 0 50000 N
media_disp1_pix_root_clk 0 0 0 24000000
0 0 50000 N
media_cam1_pix 0 0 0 24000000
0 0 50000 N
media_cam1_pix_root_clk 0 0 0 24000000
0 0 50000 N
hdmi_ref_266m 0 0 0 24000000
0 0 50000 N
hdmi_24m 0 0 0 24000000
0 0 50000 N
hdmi_fdcc_tst 0 0 0 24000000
0 0 50000 N
ipp_do_clko2 0 0 0 24000000
0 0 50000 N
ipp_do_clko1 0 0 0 24000000
0 0 50000 N
wdog 1 1 0 24000000
0 0 50000 Y
wdog3_root_clk 0 0 0 24000000
0 0 50000 N
wdog2_root_clk 0 0 0 24000000
0 0 50000 N
wdog1_root_clk 1 1 0 24000000
0 0 50000 Y
gpt6 0 0 0 24000000
0 0 50000 N
gpt6_root_clk 0 0 0 24000000
0 0 50000 N
gpt5 0 0 0 24000000
0 0 50000 N
gpt5_root_clk 0 0 0 24000000
0 0 50000 N
gpt4 0 0 0 24000000
0 0 50000 N
gpt4_root_clk 0 0 0 24000000
0 0 50000 N
gpt3 0 0 0 24000000
0 0 50000 N
gpt3_root_clk 0 0 0 24000000
0 0 50000 N
gpt2 0 0 0 24000000
0 0 50000 N
gpt2_root_clk 0 0 0 24000000
0 0 50000 N
gpt1 0 0 0 24000000
0 0 50000 N
gpt1_root_clk 0 0 0 24000000
0 0 50000 N
pwm4 0 0 0 24000000
0 0 50000 N
pwm4_root_clk 0 0 0 24000000
0 0 50000 N
pwm3 0 0 0 24000000
0 0 50000 N
pwm3_root_clk 0 0 0 24000000
0 0 50000 N
pwm2 0 0 0 24000000
0 0 50000 N
pwm2_root_clk 0 0 0 24000000
0 0 50000 N
pwm1 0 0 0 24000000
0 0 50000 N
pwm1_root_clk 0 0 0 24000000
0 0 50000 N
usb_core_ref 0 0 0 24000000
0 0 50000 N
uart4 1 1 0 24000000
0 0 50000 Y
uart4_root_clk 4 4 0 24000000
0 0 50000 Y
i2c4 0 1 0 24000000
0 0 50000 N
i2c4_root_clk 0 1 0 24000000
0 0 50000 N
i2c3 0 0 0 24000000
0 0 50000 N
i2c3_root_clk 0 0 0 24000000
0 0 50000 N
i2c2 0 1 0 24000000
0 0 50000 N
i2c2_root_clk 0 1 0 24000000
0 0 50000 N
i2c1 0 1 0 24000000
0 0 50000 N
i2c1_root_clk 0 1 0 24000000
0 0 50000 N
sai6 0 0 0 24000000
0 0 50000 N
sai5 0 0 0 24000000
0 0 50000 N
sai4 0 0 0 24000000
0 0 50000 N
sai3 0 0 0 24000000
0 0 50000 N
sai2 0 0 0 24000000
0 0 50000 N
sai1 0 0 0 24000000
0 0 50000 N
i2c6 0 1 0 24000000
0 0 50000 N
i2c6_root_clk 0 1 0 24000000
0 0 50000 N
i2c5 0 0 0 24000000
0 0 50000 N
i2c5_root_clk 0 0 0 24000000
0 0 50000 N
pcie_aux 0 0 0 24000000
0 0 50000 N
pcie_root_clk 0 0 0 24000000
0 0 50000 N
vpu_g2 0 0 0 24000000
0 0 50000 N
vpu_g2_root_clk 0 0 0 24000000
0 0 50000 N
vpu_g1 0 0 0 24000000
0 0 50000 N
vpu_g1_root_clk 0 0 0 24000000
0 0 50000 N
media_disp2_pix 0 0 0 24000000
0 0 50000 N
media_disp2_pix_root_clk 0 0 0 24000000
0 0 50000 N
mipi_dsi_esc_rx 0 0 0 24000000
0 0 50000 N
ml_ahb 0 0 0 24000000
0 0 50000 N
ml_axi 0 0 0 24000000
0 0 50000 N
hdmi_axi 0 0 0 24000000
0 0 50000 N
hdmi_root_clk 0 0 0 24000000
0 0 50000 N
vpu_bus 0 0 0 24000000
0 0 50000 N
vpu_root_clk 0 0 0 24000000
0 0 50000 N
media_isp 0 0 0 24000000
0 0 50000 N
media_isp_root_clk 0 0 0 24000000
0 0 50000 N
ml_core 0 0 0 24000000
0 0 50000 N
npu_root_clk 0 0 0 24000000
0 0 50000 N
sys_pll3_ref_sel 0 0 0 24000000
0 0 50000 Y
sys_pll3 0 0 0 600000000
0 0 50000 Y
sys_pll3_bypass 0 0 0 600000000
0 0 50000 Y
sys_pll3_out 0 0 0 600000000
0 0 50000 N
sys_pll2_ref_sel 1 1 0 24000000
0 0 50000 Y
sys_pll2 1 1 0 1000000000
0 0 50000 Y
sys_pll2_bypass 1 1 0 1000000000
0 0 50000 Y
sys_pll2_out 5 5 0 1000000000
0 0 50000 Y
sys_pll2_1000m 1 1 0 1000000000
0 0 50000 Y
noc 1 1 0 1000000000
0 0 50000 Y
media_axi 0 0 0 500000000
0 0 50000 N
media_axi_root_clk 0 0 0 500000000
0 0 50000 N
sys_pll2_500m 1 1 0 500000000
0 0 50000 Y
hsio_axi 0 0 0 500000000
0 0 50000 N
usb_root_clk 0 0 0 500000000
0 0 50000 N
gic 1 1 0 500000000
0 0 50000 Y
nand 0 0 0 500000000
0 0 50000 N
nand_root_clk 0 0 0 500000000
0 0 50000 N
sys_pll2_333m 0 0 0 333333333
0 0 50000 Y
sys_pll2_250m 0 0 0 250000000
0 0 50000 Y
sys_pll2_200m 0 0 0 200000000
0 0 50000 Y
ecspi3 0 0 0 50000000
0 0 50000 N
ecspi3_root_clk 0 0 0 50000000
0 0 50000 N
ecspi2 0 0 0 50000000
0 0 50000 N
ecspi2_root_clk 0 0 0 50000000
0 0 50000 N
ecspi1 0 0 0 50000000
0 0 50000 N
ecspi1_root_clk 0 0 0 50000000
0 0 50000 N
m7_core 0 0 0 200000000
0 0 50000 N
sys_pll2_166m 0 0 0 166666666
0 0 50000 Y
sys_pll2_125m 2 2 0 125000000
0 0 50000 Y
enet_ref 1 1 0 125000000
0 0 50000 Y
enet_qos 1 1 0 125000000
0 0 50000 Y
hdmi_apb 0 0 0 125000000
0 0 50000 N
sys_pll2_100m 2 2 0 100000000
0 0 50000 Y
enet_timer 1 1 0 100000000
0 0 50000 Y
enet_qos_timer 1 1 0 100000000
0 0 50000 Y
sys_pll2_50m 1 1 0 50000000
0 0 50000 Y
enet_phy_ref 1 1 0 50000000
0 0 50000 Y
sys_pll1_ref_sel 1 1 0 24000000
0 0 50000 Y
sys_pll1 1 1 0 800000000
0 0 50000 Y
sys_pll1_bypass 1 1 0 800000000
0 0 50000 Y
sys_pll1_out 5 5 0 800000000
0 0 50000 Y
sys_pll1_800m 3 3 0 800000000
0 0 50000 Y
gpu2d_core 0 0 0 800000000
0 0 50000 N
gpu2d_root_clk 0 0 0 800000000
0 0 50000 N
gpu3d_shader_core 0 0 0 800000000
0 0 50000 N
gpu3d_core 0 0 0 800000000
0 0 50000 N
gpu3d_root_clk 0 0 0 800000000
0 0 50000 N
gpu_ahb 0 0 0 400000000
0 0 50000 N
gpu_axi 0 0 0 800000000
0 0 50000 N
gpu_root_clk 0 0 0 800000000
0 0 50000 N
audio_axi 0 0 0 800000000
0 0 50000 N
audio_ahb 0 0 0 400000000
0 0 50000 N
audio_root_clk 0 0 0 400000000
0 0 50000 N
noc_io 1 1 0 800000000
0 0 50000 Y
arm_a53_div 0 0 0 800000000
0 0 50000 N
dram_apb 1 1 0 160000000
0 0 50000 Y
media_apb 0 0 0 200000000
0 0 50000 N
media_apb_root_clk 0 0 0 200000000
0 0 50000 N
main_axi 1 1 0 400000000
0 0 50000 Y
sys_pll1_400m 0 0 0 400000000
0 0 50000 Y
usdhc3 0 0 0 400000000
0 0 50000 N
usdhc3_root_clk 0 0 0 400000000
0 0 50000 N
usdhc2 0 0 0 400000000
0 0 50000 N
usdhc2_root_clk 0 0 0 400000000
0 0 50000 N
usdhc1 0 0 0 200000000
0 0 50000 N
usdhc1_root_clk 0 0 0 200000000
0 0 50000 N
sys_pll1_266m 2 2 0 266666666
0 0 50000 Y
nand_usdhc_bus 1 1 0 266666666
0 0 50000 Y
nand_usdhc_rawnand_clk 0 0 0
266666666 0 0 50000 N
enet_axi 2 2 0 266666666
0 0 50000 Y
sim_enet_root_clk 2 2 0 266666666
0 0 50000 Y
enet_qos_root_clk 1 1 0
266666666 0 0 50000 Y
enet1_root_clk 1 1 0 266666666
0 0 50000 Y
sys_pll1_200m 0 0 0 200000000
0 0 50000 Y
sys_pll1_160m 0 0 0 160000000
0 0 50000 Y
sys_pll1_133m 1 1 0 133333333
0 0 50000 Y
ahb_root 9 4 0 133333333
0 0 50000 Y
ipg_root 11 11 0 66666667
0 0 50000 Y
tsensor_root_clk 1 1 0
66666667 0 0 50000 Y
hsio_root_clk 0 0 0 66666667
0 0 50000 N
sdma1_root_clk 6 1 0 66666667
0 0 50000 Y
qos_enet_root_clk 1 1 0
66666667 0 0 50000 Y
qos_root_clk 0 0 0 66666667
0 0 50000 N
ocotp_root_clk 0 0 0 66666667
0 0 50000 N
mu_root_clk 0 0 0 66666667
0 0 50000 N
gpio5_root_clk 1 1 0 66666667
0 0 50000 Y
gpio4_root_clk 1 1 0 66666667
0 0 50000 Y
gpio3_root_clk 1 1 0 66666667
0 0 50000 Y
gpio2_root_clk 1 1 0 66666667
0 0 50000 Y
gpio1_root_clk 1 1 0 66666667
0 0 50000 Y
sys_pll1_100m 1 1 0 100000000
0 0 50000 Y
usb_phy_ref 0 0 0 100000000
0 0 50000 N
usb_phy_root_clk 0 0 0 100000000
0 0 50000 N
qspi 1 1 0 100000000
0 0 50000 Y
qspi_root_clk 2 2 0 100000000
0 0 50000 Y
dram_alt 0 0 0 100000000
0 0 50000 N
dram_alt_root 0 0 0 25000000
0 0 50000 Y
sys_pll1_80m 0 0 0 80000000
0 0 50000 Y
uart2 0 0 0 80000000
0 0 50000 N
uart2_root_clk 0 0 0 80000000
0 0 50000 N
uart3 0 0 0 80000000
0 0 50000 N
uart3_root_clk 0 0 0 80000000
0 0 50000 N
uart1 0 0 0 80000000
0 0 50000 N
uart1_root_clk 0 0 0 80000000
0 0 50000 N
sys_pll1_40m 2 2 0 40000000
0 0 50000 Y
can2 1 1 0 40000000
0 0 50000 Y
can2_root_clk 1 1 0 40000000
0 0 50000 Y
can1 1 1 0 40000000
0 0 50000 Y
can1_root_clk 1 1 0 40000000
0 0 50000 Y
wrclk 0 0 0 40000000
0 0 50000 N
arm_pll_ref_sel 1 1 0 24000000
0 0 50000 Y
arm_pll 1 1 0 1200000000
0 0 50000 Y
arm_pll_bypass 1 1 0 1200000000
0 0 50000 Y
arm_pll_out 1 1 0 1200000000
0 0 50000 Y
arm_a53_core 1 1 0 1200000000
0 0 50000 Y
arm 1 1 0 1200000000
0 0 50000 Y
vpu_pll_ref_sel 0 0 0 24000000
0 0 50000 Y
vpu_pll 0 0 0 800000000
0 0 50000 Y
vpu_pll_bypass 0 0 0 800000000
0 0 50000 Y
vpu_pll_out 0 0 0 800000000
0 0 50000 N
gpu_pll_ref_sel 0 0 0 24000000
0 0 50000 Y
gpu_pll 0 0 0 1000000000
0 0 50000 Y
gpu_pll_bypass 0 0 0 1000000000
0 0 50000 Y
gpu_pll_out 0 0 0 1000000000
0 0 50000 N
dram_pll_ref_sel 1 1 0 24000000
0 0 50000 Y
dram_pll 1 1 0 1000000000
0 0 50000 Y
dram_pll_bypass 1 1 0 1000000000
0 0 50000 Y
dram_pll_out 1 1 0 1000000000
0 0 50000 Y
dram_core_clk 2 2 0 1000000000
0 0 50000 Y
dram1_root_clk 1 1 0 1000000000
0 0 50000 Y
video_pll1_ref_sel 0 0 0 24000000
0 0 50000 Y
video_pll1 0 0 0 594000000
0 0 50000 Y
video_pll1_bypass 0 0 0 594000000
0 0 50000 Y
video_pll1_out 0 0 0 594000000
0 0 50000 N
media_mipi_phy1_ref 0 0 0 27000000
0 0 50000 N
media_mipi_phy1_ref_root 0 0 0
27000000 0 0 50000 N
audio_pll2_ref_sel 0 0 0 24000000
0 0 50000 Y
audio_pll2 0 0 0 361267196
0 0 50000 Y
audio_pll2_bypass 0 0 0 361267196
0 0 50000 Y
audio_pll2_out 0 0 0 361267196
0 0 50000 N
audio_pll1_ref_sel 0 0 0 24000000
0 0 50000 Y
audio_pll1 0 0 0 393215995
0 0 50000 Y
audio_pll1_bypass 0 0 0 393215995
0 0 50000 Y
audio_pll1_out 0 0 0 393215995
0 0 50000 N
clkout2_sel 0 0 0 393215995
0 0 50000 Y
clkout2_div 0 0 0 393215995
0 0 50000 Y
clkout2 0 0 0 393215995
0 0 50000 N
clkout1_sel 0 0 0 393215995
0 0 50000 Y
clkout1_div 0 0 0 393215995
0 0 50000 Y
clkout1 0 0 0 393215995
0 0 50000 N
osc_32k 0 0 0 32768
0 0 50000 Y
Thanks for the work and best regards,
Alexander
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-08-30 12:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-22 8:14 [PATCH RESEND v2 0/2] clk: Fix CLK_OPS_PARENT_ENABLE and runtime PM Chen-Yu Tsai
2022-08-22 8:14 ` Chen-Yu Tsai
2022-08-22 8:14 ` [PATCH RESEND v2 1/2] clk: core: Honor CLK_OPS_PARENT_ENABLE for clk gate ops Chen-Yu Tsai
2022-08-22 8:14 ` Chen-Yu Tsai
2022-08-22 23:18 ` Stephen Boyd
2022-08-26 12:28 ` Alexander Stein
2022-08-26 12:28 ` Alexander Stein
2022-08-29 9:22 ` Chen-Yu Tsai
2022-08-29 9:22 ` Chen-Yu Tsai
2022-08-29 21:03 ` Stephen Boyd
2022-08-30 12:37 ` Alexander Stein [this message]
2022-08-30 12:37 ` Alexander Stein
2022-08-30 13:40 ` Chen-Yu Tsai
2022-08-30 13:40 ` Chen-Yu Tsai
2022-08-31 7:40 ` Alexander Stein
2022-08-31 7:40 ` Alexander Stein
2022-08-31 13:51 ` Marcel Ziswiler
2022-08-31 13:51 ` Marcel Ziswiler
2022-08-22 8:14 ` [PATCH RESEND v2 2/2] clk: core: Fix runtime PM sequence in clk_core_unprepare() Chen-Yu Tsai
2022-08-22 8:14 ` Chen-Yu Tsai
2022-08-22 23:18 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2254919.ElGaqSPkdT@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.