All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stefan Wahren <stefan.wahren@i2se.com>
Cc: bcm-kernel-feedback-list@broadcom.com,
	Maxime Ripard <maxime@cerno.tech>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Stefan Wahren <stefan.wahren@i2se.com>,
	Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH 1/3] clk: bcm: rpi: Prevent out-of-bounds access
Date: Tue, 23 Aug 2022 15:52:01 -0700	[thread overview]
Message-ID: <20220823225203.92B6DC433D6@smtp.kernel.org> (raw)
In-Reply-To: <20220713154953.3336-2-stefan.wahren@i2se.com>

Quoting Stefan Wahren (2022-07-13 08:49:51)
> The while loop in raspberrypi_discover_clocks() relies on the assumption
> that the id of the last clock element is zero. Because this data comes
> from the Videocore firmware and it doesn't guarantuee such a behavior
> this could lead to out-of-bounds access. So fix this by providing
> a sentinel element.
> 
> Fixes: 93d2725affd6 ("clk: bcm: rpi: Discover the firmware clocks")
> Link: https://github.com/raspberrypi/firmware/issues/1688
> Suggested-by: Phil Elwell <phil@raspberrypi.com>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---

Applied to clk-fixes

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stefan Wahren <stefan.wahren@i2se.com>
Cc: bcm-kernel-feedback-list@broadcom.com,
	Maxime Ripard <maxime@cerno.tech>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Stefan Wahren <stefan.wahren@i2se.com>,
	Phil Elwell <phil@raspberrypi.com>
Subject: Re: [PATCH 1/3] clk: bcm: rpi: Prevent out-of-bounds access
Date: Tue, 23 Aug 2022 15:52:01 -0700	[thread overview]
Message-ID: <20220823225203.92B6DC433D6@smtp.kernel.org> (raw)
In-Reply-To: <20220713154953.3336-2-stefan.wahren@i2se.com>

Quoting Stefan Wahren (2022-07-13 08:49:51)
> The while loop in raspberrypi_discover_clocks() relies on the assumption
> that the id of the last clock element is zero. Because this data comes
> from the Videocore firmware and it doesn't guarantuee such a behavior
> this could lead to out-of-bounds access. So fix this by providing
> a sentinel element.
> 
> Fixes: 93d2725affd6 ("clk: bcm: rpi: Discover the firmware clocks")
> Link: https://github.com/raspberrypi/firmware/issues/1688
> Suggested-by: Phil Elwell <phil@raspberrypi.com>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---

Applied to clk-fixes

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-08-23 22:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13 15:49 [PATCH 0/3] clk: bcm: rpi: Fixes and improvement Stefan Wahren
2022-07-13 15:49 ` Stefan Wahren
2022-07-13 15:49 ` [PATCH 1/3] clk: bcm: rpi: Prevent out-of-bounds access Stefan Wahren
2022-07-13 15:49   ` Stefan Wahren
2022-07-13 16:25   ` Florian Fainelli
2022-07-13 16:25     ` Florian Fainelli
2022-08-23 22:52   ` Stephen Boyd [this message]
2022-08-23 22:52     ` Stephen Boyd
2022-07-13 15:49 ` [PATCH 2/3] clk: bcm: rpi: Add missing newline Stefan Wahren
2022-07-13 15:49   ` Stefan Wahren
2022-07-13 16:26   ` Florian Fainelli
2022-07-13 16:26     ` Florian Fainelli
2022-08-23 22:51   ` Stephen Boyd
2022-08-23 22:51     ` Stephen Boyd
2022-07-13 15:49 ` [PATCH 3/3] clk: bcm: rpi: Show clock id limit in error case Stefan Wahren
2022-07-13 15:49   ` Stefan Wahren
2022-07-13 16:33   ` Florian Fainelli
2022-07-13 16:33     ` Florian Fainelli
2022-08-23 22:51   ` Stephen Boyd
2022-08-23 22:51     ` Stephen Boyd
2022-07-25  8:18 ` [PATCH 0/3] clk: bcm: rpi: Fixes and improvement Ivan T. Ivanov
2022-07-25  8:18   ` Ivan T. Ivanov
2022-08-04 17:58   ` Florian Fainelli
2022-08-04 17:58     ` Florian Fainelli
2022-08-15 18:15     ` Stefan Wahren
2022-08-15 18:15       ` Stefan Wahren
2022-08-23 22:50       ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220823225203.92B6DC433D6@smtp.kernel.org \
    --to=sboyd@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime@cerno.tech \
    --cc=mturquette@baylibre.com \
    --cc=phil@raspberrypi.com \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.