From: Dan Carpenter <dan.carpenter@oracle.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: dri-devel@lists.freedesktop.org,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/tve200: Fix smatch warning
Date: Fri, 26 Aug 2022 15:05:07 +0300 [thread overview]
Message-ID: <20220826120507.GI2030@kadam> (raw)
In-Reply-To: <CACRpkdZKUGu_BCP1sUWU_-ObNuc9MhgO98WRi-6OT4Vv-VYibg@mail.gmail.com>
On Fri, Aug 26, 2022 at 01:35:56PM +0200, Linus Walleij wrote:
> On Thu, May 5, 2022 at 11:52 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> > The "ret" variable is ambiguously returning something that
> > could be zero in the tve200_modeset_init() function, assign
> > it an explicit error return code to make this unambiguous.
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Would someone show mercy on this patch and review it so I
> can apply it?
>
> Dan maybe? If it solves the problem you reported.
Yes. This patch makes me happy. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/tve200: Fix smatch warning
Date: Fri, 26 Aug 2022 15:05:07 +0300 [thread overview]
Message-ID: <20220826120507.GI2030@kadam> (raw)
In-Reply-To: <CACRpkdZKUGu_BCP1sUWU_-ObNuc9MhgO98WRi-6OT4Vv-VYibg@mail.gmail.com>
On Fri, Aug 26, 2022 at 01:35:56PM +0200, Linus Walleij wrote:
> On Thu, May 5, 2022 at 11:52 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> > The "ret" variable is ambiguously returning something that
> > could be zero in the tve200_modeset_init() function, assign
> > it an explicit error return code to make this unambiguous.
> >
> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> Would someone show mercy on this patch and review it so I
> can apply it?
>
> Dan maybe? If it solves the problem you reported.
Yes. This patch makes me happy. Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2022-08-26 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 21:50 [PATCH] drm/tve200: Fix smatch warning Linus Walleij
2022-05-05 21:50 ` Linus Walleij
2022-08-26 11:35 ` Linus Walleij
2022-08-26 11:35 ` Linus Walleij
2022-08-26 12:05 ` Dan Carpenter [this message]
2022-08-26 12:05 ` Dan Carpenter
2022-08-26 12:23 ` Linus Walleij
2022-08-26 12:23 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826120507.GI2030@kadam \
--to=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.