From: Tom Rini <trini@konsulko.com>
To: Andrew Davis <afd@ti.com>
Cc: Simon Glass <sjg@chromium.org>, u-boot@lists.denx.de
Subject: Re: [PATCH 3/4] firmware: ti_sci: Remove inline keyword from functions
Date: Fri, 26 Aug 2022 14:49:26 -0400 [thread overview]
Message-ID: <20220826184926.GK7942@bill-the-cat> (raw)
In-Reply-To: <20220726012506.19368-4-afd@ti.com>
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
On Mon, Jul 25, 2022 at 08:25:05PM -0500, Andrew Davis wrote:
> The inline hint is not needed here, the compiler will do the right thing
> based on if we are compiling for speed or for code size. In this case the
> inline causes this function to be placed inside each callsite which is
> not the right thing to do for either speed nor size. There is no
> performance benefit to this due to the larger function size reducing
> cache locality, but there is a huge size penalty. Remove inline keyword.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2022-08-26 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 1:25 [PATCH 0/4] Reduce TI-SCI driver size to fix am65x_evm_r5 build Andrew Davis
2022-07-26 1:25 ` [PATCH 1/4] firmware: ti_sci: Reduce output on ti_sci_do_xfer error Andrew Davis
2022-08-26 18:49 ` Tom Rini
2022-07-26 1:25 ` [PATCH 2/4] firmware: ti_sci: Factor out message alloc failed message Andrew Davis
2022-08-26 18:49 ` Tom Rini
2022-07-26 1:25 ` [PATCH 3/4] firmware: ti_sci: Remove inline keyword from functions Andrew Davis
2022-08-26 18:49 ` Tom Rini [this message]
2022-07-26 1:25 ` [PATCH 4/4] firmware: ti_sci: Move ACK checking to ti_sci_do_xfer() function Andrew Davis
2022-08-26 18:49 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220826184926.GK7942@bill-the-cat \
--to=trini@konsulko.com \
--cc=afd@ti.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.