From: Dan Carpenter <dan.carpenter@oracle.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: guanjun@linux.alibaba.com, mst@redhat.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
xieyongji@bytedance.com, gautam.dawar@xilinx.com,
elic@nvidia.com
Subject: Re: [PATCH] vduse: prevent uninitialized memory accesses
Date: Sat, 27 Aug 2022 09:54:35 +0300 [thread overview]
Message-ID: <20220827065435.GL2030@kadam> (raw)
In-Reply-To: <20220826161605.559317-1-maxime.coquelin@redhat.com>
On Fri, Aug 26, 2022 at 06:16:05PM +0200, Maxime Coquelin wrote:
> If the VDUSE application provides a smaller config space
> than the driver expects, the driver may use uninitialized
> memory from the stack.
>
> This patch prevents it by initializing the buffer passed by
> the driver to store the config value.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
This sounds like it needs a Fixes tag?
regards,
dan carpenter
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, elic@nvidia.com,
guanjun@linux.alibaba.com, parav@nvidia.com,
gautam.dawar@xilinx.com, xieyongji@bytedance.com,
jasowang@redhat.com, mst@redhat.com
Subject: Re: [PATCH] vduse: prevent uninitialized memory accesses
Date: Sat, 27 Aug 2022 09:54:35 +0300 [thread overview]
Message-ID: <20220827065435.GL2030@kadam> (raw)
In-Reply-To: <20220826161605.559317-1-maxime.coquelin@redhat.com>
On Fri, Aug 26, 2022 at 06:16:05PM +0200, Maxime Coquelin wrote:
> If the VDUSE application provides a smaller config space
> than the driver expects, the driver may use uninitialized
> memory from the stack.
>
> This patch prevents it by initializing the buffer passed by
> the driver to store the config value.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
This sounds like it needs a Fixes tag?
regards,
dan carpenter
next prev parent reply other threads:[~2022-08-27 6:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 16:16 [PATCH] vduse: prevent uninitialized memory accesses Maxime Coquelin
2022-08-26 16:16 ` Maxime Coquelin
2022-08-27 6:54 ` Dan Carpenter [this message]
2022-08-27 6:54 ` Dan Carpenter
2022-08-29 7:23 ` Maxime Coquelin
2022-08-29 7:23 ` Maxime Coquelin
2022-08-29 0:44 ` Jason Wang
2022-08-29 0:44 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220827065435.GL2030@kadam \
--to=dan.carpenter@oracle.com \
--cc=elic@nvidia.com \
--cc=gautam.dawar@xilinx.com \
--cc=guanjun@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.