From: Sathvika Vasireddy <sv@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: peterz@infradead.org, npiggin@gmail.com,
linux-kernel@vger.kernel.org, aik@ozlabs.ru, mingo@redhat.com,
sv@linux.ibm.com, rostedt@goodmis.org, jpoimboe@redhat.com,
naveen.n.rao@linux.vnet.ibm.com, mbenes@suse.cz,
chenzhongjin@huawei.com
Subject: [PATCH v2 14/16] objtool: Add arch specific function arch_ftrace_match()
Date: Mon, 29 Aug 2022 11:22:21 +0530 [thread overview]
Message-ID: <20220829055223.24767-15-sv@linux.ibm.com> (raw)
In-Reply-To: <20220829055223.24767-1-sv@linux.ibm.com>
Add architecture specific function to look for
relocation records pointing to arch specific
symbols.
Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com>
---
tools/objtool/arch/x86/decode.c | 8 ++++++++
tools/objtool/check.c | 2 +-
tools/objtool/include/objtool/arch.h | 2 ++
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c
index c260006106be..025598b6b703 100644
--- a/tools/objtool/arch/x86/decode.c
+++ b/tools/objtool/arch/x86/decode.c
@@ -23,6 +23,14 @@
#include <objtool/builtin.h>
#include <arch/elf.h>
+bool arch_ftrace_match(char *name)
+{
+ if (!strcmp(name, "__fentry__"))
+ return true;
+
+ return false;
+}
+
static int is_x86_64(const struct elf *elf)
{
switch (elf->ehdr.e_machine) {
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index f1d055467926..01ff7504f18d 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -2294,7 +2294,7 @@ static int classify_symbols(struct objtool_file *file)
if (arch_is_rethunk(func))
func->return_thunk = true;
- if (!strcmp(func->name, "__fentry__"))
+ if (arch_ftrace_match(func->name))
func->fentry = true;
if (is_profiling_func(func->name))
diff --git a/tools/objtool/include/objtool/arch.h b/tools/objtool/include/objtool/arch.h
index beb2f3aa94ff..2ba4b9897285 100644
--- a/tools/objtool/include/objtool/arch.h
+++ b/tools/objtool/include/objtool/arch.h
@@ -69,6 +69,8 @@ struct stack_op {
struct instruction;
+bool arch_ftrace_match(char *name);
+
void arch_initial_func_cfi_state(struct cfi_init_state *state);
int arch_decode_instruction(struct objtool_file *file, const struct section *sec,
--
2.31.1
WARNING: multiple messages have this Message-ID (diff)
From: Sathvika Vasireddy <sv@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: jpoimboe@redhat.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, aik@ozlabs.ru, mpe@ellerman.id.au,
mingo@redhat.com, christophe.leroy@csgroup.eu,
rostedt@goodmis.org, mbenes@suse.cz, npiggin@gmail.com,
chenzhongjin@huawei.com, naveen.n.rao@linux.vnet.ibm.com,
sv@linux.ibm.com
Subject: [PATCH v2 14/16] objtool: Add arch specific function arch_ftrace_match()
Date: Mon, 29 Aug 2022 11:22:21 +0530 [thread overview]
Message-ID: <20220829055223.24767-15-sv@linux.ibm.com> (raw)
In-Reply-To: <20220829055223.24767-1-sv@linux.ibm.com>
Add architecture specific function to look for
relocation records pointing to arch specific
symbols.
Suggested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Sathvika Vasireddy <sv@linux.ibm.com>
---
tools/objtool/arch/x86/decode.c | 8 ++++++++
tools/objtool/check.c | 2 +-
tools/objtool/include/objtool/arch.h | 2 ++
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c
index c260006106be..025598b6b703 100644
--- a/tools/objtool/arch/x86/decode.c
+++ b/tools/objtool/arch/x86/decode.c
@@ -23,6 +23,14 @@
#include <objtool/builtin.h>
#include <arch/elf.h>
+bool arch_ftrace_match(char *name)
+{
+ if (!strcmp(name, "__fentry__"))
+ return true;
+
+ return false;
+}
+
static int is_x86_64(const struct elf *elf)
{
switch (elf->ehdr.e_machine) {
diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index f1d055467926..01ff7504f18d 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -2294,7 +2294,7 @@ static int classify_symbols(struct objtool_file *file)
if (arch_is_rethunk(func))
func->return_thunk = true;
- if (!strcmp(func->name, "__fentry__"))
+ if (arch_ftrace_match(func->name))
func->fentry = true;
if (is_profiling_func(func->name))
diff --git a/tools/objtool/include/objtool/arch.h b/tools/objtool/include/objtool/arch.h
index beb2f3aa94ff..2ba4b9897285 100644
--- a/tools/objtool/include/objtool/arch.h
+++ b/tools/objtool/include/objtool/arch.h
@@ -69,6 +69,8 @@ struct stack_op {
struct instruction;
+bool arch_ftrace_match(char *name);
+
void arch_initial_func_cfi_state(struct cfi_init_state *state);
int arch_decode_instruction(struct objtool_file *file, const struct section *sec,
--
2.31.1
next prev parent reply other threads:[~2022-08-29 6:02 UTC|newest]
Thread overview: 128+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-29 5:52 [PATCH v2 00/16] objtool: Enable and implement --mcount option on powerpc Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-08-29 5:52 ` [PATCH v2 01/16] powerpc: Replace unreachable() with it's builtin variant in __WARN_FLAGS() Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-08-30 6:15 ` Christophe Leroy
2022-08-30 6:15 ` Christophe Leroy
2022-09-05 10:18 ` Naveen N. Rao
2022-09-05 10:18 ` Naveen N. Rao
2022-08-29 5:52 ` [PATCH v2 02/16] powerpc: override __ALIGN() and __ALIGN_STR() macros Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-08-29 13:26 ` Christophe Leroy
2022-08-29 13:26 ` Christophe Leroy
2022-08-29 14:39 ` Sathvika Vasireddy
2022-08-29 14:39 ` Sathvika Vasireddy
2022-08-31 3:24 ` Nicholas Piggin
2022-08-31 3:24 ` Nicholas Piggin
2022-08-31 7:22 ` Michael Ellerman
2022-08-31 7:22 ` Michael Ellerman
2022-09-05 11:03 ` Peter Zijlstra
2022-09-05 11:03 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 03/16] powerpc: Fix objtool unannotated intra-function call warnings Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-08-30 6:16 ` Christophe Leroy
2022-08-30 6:16 ` Christophe Leroy
2022-08-30 12:42 ` Christophe Leroy
2022-08-30 12:42 ` Christophe Leroy
2022-09-05 11:02 ` Peter Zijlstra
2022-09-05 11:02 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 04/16] powerpc: Curb objtool unannotated intra-function warnings Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-08-30 6:26 ` Christophe Leroy
2022-08-30 6:26 ` Christophe Leroy
2022-08-29 5:52 ` [PATCH v2 05/16] powerpc: Skip objtool from running on drivers/crypto/vmx/aesp8-ppc.o Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-08-30 6:26 ` Christophe Leroy
2022-08-30 6:26 ` Christophe Leroy
2022-09-01 19:17 ` Peter Zijlstra
2022-09-01 19:17 ` Peter Zijlstra
2022-09-05 10:47 ` Naveen N. Rao
2022-09-05 10:47 ` Naveen N. Rao
2022-08-29 5:52 ` [PATCH v2 06/16] powerpc: Fix objtool unannotated intra-function call warnings on PPC32 Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-08-29 5:52 ` [PATCH v2 07/16] powerpc: Skip objtool from running on VDSO files Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-08-30 6:27 ` Christophe Leroy
2022-08-30 6:27 ` Christophe Leroy
2022-09-01 19:19 ` Peter Zijlstra
2022-09-01 19:19 ` Peter Zijlstra
2022-09-02 7:40 ` Michael Ellerman
2022-09-02 7:40 ` Michael Ellerman
2022-08-29 5:52 ` [PATCH v2 08/16] objtool: Fix SEGFAULT Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-09-01 19:20 ` Peter Zijlstra
2022-09-01 19:20 ` Peter Zijlstra
2022-09-02 8:06 ` Christophe Leroy
2022-09-02 8:06 ` Christophe Leroy
2022-09-02 8:42 ` Peter Zijlstra
2022-09-02 8:42 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 09/16] objtool: Use target file endianness instead of a compiled constant Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-09-01 19:22 ` Peter Zijlstra
2022-09-01 19:22 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 10/16] objtool: Use target file class size " Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-09-01 19:23 ` Peter Zijlstra
2022-09-01 19:23 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 11/16] objtool: Add --mnop as an option to --mcount Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-08-30 6:28 ` Christophe Leroy
2022-08-30 6:28 ` Christophe Leroy
2022-09-01 19:25 ` Peter Zijlstra
2022-09-01 19:25 ` Peter Zijlstra
2022-09-05 10:55 ` Naveen N. Rao
2022-09-05 10:55 ` Naveen N. Rao
2022-08-29 5:52 ` [PATCH v2 12/16] objtool: Read special sections with alts only when specific options are selected Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-08-30 6:31 ` Christophe Leroy
2022-08-30 6:31 ` Christophe Leroy
2022-08-29 5:52 ` [PATCH v2 13/16] objtool: Use macros to define arch specific reloc types Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-08-30 6:33 ` Christophe Leroy
2022-08-30 6:33 ` Christophe Leroy
2022-09-01 19:28 ` Peter Zijlstra
2022-09-01 19:28 ` Peter Zijlstra
2022-08-29 5:52 ` Sathvika Vasireddy [this message]
2022-08-29 5:52 ` [PATCH v2 14/16] objtool: Add arch specific function arch_ftrace_match() Sathvika Vasireddy
2022-08-30 6:36 ` Christophe Leroy
2022-08-30 6:36 ` Christophe Leroy
2022-08-29 5:52 ` [PATCH v2 15/16] objtool/powerpc: Enable objtool to be built on ppc Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-08-30 6:41 ` Christophe Leroy
2022-08-30 6:41 ` Christophe Leroy
2022-09-05 10:37 ` Naveen N. Rao
2022-09-05 10:37 ` Naveen N. Rao
2023-02-04 8:19 ` Randy Dunlap
2023-02-04 8:19 ` Randy Dunlap
2023-02-04 8:21 ` Randy Dunlap
2023-02-04 8:21 ` Randy Dunlap
2023-02-04 8:30 ` Randy Dunlap
2023-02-04 8:30 ` Randy Dunlap
2023-02-04 11:55 ` Christophe Leroy
2023-02-04 11:55 ` Christophe Leroy
2023-02-04 13:10 ` Christophe Leroy
2023-02-04 13:10 ` Christophe Leroy
2023-02-04 15:47 ` Josh Poimboeuf
2023-02-04 15:47 ` Josh Poimboeuf
2022-09-01 9:32 ` Christophe Leroy
2022-09-01 9:32 ` Christophe Leroy
2022-09-01 15:11 ` Segher Boessenkool
2022-09-01 15:11 ` Segher Boessenkool
2022-09-01 16:38 ` Christophe Leroy
2022-09-01 16:38 ` Christophe Leroy
2022-09-01 19:01 ` Peter Zijlstra
2022-09-01 19:01 ` Peter Zijlstra
2022-08-29 5:52 ` [PATCH v2 16/16] objtool/powerpc: Add --mcount specific implementation Sathvika Vasireddy
2022-08-29 5:52 ` Sathvika Vasireddy
2022-08-30 6:44 ` Christophe Leroy
2022-08-30 6:44 ` Christophe Leroy
2022-08-31 12:50 ` Christophe Leroy
2022-08-31 12:50 ` Christophe Leroy
2022-08-31 17:51 ` Segher Boessenkool
2022-08-31 17:51 ` Segher Boessenkool
2022-09-05 10:45 ` Naveen N. Rao
2022-09-05 10:45 ` Naveen N. Rao
2022-09-05 20:43 ` Segher Boessenkool
2022-09-05 20:43 ` Segher Boessenkool
2022-09-06 6:22 ` Christophe Leroy
2022-09-06 6:22 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829055223.24767-15-sv@linux.ibm.com \
--to=sv@linux.ibm.com \
--cc=aik@ozlabs.ru \
--cc=chenzhongjin@huawei.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mbenes@suse.cz \
--cc=mingo@redhat.com \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.