All of lore.kernel.org
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: davem@davemloft.net, Rob Herring <robh+dt@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com,
	Florian Fainelli <f.fainelli@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Luka Perkov <luka.perkov@sartura.hr>,
	Robert Marko <robert.marko@sartura.hr>
Subject: Re: [PATCH net-next v3 1/5] net: ipqess: introduce the Qualcomm IPQESS driver
Date: Mon, 29 Aug 2022 15:48:26 +0200	[thread overview]
Message-ID: <20220829154826.270b693e@pc-10.home> (raw)
In-Reply-To: <YwpwVd+qgM+RR8nh@lunn.ch>

Hello Andrew, and thanks for the review

On Sat, 27 Aug 2022 21:28:21 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> > +static void ipqess_get_strings(struct net_device *netdev, u32
> > stringset,
> > +			       u8 *data)
> > +{
> > +	u8 *p = data;
> > +	u32 i;
> > +
> > +	switch (stringset) {
> > +	case ETH_SS_STATS:
> > +		for (i = 0; i < ARRAY_SIZE(ipqess_stats); i++) {
> > +			memcpy(p, ipqess_stats[i].string,
> > +			       min((size_t)ETH_GSTRING_LEN,
> > +				   strlen(ipqess_stats[i].string)
> > + 1));  
> 
> That looks pretty similar to strlcpy().

Indeed... and after digging I even found ethtool_sprintf() which seems
to fit even better :)

> > +static int ipqess_get_settings(struct net_device *netdev,
> > +			       struct ethtool_link_ksettings *cmd)
> >  
> 
> It would be traditional to have the k in the name.
> 
> > +{
> > +	struct ipqess *ess = netdev_priv(netdev);
> > +
> > +	return phylink_ethtool_ksettings_get(ess->phylink, cmd);
> > +}
> > +
> > +static int ipqess_set_settings(struct net_device *netdev,
> > +			       const struct ethtool_link_ksettings
> > *cmd) +{  
> 
> Here too.

Agreed, I'll address that. Thanks !

Maxime
 
>      Andrew


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: davem@davemloft.net, Rob Herring <robh+dt@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, thomas.petazzoni@bootlin.com,
	Florian Fainelli <f.fainelli@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Luka Perkov <luka.perkov@sartura.hr>,
	Robert Marko <robert.marko@sartura.hr>
Subject: Re: [PATCH net-next v3 1/5] net: ipqess: introduce the Qualcomm IPQESS driver
Date: Mon, 29 Aug 2022 15:48:26 +0200	[thread overview]
Message-ID: <20220829154826.270b693e@pc-10.home> (raw)
In-Reply-To: <YwpwVd+qgM+RR8nh@lunn.ch>

Hello Andrew, and thanks for the review

On Sat, 27 Aug 2022 21:28:21 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> > +static void ipqess_get_strings(struct net_device *netdev, u32
> > stringset,
> > +			       u8 *data)
> > +{
> > +	u8 *p = data;
> > +	u32 i;
> > +
> > +	switch (stringset) {
> > +	case ETH_SS_STATS:
> > +		for (i = 0; i < ARRAY_SIZE(ipqess_stats); i++) {
> > +			memcpy(p, ipqess_stats[i].string,
> > +			       min((size_t)ETH_GSTRING_LEN,
> > +				   strlen(ipqess_stats[i].string)
> > + 1));  
> 
> That looks pretty similar to strlcpy().

Indeed... and after digging I even found ethtool_sprintf() which seems
to fit even better :)

> > +static int ipqess_get_settings(struct net_device *netdev,
> > +			       struct ethtool_link_ksettings *cmd)
> >  
> 
> It would be traditional to have the k in the name.
> 
> > +{
> > +	struct ipqess *ess = netdev_priv(netdev);
> > +
> > +	return phylink_ethtool_ksettings_get(ess->phylink, cmd);
> > +}
> > +
> > +static int ipqess_set_settings(struct net_device *netdev,
> > +			       const struct ethtool_link_ksettings
> > *cmd) +{  
> 
> Here too.

Agreed, I'll address that. Thanks !

Maxime
 
>      Andrew


  reply	other threads:[~2022-08-29 14:04 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-26 15:46 [PATCH net-next v3 0/5] net: ipqess: introduce Qualcomm IPQESS driver Maxime Chevallier
2022-08-26 15:46 ` Maxime Chevallier
2022-08-26 15:46 ` [PATCH net-next v3 1/5] net: ipqess: introduce the " Maxime Chevallier
2022-08-26 15:46   ` Maxime Chevallier
2022-08-26 18:41   ` kernel test robot
2022-08-26 18:41     ` kernel test robot
2022-08-26 19:32   ` kernel test robot
2022-08-26 19:32     ` kernel test robot
2022-08-27 19:28   ` Andrew Lunn
2022-08-27 19:28     ` Andrew Lunn
2022-08-29 13:48     ` Maxime Chevallier [this message]
2022-08-29 13:48       ` Maxime Chevallier
2022-08-26 15:46 ` [PATCH net-next v3 2/5] net: dsa: add out-of-band tagging protocol Maxime Chevallier
2022-08-26 15:46   ` Maxime Chevallier
2022-08-27 18:48   ` Andrew Lunn
2022-08-27 18:48     ` Andrew Lunn
2022-08-27 18:54   ` Andrew Lunn
2022-08-27 18:54     ` Andrew Lunn
2022-08-26 15:46 ` [PATCH net-next v3 3/5] net: ipqess: Add out-of-band DSA tagging support Maxime Chevallier
2022-08-26 15:46   ` Maxime Chevallier
2022-08-27 19:12   ` Andrew Lunn
2022-08-27 19:12     ` Andrew Lunn
2022-08-26 15:46 ` [PATCH net-next v3 4/5] net: dt-bindings: Introduce the Qualcomm IPQESS Ethernet controller Maxime Chevallier
2022-08-26 15:46   ` Maxime Chevallier
2022-08-28 14:21   ` Rob Herring
2022-08-28 14:21     ` Rob Herring
2022-08-26 15:46 ` [PATCH net-next v3 5/5] ARM: dts: qcom: ipq4019: Add description for the " Maxime Chevallier
2022-08-26 15:46   ` Maxime Chevallier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220829154826.270b693e@pc-10.home \
    --to=maxime.chevallier@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=luka.perkov@sartura.hr \
    --cc=netdev@vger.kernel.org \
    --cc=robert.marko@sartura.hr \
    --cc=robh+dt@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.