From: FUKAUMI Naoki <naoki@radxa.com>
To: jagan@amarulasolutions.com
Cc: abbaraju.manojsai@amarulasolutions.com,
devicetree@vger.kernel.org, heiko@sntech.de,
krzysztof.kozlowski+dt@linaro.org,
linux-amarula@amarulasolutions.com,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
stephen@radxa.com
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3399: Radxa ROCK 4C+
Date: Mon, 29 Aug 2022 20:17:52 +0000 [thread overview]
Message-ID: <20220829201752.518374-1-naoki@radxa.com> (raw)
In-Reply-To: <20220824080903.3696847-2-jagan@amarulasolutions.com>
Hello,
thank you very much for your work!
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-4c-plus.dtb
this is not an objection, just a note for me, currently our(Radxa)
u-boot try to load "rk3399-rock-pi-4c-plus.dtb".
> +#include "rk3399-opp.dtsi"
ROCK 4C+ has RK3399-T. it needs different opp table.
> + aliases {
> + mmc0 = &sdmmc;
please add
mmc1 = &sdhci;
as like as other ROCK (Pi) 4 series.
> +&hdmi_sound {
> + status = "okay";
> +};
please add
&i2s2 {
status = "okay";
};
too.
> +&sdmmc {
> + bus-width = <4>;
> + cap-mmc-highspeed;
> + cap-sd-highspeed;
> + card-detect-delay = <800>;
> + disable-wp;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdmmc_clk &sdmmc_cd &sdmmc_cmd &sdmmc_bus4>;
> + vqmmc-supply = <&vccio_sd>;
> + status = "okay";
> +};
does card detect work for you? it doesn't work for me. I think it
needs
cd-gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_LOW>;
instead of "&sdmmc_cd".
Best regards,
--
FUKAUMI Naoki
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: FUKAUMI Naoki <naoki@radxa.com>
To: jagan@amarulasolutions.com
Cc: abbaraju.manojsai@amarulasolutions.com,
devicetree@vger.kernel.org, heiko@sntech.de,
krzysztof.kozlowski+dt@linaro.org,
linux-amarula@amarulasolutions.com,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
stephen@radxa.com
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3399: Radxa ROCK 4C+
Date: Mon, 29 Aug 2022 20:17:52 +0000 [thread overview]
Message-ID: <20220829201752.518374-1-naoki@radxa.com> (raw)
In-Reply-To: <20220824080903.3696847-2-jagan@amarulasolutions.com>
Hello,
thank you very much for your work!
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-4c-plus.dtb
this is not an objection, just a note for me, currently our(Radxa)
u-boot try to load "rk3399-rock-pi-4c-plus.dtb".
> +#include "rk3399-opp.dtsi"
ROCK 4C+ has RK3399-T. it needs different opp table.
> + aliases {
> + mmc0 = &sdmmc;
please add
mmc1 = &sdhci;
as like as other ROCK (Pi) 4 series.
> +&hdmi_sound {
> + status = "okay";
> +};
please add
&i2s2 {
status = "okay";
};
too.
> +&sdmmc {
> + bus-width = <4>;
> + cap-mmc-highspeed;
> + cap-sd-highspeed;
> + card-detect-delay = <800>;
> + disable-wp;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdmmc_clk &sdmmc_cd &sdmmc_cmd &sdmmc_bus4>;
> + vqmmc-supply = <&vccio_sd>;
> + status = "okay";
> +};
does card detect work for you? it doesn't work for me. I think it
needs
cd-gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_LOW>;
instead of "&sdmmc_cd".
Best regards,
--
FUKAUMI Naoki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: FUKAUMI Naoki <naoki@radxa.com>
To: jagan@amarulasolutions.com
Cc: abbaraju.manojsai@amarulasolutions.com,
devicetree@vger.kernel.org, heiko@sntech.de,
krzysztof.kozlowski+dt@linaro.org,
linux-amarula@amarulasolutions.com,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
stephen@radxa.com
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rk3399: Radxa ROCK 4C+
Date: Mon, 29 Aug 2022 20:17:52 +0000 [thread overview]
Message-ID: <20220829201752.518374-1-naoki@radxa.com> (raw)
In-Reply-To: <20220824080903.3696847-2-jagan@amarulasolutions.com>
Hello,
thank you very much for your work!
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-rock-4c-plus.dtb
this is not an objection, just a note for me, currently our(Radxa)
u-boot try to load "rk3399-rock-pi-4c-plus.dtb".
> +#include "rk3399-opp.dtsi"
ROCK 4C+ has RK3399-T. it needs different opp table.
> + aliases {
> + mmc0 = &sdmmc;
please add
mmc1 = &sdhci;
as like as other ROCK (Pi) 4 series.
> +&hdmi_sound {
> + status = "okay";
> +};
please add
&i2s2 {
status = "okay";
};
too.
> +&sdmmc {
> + bus-width = <4>;
> + cap-mmc-highspeed;
> + cap-sd-highspeed;
> + card-detect-delay = <800>;
> + disable-wp;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sdmmc_clk &sdmmc_cd &sdmmc_cmd &sdmmc_bus4>;
> + vqmmc-supply = <&vccio_sd>;
> + status = "okay";
> +};
does card detect work for you? it doesn't work for me. I think it
needs
cd-gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_LOW>;
instead of "&sdmmc_cd".
Best regards,
--
FUKAUMI Naoki
next prev parent reply other threads:[~2022-08-29 20:19 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 8:09 [PATCH 1/2] dt-bindings: arm: rockchip: Document Radxa ROCK 4C+ Jagan Teki
2022-08-24 8:09 ` Jagan Teki
2022-08-24 8:09 ` Jagan Teki
2022-08-24 8:09 ` [PATCH 2/2] arm64: dts: rockchip: rk3399: " Jagan Teki
2022-08-24 8:09 ` Jagan Teki
2022-08-24 8:09 ` Jagan Teki
2022-08-24 12:46 ` Krzysztof Kozlowski
2022-08-24 12:46 ` Krzysztof Kozlowski
2022-08-24 12:46 ` Krzysztof Kozlowski
2022-08-29 20:17 ` FUKAUMI Naoki [this message]
2022-08-29 20:17 ` FUKAUMI Naoki
2022-08-29 20:17 ` FUKAUMI Naoki
2022-08-29 20:28 ` Jagan Teki
2022-08-29 20:28 ` Jagan Teki
2022-08-29 20:28 ` Jagan Teki
2022-08-29 21:01 ` FUKAUMI Naoki
2022-08-29 21:01 ` FUKAUMI Naoki
2022-08-29 21:01 ` FUKAUMI Naoki
2022-08-30 5:33 ` Jagan Teki
2022-08-30 5:33 ` Jagan Teki
2022-08-30 5:33 ` Jagan Teki
2022-08-30 5:43 ` FUKAUMI Naoki
2022-08-30 5:43 ` FUKAUMI Naoki
2022-08-30 5:43 ` FUKAUMI Naoki
2022-08-30 6:19 ` Jagan Teki
2022-08-30 6:19 ` Jagan Teki
2022-08-30 6:19 ` Jagan Teki
2022-08-30 4:56 ` Jagan Teki
2022-08-30 4:56 ` Jagan Teki
2022-08-30 4:56 ` Jagan Teki
2022-08-30 5:35 ` FUKAUMI Naoki
2022-08-30 5:35 ` FUKAUMI Naoki
2022-08-30 5:35 ` FUKAUMI Naoki
2022-08-24 12:42 ` [PATCH 1/2] dt-bindings: arm: rockchip: Document " Krzysztof Kozlowski
2022-08-24 12:42 ` Krzysztof Kozlowski
2022-08-24 12:42 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829201752.518374-1-naoki@radxa.com \
--to=naoki@radxa.com \
--cc=abbaraju.manojsai@amarulasolutions.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@amarulasolutions.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=stephen@radxa.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.