From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gavin Li <gavinl@nvidia.com>
Cc: stephen@networkplumber.org, davem@davemloft.net,
jesse.brandeburg@intel.com, alexander.h.duyck@intel.com,
kuba@kernel.org, sridhar.samudrala@intel.com,
jasowang@redhat.com, loseweigh@gmail.com, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org, gavi@nvidia.com,
parav@nvidia.com, Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Si-Wei Liu <si-wei.liu@oracle.com>
Subject: [virtio-dev] Re: [PATCH RESEND v4 1/2] virtio-net: introduce and use helper function for guest gso support checks
Date: Wed, 31 Aug 2022 09:08:10 -0400 [thread overview]
Message-ID: <20220831090721-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220831130541.81217-2-gavinl@nvidia.com>
On Wed, Aug 31, 2022 at 04:05:40PM +0300, Gavin Li wrote:
> Probe routine is already several hundred lines.
> Use helper function for guest gso support check.
>
> Signed-off-by: Gavin Li <gavinl@nvidia.com>
> Reviewed-by: Gavi Teitz <gavi@nvidia.com>
> Reviewed-by: Parav Pandit <parav@nvidia.com>
> Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com>
> ---
> changelog:
> v1->v2
> - Add new patch
> ---
> drivers/net/virtio_net.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 9cce7dec7366..e1904877d461 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -3682,6 +3682,14 @@ static int virtnet_validate(struct virtio_device *vdev)
> return 0;
> }
>
> +static bool virtnet_check_guest_gso(const struct virtnet_info *vi)
> +{
> + return (virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO4) ||
> + virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO6) ||
> + virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_ECN) ||
> + virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_UFO));
> +}
> +
fine but can we please drop the outer ()?
they are necessary with if but not with return.
> static int virtnet_probe(struct virtio_device *vdev)
> {
> int i, err = -ENOMEM;
> @@ -3777,10 +3785,7 @@ static int virtnet_probe(struct virtio_device *vdev)
> spin_lock_init(&vi->refill_lock);
>
> /* If we can receive ANY GSO packets, we must allocate large ones. */
> - if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) ||
> - virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO6) ||
> - virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_ECN) ||
> - virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_UFO))
> + if (virtnet_check_guest_gso(vi))
> vi->big_packets = true;
>
> if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF))
> --
> 2.31.1
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gavin Li <gavinl@nvidia.com>
Cc: alexander.h.duyck@intel.com, virtio-dev@lists.oasis-open.org,
sridhar.samudrala@intel.com, jesse.brandeburg@intel.com,
gavi@nvidia.com, virtualization@lists.linux-foundation.org,
stephen@networkplumber.org, loseweigh@gmail.com,
netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net
Subject: Re: [PATCH RESEND v4 1/2] virtio-net: introduce and use helper function for guest gso support checks
Date: Wed, 31 Aug 2022 09:08:10 -0400 [thread overview]
Message-ID: <20220831090721-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220831130541.81217-2-gavinl@nvidia.com>
On Wed, Aug 31, 2022 at 04:05:40PM +0300, Gavin Li wrote:
> Probe routine is already several hundred lines.
> Use helper function for guest gso support check.
>
> Signed-off-by: Gavin Li <gavinl@nvidia.com>
> Reviewed-by: Gavi Teitz <gavi@nvidia.com>
> Reviewed-by: Parav Pandit <parav@nvidia.com>
> Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com>
> ---
> changelog:
> v1->v2
> - Add new patch
> ---
> drivers/net/virtio_net.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 9cce7dec7366..e1904877d461 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -3682,6 +3682,14 @@ static int virtnet_validate(struct virtio_device *vdev)
> return 0;
> }
>
> +static bool virtnet_check_guest_gso(const struct virtnet_info *vi)
> +{
> + return (virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO4) ||
> + virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO6) ||
> + virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_ECN) ||
> + virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_UFO));
> +}
> +
fine but can we please drop the outer ()?
they are necessary with if but not with return.
> static int virtnet_probe(struct virtio_device *vdev)
> {
> int i, err = -ENOMEM;
> @@ -3777,10 +3785,7 @@ static int virtnet_probe(struct virtio_device *vdev)
> spin_lock_init(&vi->refill_lock);
>
> /* If we can receive ANY GSO packets, we must allocate large ones. */
> - if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) ||
> - virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO6) ||
> - virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_ECN) ||
> - virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_UFO))
> + if (virtnet_check_guest_gso(vi))
> vi->big_packets = true;
>
> if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF))
> --
> 2.31.1
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gavin Li <gavinl@nvidia.com>
Cc: stephen@networkplumber.org, davem@davemloft.net,
jesse.brandeburg@intel.com, alexander.h.duyck@intel.com,
kuba@kernel.org, sridhar.samudrala@intel.com,
jasowang@redhat.com, loseweigh@gmail.com, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org,
virtio-dev@lists.oasis-open.org, gavi@nvidia.com,
parav@nvidia.com, Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
Si-Wei Liu <si-wei.liu@oracle.com>
Subject: Re: [PATCH RESEND v4 1/2] virtio-net: introduce and use helper function for guest gso support checks
Date: Wed, 31 Aug 2022 09:08:10 -0400 [thread overview]
Message-ID: <20220831090721-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220831130541.81217-2-gavinl@nvidia.com>
On Wed, Aug 31, 2022 at 04:05:40PM +0300, Gavin Li wrote:
> Probe routine is already several hundred lines.
> Use helper function for guest gso support check.
>
> Signed-off-by: Gavin Li <gavinl@nvidia.com>
> Reviewed-by: Gavi Teitz <gavi@nvidia.com>
> Reviewed-by: Parav Pandit <parav@nvidia.com>
> Reviewed-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> Reviewed-by: Si-Wei Liu <si-wei.liu@oracle.com>
> ---
> changelog:
> v1->v2
> - Add new patch
> ---
> drivers/net/virtio_net.c | 13 +++++++++----
> 1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 9cce7dec7366..e1904877d461 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -3682,6 +3682,14 @@ static int virtnet_validate(struct virtio_device *vdev)
> return 0;
> }
>
> +static bool virtnet_check_guest_gso(const struct virtnet_info *vi)
> +{
> + return (virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO4) ||
> + virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_TSO6) ||
> + virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_ECN) ||
> + virtio_has_feature(vi->vdev, VIRTIO_NET_F_GUEST_UFO));
> +}
> +
fine but can we please drop the outer ()?
they are necessary with if but not with return.
> static int virtnet_probe(struct virtio_device *vdev)
> {
> int i, err = -ENOMEM;
> @@ -3777,10 +3785,7 @@ static int virtnet_probe(struct virtio_device *vdev)
> spin_lock_init(&vi->refill_lock);
>
> /* If we can receive ANY GSO packets, we must allocate large ones. */
> - if (virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO4) ||
> - virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_TSO6) ||
> - virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_ECN) ||
> - virtio_has_feature(vdev, VIRTIO_NET_F_GUEST_UFO))
> + if (virtnet_check_guest_gso(vi))
> vi->big_packets = true;
>
> if (virtio_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF))
> --
> 2.31.1
next prev parent reply other threads:[~2022-08-31 13:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 13:05 [virtio-dev] [PATCH RESEND v4 0/2] Improve virtio performance for 9k mtu Gavin Li
2022-08-31 13:05 ` Gavin Li
2022-08-31 13:05 ` [virtio-dev] [PATCH RESEND v4 1/2] virtio-net: introduce and use helper function for guest gso support checks Gavin Li
2022-08-31 13:05 ` Gavin Li
2022-08-31 13:08 ` Michael S. Tsirkin [this message]
2022-08-31 13:08 ` Michael S. Tsirkin
2022-08-31 13:08 ` Michael S. Tsirkin
2022-08-31 13:10 ` [virtio-dev] " Gavin Li
2022-08-31 13:10 ` Gavin Li
2022-08-31 13:05 ` [virtio-dev] [PATCH RESEND v4 2/2] virtio-net: use mtu size as buffer length for big packets Gavin Li
2022-08-31 13:05 ` Gavin Li
2022-08-31 13:11 ` [virtio-dev] " Michael S. Tsirkin
2022-08-31 13:11 ` Michael S. Tsirkin
2022-08-31 13:11 ` Michael S. Tsirkin
2022-08-31 13:14 ` [virtio-dev] " Gavin Li
2022-08-31 13:14 ` Gavin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831090721-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=gavi@nvidia.com \
--cc=gavinl@nvidia.com \
--cc=jasowang@redhat.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=loseweigh@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=si-wei.liu@oracle.com \
--cc=sridhar.samudrala@intel.com \
--cc=stephen@networkplumber.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.