From: Rob Herring <robh@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Shawn Guo" <shawnguo@kernel.org>, "Li Yang" <leoyang.li@nxp.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Frank Rowand" <frowand.list@gmail.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
"Ahmad Fatoum" <a.fatoum@pengutronix.de>
Subject: Re: [PATCH v1 08/14] dt-bindings: mtd: relax the nvmem compatible string
Date: Wed, 31 Aug 2022 16:48:09 -0500 [thread overview]
Message-ID: <20220831214809.GA282739-robh@kernel.org> (raw)
In-Reply-To: <20220825214423.903672-9-michael@walle.cc>
On Thu, Aug 25, 2022 at 11:44:17PM +0200, Michael Walle wrote:
> The "user-otp" and "factory-otp" compatible string just depicts a
> generic NVMEM device. But an actual device tree node might as well
> contain a more specific compatible string. Make it possible to add
> more specific binding elsewere and just match part of the compatibles
> here.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> Documentation/devicetree/bindings/mtd/mtd.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
In hindsight it looks like we are mixing 2 different purposes of 'which
instance is this' and 'what is this'. 'compatible' is supposed to be the
latter.
Maybe there's a better way to handle user/factory? There's a similar
need with partitions for A/B or factory/update.
Rob
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Shawn Guo" <shawnguo@kernel.org>, "Li Yang" <leoyang.li@nxp.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Frank Rowand" <frowand.list@gmail.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
"Ahmad Fatoum" <a.fatoum@pengutronix.de>
Subject: Re: [PATCH v1 08/14] dt-bindings: mtd: relax the nvmem compatible string
Date: Wed, 31 Aug 2022 16:48:09 -0500 [thread overview]
Message-ID: <20220831214809.GA282739-robh@kernel.org> (raw)
In-Reply-To: <20220825214423.903672-9-michael@walle.cc>
On Thu, Aug 25, 2022 at 11:44:17PM +0200, Michael Walle wrote:
> The "user-otp" and "factory-otp" compatible string just depicts a
> generic NVMEM device. But an actual device tree node might as well
> contain a more specific compatible string. Make it possible to add
> more specific binding elsewere and just match part of the compatibles
> here.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> Documentation/devicetree/bindings/mtd/mtd.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
In hindsight it looks like we are mixing 2 different purposes of 'which
instance is this' and 'what is this'. 'compatible' is supposed to be the
latter.
Maybe there's a better way to handle user/factory? There's a similar
need with partitions for A/B or factory/update.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Michael Walle <michael@walle.cc>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Shawn Guo" <shawnguo@kernel.org>, "Li Yang" <leoyang.li@nxp.com>,
"Rafał Miłecki" <rafal@milecki.pl>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Frank Rowand" <frowand.list@gmail.com>,
linux-mtd@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
"Ahmad Fatoum" <a.fatoum@pengutronix.de>
Subject: Re: [PATCH v1 08/14] dt-bindings: mtd: relax the nvmem compatible string
Date: Wed, 31 Aug 2022 16:48:09 -0500 [thread overview]
Message-ID: <20220831214809.GA282739-robh@kernel.org> (raw)
In-Reply-To: <20220825214423.903672-9-michael@walle.cc>
On Thu, Aug 25, 2022 at 11:44:17PM +0200, Michael Walle wrote:
> The "user-otp" and "factory-otp" compatible string just depicts a
> generic NVMEM device. But an actual device tree node might as well
> contain a more specific compatible string. Make it possible to add
> more specific binding elsewere and just match part of the compatibles
> here.
>
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
> Documentation/devicetree/bindings/mtd/mtd.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
In hindsight it looks like we are mixing 2 different purposes of 'which
instance is this' and 'what is this'. 'compatible' is supposed to be the
latter.
Maybe there's a better way to handle user/factory? There's a similar
need with partitions for A/B or factory/update.
Rob
next prev parent reply other threads:[~2022-08-31 21:48 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 21:44 [PATCH v1 00/14] nvmem: core: introduce NVMEM layouts Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` [PATCH v1 01/14] net: add helper eth_addr_add() Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-09-01 16:26 ` Michael Walle
2022-09-01 16:26 ` Michael Walle
2022-09-01 16:26 ` Michael Walle
2022-09-01 16:31 ` Andrew Lunn
2022-09-01 16:31 ` Andrew Lunn
2022-09-01 16:31 ` Andrew Lunn
2022-09-01 19:54 ` Jakub Kicinski
2022-09-01 19:54 ` Jakub Kicinski
2022-09-01 19:54 ` Jakub Kicinski
2022-08-25 21:44 ` [PATCH v1 02/14] of: base: add of_parse_phandle_with_optional_args() Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` [PATCH v1 03/14] nvmem: core: add an index parameter to the cell Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` [PATCH v1 04/14] nvmem: core: drop the removal of the cells in nvmem_add_cells() Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` [PATCH v1 05/14] nvmem: core: add nvmem_add_one_cell() Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` [PATCH v1 06/14] nvmem: core: introduce NVMEM layouts Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-26 8:16 ` Michael Walle
2022-08-26 8:16 ` Michael Walle
2022-08-26 8:16 ` Michael Walle
2022-08-28 14:06 ` Rafał Miłecki
2022-08-28 14:06 ` Rafał Miłecki
2022-08-28 14:06 ` Rafał Miłecki
2022-08-28 14:33 ` Michael Walle
2022-08-28 14:33 ` Michael Walle
2022-08-28 14:33 ` Michael Walle
2022-08-30 13:36 ` Srinivas Kandagatla
2022-08-30 13:36 ` Srinivas Kandagatla
2022-08-30 13:36 ` Srinivas Kandagatla
2022-08-30 14:24 ` Michael Walle
2022-08-30 14:24 ` Michael Walle
2022-08-30 14:24 ` Michael Walle
2022-08-30 14:43 ` Srinivas Kandagatla
2022-08-30 14:43 ` Srinivas Kandagatla
2022-08-30 14:43 ` Srinivas Kandagatla
2022-08-30 15:02 ` Michael Walle
2022-08-30 15:02 ` Michael Walle
2022-08-30 15:02 ` Michael Walle
2022-08-30 15:23 ` Srinivas Kandagatla
2022-08-30 15:23 ` Srinivas Kandagatla
2022-08-30 15:23 ` Srinivas Kandagatla
2022-08-25 21:44 ` [PATCH v1 07/14] nvmem: core: add per-cell post processing Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-30 13:37 ` Srinivas Kandagatla
2022-08-30 13:37 ` Srinivas Kandagatla
2022-08-30 13:37 ` Srinivas Kandagatla
2022-08-30 14:20 ` Michael Walle
2022-08-30 14:20 ` Michael Walle
2022-08-30 14:20 ` Michael Walle
2022-08-25 21:44 ` [PATCH v1 08/14] dt-bindings: mtd: relax the nvmem compatible string Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-31 7:37 ` Krzysztof Kozlowski
2022-08-31 7:37 ` Krzysztof Kozlowski
2022-08-31 7:37 ` Krzysztof Kozlowski
2022-08-31 7:48 ` Michael Walle
2022-08-31 7:48 ` Michael Walle
2022-08-31 7:48 ` Michael Walle
2022-08-31 7:55 ` Krzysztof Kozlowski
2022-08-31 7:55 ` Krzysztof Kozlowski
2022-08-31 7:55 ` Krzysztof Kozlowski
2022-08-31 21:48 ` Rob Herring [this message]
2022-08-31 21:48 ` Rob Herring
2022-08-31 21:48 ` Rob Herring
2022-08-31 22:30 ` Michael Walle
2022-08-31 22:30 ` Michael Walle
2022-08-31 22:30 ` Michael Walle
2022-09-02 14:46 ` Rob Herring
2022-09-02 14:46 ` Rob Herring
2022-09-02 14:46 ` Rob Herring
2022-08-25 21:44 ` [PATCH v1 09/14] dt-bindings: nvmem: add YAML schema for the sl28 vpd layout Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-26 16:05 ` Rob Herring
2022-08-26 16:05 ` Rob Herring
2022-08-26 16:05 ` Rob Herring
2022-08-31 7:45 ` Krzysztof Kozlowski
2022-08-31 7:45 ` Krzysztof Kozlowski
2022-08-31 7:45 ` Krzysztof Kozlowski
2022-08-31 8:17 ` Michael Walle
2022-08-31 8:17 ` Michael Walle
2022-08-31 8:17 ` Michael Walle
2022-08-31 9:24 ` Krzysztof Kozlowski
2022-08-31 9:24 ` Krzysztof Kozlowski
2022-08-31 9:24 ` Krzysztof Kozlowski
2022-08-31 9:51 ` Michael Walle
2022-08-31 9:51 ` Michael Walle
2022-08-31 9:51 ` Michael Walle
2022-08-31 13:07 ` Krzysztof Kozlowski
2022-08-31 13:07 ` Krzysztof Kozlowski
2022-08-31 13:07 ` Krzysztof Kozlowski
2022-08-31 15:29 ` Michael Walle
2022-08-31 15:29 ` Michael Walle
2022-08-31 15:29 ` Michael Walle
2022-08-25 21:44 ` [PATCH v1 10/14] nvmem: layouts: add sl28vpd layout Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` [PATCH v1 11/14] nvmem: core: export nvmem device size Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` [RFC PATCH v1 12/14] nvmem: layouts: rewrite the u-boot-env driver as a NVMEM layout Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-28 14:04 ` Rafał Miłecki
2022-08-28 14:04 ` Rafał Miłecki
2022-08-28 14:04 ` Rafał Miłecki
2022-08-28 14:42 ` Michael Walle
2022-08-28 14:42 ` Michael Walle
2022-08-28 14:42 ` Michael Walle
2022-08-25 21:44 ` [RFC PATCH v1 13/14] nvmem: layouts: u-boot-env: add device node Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-28 13:55 ` Rafał Miłecki
2022-08-28 13:55 ` Rafał Miłecki
2022-08-28 13:55 ` Rafał Miłecki
2022-08-28 14:36 ` Michael Walle
2022-08-28 14:36 ` Michael Walle
2022-08-28 14:36 ` Michael Walle
2022-08-25 21:44 ` [PATCH v1 14/14] arm64: dts: ls1028a: sl28: get MAC addresses from VPD Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-25 21:44 ` Michael Walle
2022-08-28 15:05 ` [PATCH v1 00/14] nvmem: core: introduce NVMEM layouts Rafał Miłecki
2022-08-28 15:05 ` Rafał Miłecki
2022-08-28 15:05 ` Rafał Miłecki
2022-08-29 8:22 ` Michael Walle
2022-08-29 8:22 ` Michael Walle
2022-08-29 8:22 ` Michael Walle
2022-08-30 13:37 ` Srinivas Kandagatla
2022-08-30 13:37 ` Srinivas Kandagatla
2022-08-30 13:37 ` Srinivas Kandagatla
2022-08-31 7:48 ` Krzysztof Kozlowski
2022-08-31 7:48 ` Krzysztof Kozlowski
2022-08-31 7:48 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220831214809.GA282739-robh@kernel.org \
--to=robh@kernel.org \
--cc=a.fatoum@pengutronix.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=frowand.list@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.