From: Jakub Kicinski <kuba@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: <netdev@vger.kernel.org>,
davem@davemloft.net, netfilter-devel@vger.kernel.org,
pabeni@redhat.com, edumazet@google.com,
Pablo Neira Ayuso <pablo@netfilter.org>,
Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH net 1/4] netfilter: remove nf_conntrack_helper sysctl and modparam toggles
Date: Thu, 1 Sep 2022 21:07:15 -0700 [thread overview]
Message-ID: <20220901210715.00c7b4e1@kernel.org> (raw)
In-Reply-To: <20220901071238.3044-2-fw@strlen.de>
On Thu, 1 Sep 2022 09:12:35 +0200 Florian Westphal wrote:
> From: Pablo Neira Ayuso <pablo@netfilter.org>
>
> __nf_ct_try_assign_helper() remains in place but it now requires a
> template to configure the helper.
>
> A toggle to disable automatic helper assignment was added by:
>
> a9006892643a ("netfilter: nf_ct_helper: allow to disable automatic helper assignment")
>
> in 2012 to address the issues described in "Secure use of iptables and
> connection tracking helpers". Automatic conntrack helper assignment was
> disabled by:
>
> 3bb398d925ec ("netfilter: nf_ct_helper: disable automatic helper assignment")
>
> back in 2016.
>
> This patch removes the sysctl and modparam toggles, users now have to
> rely on explicit conntrack helper configuration via ruleset.
>
> Update tools/testing/selftests/netfilter/nft_conntrack_helper.sh to
> check that auto-assignment does not happen anymore.
From the description itself it's unclear why this is a part of a net PR.
Could you elucidate?
next prev parent reply other threads:[~2022-09-02 4:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 7:12 [PATCH net 0/4] netfilter: bug fixes for net Florian Westphal
2022-09-01 7:12 ` [PATCH net 1/4] netfilter: remove nf_conntrack_helper sysctl and modparam toggles Florian Westphal
2022-09-02 4:07 ` Jakub Kicinski [this message]
2022-09-02 5:39 ` Florian Westphal
2022-09-03 2:43 ` Jakub Kicinski
2022-09-03 4:20 ` patchwork-bot+netdevbpf
2022-09-01 7:12 ` [PATCH net 2/4] netfilter: br_netfilter: Drop dst references before setting Florian Westphal
2022-09-01 7:12 ` [PATCH net 3/4] netfilter: nf_tables: clean up hook list when offload flags check fails Florian Westphal
2022-09-01 7:12 ` [PATCH net 4/4] netfilter: nf_conntrack_irc: Fix forged IP logic Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220901210715.00c7b4e1@kernel.org \
--to=kuba@kernel.org \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.