From: Jakub Kicinski <kuba@kernel.org>
To: Florian Westphal <fw@strlen.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
netfilter-devel@vger.kernel.org, pabeni@redhat.com,
edumazet@google.com, Pablo Neira Ayuso <pablo@netfilter.org>,
Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH net 1/4] netfilter: remove nf_conntrack_helper sysctl and modparam toggles
Date: Fri, 2 Sep 2022 19:43:23 -0700 [thread overview]
Message-ID: <20220902194323.5533a73f@kernel.org> (raw)
In-Reply-To: <20220902053928.GA5881@breakpoint.cc>
On Fri, 2 Sep 2022 07:39:28 +0200 Florian Westphal wrote:
> > From the description itself it's unclear why this is a part of a net PR.
> > Could you elucidate?
>
> Yes, there is improper checking in the irc dcc helper, its possible to
> trigger the 'please do dynamic port forward' from outside by embedding
> a 'DCC' in a PING request; if the client echos that back a expectation/
> port forward gets added.
I see, thanks!
> A fix for this will come in the next net PR, however, one part of the
> issue is that point-blank-autassign is problematic and that helpers
> should only be enabled for addresses that need it.
>
> If you like I can resend the PR with an updated cover letter, or resend
> with the dcc helper fix included as well.
No need, I'll fold more of your explanation into the merge commit,
should be good enough.
next prev parent reply other threads:[~2022-09-03 2:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 7:12 [PATCH net 0/4] netfilter: bug fixes for net Florian Westphal
2022-09-01 7:12 ` [PATCH net 1/4] netfilter: remove nf_conntrack_helper sysctl and modparam toggles Florian Westphal
2022-09-02 4:07 ` Jakub Kicinski
2022-09-02 5:39 ` Florian Westphal
2022-09-03 2:43 ` Jakub Kicinski [this message]
2022-09-03 4:20 ` patchwork-bot+netdevbpf
2022-09-01 7:12 ` [PATCH net 2/4] netfilter: br_netfilter: Drop dst references before setting Florian Westphal
2022-09-01 7:12 ` [PATCH net 3/4] netfilter: nf_tables: clean up hook list when offload flags check fails Florian Westphal
2022-09-01 7:12 ` [PATCH net 4/4] netfilter: nf_conntrack_irc: Fix forged IP logic Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902194323.5533a73f@kernel.org \
--to=kuba@kernel.org \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.