From: Bjorn Helgaas <helgaas@kernel.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
Rajvi Jingar <rajvi.jingar@linux.intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>
Cc: Koba Ko <koba.ko@canonical.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"David E . Box" <david.e.box@linux.intel.com>,
Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@linux.intel.com>,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH 0/4] PCI/PM: Always disable PTM for all devices during
Date: Fri, 2 Sep 2022 09:58:31 -0500 [thread overview]
Message-ID: <20220902145835.344302-1-helgaas@kernel.org> (raw)
From: Bjorn Helgaas <bhelgaas@google.com>
We currently disable PTM for Root Ports during suspend. Leaving PTM
enabled for downstream devices causes UR errors if they send PTM Requests.
The intent of this series is to:
- Unconditionally disable PTM during suspend (even if the driver saves
its own state) by moving the disable from pci_prepare_to_sleep() to
pci_pm_suspend().
- Disable PTM for all devices by removing the Root Port condition.
- Manually set PTM Enable when restoring PTM state because suspend saves
the PTM state *after* disabling PTM.
This series is intended to replace Rajvi's second patch, so we would end
up with this:
Rajvi PCI/PM: Simplify pci_pm_suspend_noirq()
Bjorn PCI/PTM: Preserve PTM Root Select
Bjorn PCI/PTM: Enable PTM when restoring state
Bjorn PCI/PM: Always disable PTM for all devices during suspend
Bjorn PCI/PTM: Cache PTM Capability offset
Please comment!
Bjorn Helgaas (4):
PCI/PTM: Preserve PTM Root Select
PCI/PTM: Enable PTM when restoring state
PCI/PM: Always disable PTM for all devices during suspend
PCI/PTM: Cache PTM Capability offset
drivers/pci/pci-driver.c | 8 ++++++
drivers/pci/pci.c | 20 --------------
drivers/pci/pcie/ptm.c | 56 +++++++++++++++++++---------------------
include/linux/pci.h | 1 +
4 files changed, 35 insertions(+), 50 deletions(-)
--
2.25.1
next reply other threads:[~2022-09-02 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 14:58 Bjorn Helgaas [this message]
2022-09-02 14:58 ` [PATCH 1/4] PCI/PTM: Preserve PTM Root Select Bjorn Helgaas
2022-09-02 17:24 ` Sathyanarayanan Kuppuswamy
2022-09-02 20:38 ` Bjorn Helgaas
2022-09-02 21:11 ` Sathyanarayanan Kuppuswamy
2022-09-02 23:32 ` Bjorn Helgaas
2022-09-02 14:58 ` [PATCH 2/4] PCI/PTM: Enable PTM when restoring state Bjorn Helgaas
2022-09-02 17:25 ` Sathyanarayanan Kuppuswamy
2022-09-02 20:41 ` Bjorn Helgaas
2022-09-02 14:58 ` [PATCH 3/4] PCI/PM: Always disable PTM for all devices during suspend Bjorn Helgaas
2022-09-02 14:58 ` [PATCH 4/4] PCI/PTM: Cache PTM Capability offset Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902145835.344302-1-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=koba.ko@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rajvi.jingar@linux.intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.