From: Bjorn Helgaas <helgaas@kernel.org>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>,
Rajvi Jingar <rajvi.jingar@linux.intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>
Cc: Koba Ko <koba.ko@canonical.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"David E . Box" <david.e.box@linux.intel.com>,
Sathyanarayanan Kuppuswamy
<sathyanarayanan.kuppuswamy@linux.intel.com>,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: [PATCH 2/4] PCI/PTM: Enable PTM when restoring state
Date: Fri, 2 Sep 2022 09:58:33 -0500 [thread overview]
Message-ID: <20220902145835.344302-3-helgaas@kernel.org> (raw)
In-Reply-To: <20220902145835.344302-1-helgaas@kernel.org>
From: Bjorn Helgaas <bhelgaas@google.com>
The suspend path may disable PTM before saving config state, which means
the PCI_PTM_CTRL_ENABLE bit in the saved state may be cleared even though
we want PTM to be enabled when resuming.
If "dev->ptm_enabled" is set, it means PTM should be enabled, so make sure
PCI_PTM_CTRL_ENABLE is set when restoring the PTM state.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/pcie/ptm.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/pci/pcie/ptm.c b/drivers/pci/pcie/ptm.c
index b6a417247ce3..3115601a85ef 100644
--- a/drivers/pci/pcie/ptm.c
+++ b/drivers/pci/pcie/ptm.c
@@ -82,6 +82,14 @@ void pci_restore_ptm_state(struct pci_dev *dev)
return;
cap = (u16 *)&save_state->cap.data[0];
+
+ /*
+ * The suspend path may disable PTM before saving config state.
+ * Make sure PCI_PTM_CTRL_ENABLE is set if PTM should be enabled.
+ */
+ if (dev->ptm_enabled)
+ *cap |= PCI_PTM_CTRL_ENABLE;
+
pci_write_config_word(dev, ptm + PCI_PTM_CTRL, *cap);
}
--
2.25.1
next prev parent reply other threads:[~2022-09-02 15:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 14:58 [PATCH 0/4] PCI/PM: Always disable PTM for all devices during Bjorn Helgaas
2022-09-02 14:58 ` [PATCH 1/4] PCI/PTM: Preserve PTM Root Select Bjorn Helgaas
2022-09-02 17:24 ` Sathyanarayanan Kuppuswamy
2022-09-02 20:38 ` Bjorn Helgaas
2022-09-02 21:11 ` Sathyanarayanan Kuppuswamy
2022-09-02 23:32 ` Bjorn Helgaas
2022-09-02 14:58 ` Bjorn Helgaas [this message]
2022-09-02 17:25 ` [PATCH 2/4] PCI/PTM: Enable PTM when restoring state Sathyanarayanan Kuppuswamy
2022-09-02 20:41 ` Bjorn Helgaas
2022-09-02 14:58 ` [PATCH 3/4] PCI/PM: Always disable PTM for all devices during suspend Bjorn Helgaas
2022-09-02 14:58 ` [PATCH 4/4] PCI/PTM: Cache PTM Capability offset Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902145835.344302-3-helgaas@kernel.org \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=koba.ko@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rajvi.jingar@linux.intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.