From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH v2 2/2] powerpc/math-emu: Remove -w build flag and fix warnings
Date: Fri, 2 Sep 2022 11:27:28 -0500 [thread overview]
Message-ID: <20220902162728.GS25951@gate.crashing.org> (raw)
In-Reply-To: <YxIrRJz3+fkzogay@dev-arch.thelio-3990X>
Hi!
On Fri, Sep 02, 2022 at 09:11:48AM -0700, Nathan Chancellor wrote:
> On Fri, Sep 02, 2022 at 10:59:54AM -0500, Segher Boessenkool wrote:
> > Maybe add -Wno-implicit-fallthrough? This code is a copy from outside
> > the kernel, no one has ever wanted to maintain it, if nothing else (the
> > more politically correct formulation is "we cannot as easily pick up
> > improvements from upstream if we modify stuff").
>
> Sure, we could do something like this if you preferred:
>
> diff --git a/arch/powerpc/math-emu/Makefile b/arch/powerpc/math-emu/Makefile
> index 26fef2e5672e..ed775747a2a5 100644
> --- a/arch/powerpc/math-emu/Makefile
> +++ b/arch/powerpc/math-emu/Makefile
> @@ -16,3 +16,7 @@ obj-$(CONFIG_SPE) += math_efp.o
>
> CFLAGS_fabs.o = -fno-builtin-fabs
> CFLAGS_math.o = -fno-builtin-fabs
> +
> +ifdef CONFIG_CC_IS_CLANG
> +ccflags-remove-y := $(CONFIG_CC_IMPLICIT_FALLTHROUGH)
> +endif
That is a GCC warning as well. It needs some $(call cc-option ...)
thing then, though (GCC versions of more than two or so years ago are
supported as well).
> At the same time, I see other modifications to these files that appear
> to be for the kernel only so I suspect that this is already in the "we
> cannot as easily pick up improvements from upstream" category,
> regardless of that diff.
So maybe someone should really maintain this stuff, bring it up to some
reasonably modern state? :-)
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH v2 2/2] powerpc/math-emu: Remove -w build flag and fix warnings
Date: Fri, 2 Sep 2022 11:27:28 -0500 [thread overview]
Message-ID: <20220902162728.GS25951@gate.crashing.org> (raw)
In-Reply-To: <YxIrRJz3+fkzogay@dev-arch.thelio-3990X>
Hi!
On Fri, Sep 02, 2022 at 09:11:48AM -0700, Nathan Chancellor wrote:
> On Fri, Sep 02, 2022 at 10:59:54AM -0500, Segher Boessenkool wrote:
> > Maybe add -Wno-implicit-fallthrough? This code is a copy from outside
> > the kernel, no one has ever wanted to maintain it, if nothing else (the
> > more politically correct formulation is "we cannot as easily pick up
> > improvements from upstream if we modify stuff").
>
> Sure, we could do something like this if you preferred:
>
> diff --git a/arch/powerpc/math-emu/Makefile b/arch/powerpc/math-emu/Makefile
> index 26fef2e5672e..ed775747a2a5 100644
> --- a/arch/powerpc/math-emu/Makefile
> +++ b/arch/powerpc/math-emu/Makefile
> @@ -16,3 +16,7 @@ obj-$(CONFIG_SPE) += math_efp.o
>
> CFLAGS_fabs.o = -fno-builtin-fabs
> CFLAGS_math.o = -fno-builtin-fabs
> +
> +ifdef CONFIG_CC_IS_CLANG
> +ccflags-remove-y := $(CONFIG_CC_IMPLICIT_FALLTHROUGH)
> +endif
That is a GCC warning as well. It needs some $(call cc-option ...)
thing then, though (GCC versions of more than two or so years ago are
supported as well).
> At the same time, I see other modifications to these files that appear
> to be for the kernel only so I suspect that this is already in the "we
> cannot as easily pick up improvements from upstream" category,
> regardless of that diff.
So maybe someone should really maintain this stuff, bring it up to some
reasonably modern state? :-)
Segher
next prev parent reply other threads:[~2022-09-02 16:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 10:08 [PATCH v2 1/2] powerpc/math_emu/efp: Include module.h Christophe Leroy
2022-09-02 10:08 ` Christophe Leroy
2022-09-02 10:08 ` [PATCH v2 2/2] powerpc/math-emu: Remove -w build flag and fix warnings Christophe Leroy
2022-09-02 10:08 ` Christophe Leroy
2022-09-02 15:37 ` Nathan Chancellor
2022-09-02 15:37 ` Nathan Chancellor
2022-09-02 15:59 ` Segher Boessenkool
2022-09-02 15:59 ` Segher Boessenkool
2022-09-02 16:11 ` Christophe Leroy
2022-09-02 16:11 ` Nathan Chancellor
2022-09-02 16:11 ` Nathan Chancellor
2022-09-02 16:27 ` Segher Boessenkool [this message]
2022-09-02 16:27 ` Segher Boessenkool
-- strict thread matches above, loose matches on Subject: below --
2022-09-02 16:00 [PATCH v2 1/2] powerpc/math_emu/efp: Include module.h Christophe Leroy
2022-09-02 16:00 ` [PATCH v2 2/2] powerpc/math-emu: Remove -w build flag and fix warnings Christophe Leroy
2022-09-02 16:00 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220902162728.GS25951@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nathan@kernel.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.