All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Zhang Ying <ying.zhang22455@nxp.com>
Subject: Re: [PATCH 08/11] arm64: dts: ls1043a: add gpio based i2c recovery information
Date: Mon, 5 Sep 2022 09:06:42 +0800	[thread overview]
Message-ID: <20220905010642.GP1728671@dragon> (raw)
In-Reply-To: <20220824223700.32442-9-leoyang.li@nxp.com>

On Wed, Aug 24, 2022 at 05:36:59PM -0500, Li Yang wrote:
> Add scl-gpios property for i2c recovery and add SoC specific compatible
> string for SoC specific fixup.
> 
> Signed-off-by: Zhang Ying <ying.zhang22455@nxp.com>
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index b37244acf16a..20888aceb5f4 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -538,7 +538,7 @@ dspi1: spi@2110000 {
>  		};
>  
>  		i2c0: i2c@2180000 {
> -			compatible = "fsl,vf610-i2c";
> +			compatible = "fsl,ls1043a-i2c", "fsl,vf610-i2c";
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0x0 0x2180000 0x0 0x10000>;
> @@ -553,7 +553,7 @@ i2c0: i2c@2180000 {
>  		};
>  
>  		i2c1: i2c@2190000 {
> -			compatible = "fsl,vf610-i2c";
> +			compatible = "fsl,ls1043a-i2c", "fsl,vf610-i2c";
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0x0 0x2190000 0x0 0x10000>;
> @@ -561,11 +561,12 @@ i2c1: i2c@2190000 {
>  			clock-names = "i2c";
>  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
>  					    QORIQ_CLK_PLL_DIV(1)>;
> +			scl-gpios = <&gpio4 2 0>;

Could you use the polarity define from include/dt-bindings/gpio/gpio.h?

Shawn

>  			status = "disabled";
>  		};
>  
>  		i2c2: i2c@21a0000 {
> -			compatible = "fsl,vf610-i2c";
> +			compatible = "fsl,ls1043a-i2c", "fsl,vf610-i2c";
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0x0 0x21a0000 0x0 0x10000>;
> @@ -573,11 +574,12 @@ i2c2: i2c@21a0000 {
>  			clock-names = "i2c";
>  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
>  					    QORIQ_CLK_PLL_DIV(1)>;
> +			scl-gpios = <&gpio4 10 0>;
>  			status = "disabled";
>  		};
>  
>  		i2c3: i2c@21b0000 {
> -			compatible = "fsl,vf610-i2c";
> +			compatible = "fsl,ls1043a-i2c", "fsl,vf610-i2c";
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0x0 0x21b0000 0x0 0x10000>;
> @@ -585,6 +587,7 @@ i2c3: i2c@21b0000 {
>  			clock-names = "i2c";
>  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
>  					    QORIQ_CLK_PLL_DIV(1)>;
> +			scl-gpios = <&gpio4 12 0>;
>  			status = "disabled";
>  		};
>  
> -- 
> 2.37.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Li Yang <leoyang.li@nxp.com>
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Zhang Ying <ying.zhang22455@nxp.com>
Subject: Re: [PATCH 08/11] arm64: dts: ls1043a: add gpio based i2c recovery information
Date: Mon, 5 Sep 2022 09:06:42 +0800	[thread overview]
Message-ID: <20220905010642.GP1728671@dragon> (raw)
In-Reply-To: <20220824223700.32442-9-leoyang.li@nxp.com>

On Wed, Aug 24, 2022 at 05:36:59PM -0500, Li Yang wrote:
> Add scl-gpios property for i2c recovery and add SoC specific compatible
> string for SoC specific fixup.
> 
> Signed-off-by: Zhang Ying <ying.zhang22455@nxp.com>
> Signed-off-by: Li Yang <leoyang.li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index b37244acf16a..20888aceb5f4 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -538,7 +538,7 @@ dspi1: spi@2110000 {
>  		};
>  
>  		i2c0: i2c@2180000 {
> -			compatible = "fsl,vf610-i2c";
> +			compatible = "fsl,ls1043a-i2c", "fsl,vf610-i2c";
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0x0 0x2180000 0x0 0x10000>;
> @@ -553,7 +553,7 @@ i2c0: i2c@2180000 {
>  		};
>  
>  		i2c1: i2c@2190000 {
> -			compatible = "fsl,vf610-i2c";
> +			compatible = "fsl,ls1043a-i2c", "fsl,vf610-i2c";
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0x0 0x2190000 0x0 0x10000>;
> @@ -561,11 +561,12 @@ i2c1: i2c@2190000 {
>  			clock-names = "i2c";
>  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
>  					    QORIQ_CLK_PLL_DIV(1)>;
> +			scl-gpios = <&gpio4 2 0>;

Could you use the polarity define from include/dt-bindings/gpio/gpio.h?

Shawn

>  			status = "disabled";
>  		};
>  
>  		i2c2: i2c@21a0000 {
> -			compatible = "fsl,vf610-i2c";
> +			compatible = "fsl,ls1043a-i2c", "fsl,vf610-i2c";
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0x0 0x21a0000 0x0 0x10000>;
> @@ -573,11 +574,12 @@ i2c2: i2c@21a0000 {
>  			clock-names = "i2c";
>  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
>  					    QORIQ_CLK_PLL_DIV(1)>;
> +			scl-gpios = <&gpio4 10 0>;
>  			status = "disabled";
>  		};
>  
>  		i2c3: i2c@21b0000 {
> -			compatible = "fsl,vf610-i2c";
> +			compatible = "fsl,ls1043a-i2c", "fsl,vf610-i2c";
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <0x0 0x21b0000 0x0 0x10000>;
> @@ -585,6 +587,7 @@ i2c3: i2c@21b0000 {
>  			clock-names = "i2c";
>  			clocks = <&clockgen QORIQ_CLK_PLATFORM_PLL
>  					    QORIQ_CLK_PLL_DIV(1)>;
> +			scl-gpios = <&gpio4 12 0>;
>  			status = "disabled";
>  		};
>  
> -- 
> 2.37.1
> 

  reply	other threads:[~2022-09-05  1:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-24 22:36 [PATCH 00/11] accumulated dts updates for ls1043a Li Yang
2022-08-24 22:36 ` Li Yang
2022-08-24 22:36 ` [PATCH 01/11] arm64: dts: ls1043a: fix the wrong size of dcfg space Li Yang
2022-08-24 22:36   ` Li Yang
2022-08-24 22:36 ` [PATCH 02/11] arm64: dts: ls1043a: Enable usb3-lpm-capable for usb3 node Li Yang
2022-08-24 22:36   ` Li Yang
2022-08-24 22:36 ` [PATCH 03/11] arm64: dts: ls1043a: use pcie aer/pme interrupts Li Yang
2022-08-24 22:36   ` Li Yang
2022-09-05  1:05   ` Shawn Guo
2022-09-05  1:05     ` Shawn Guo
2022-08-24 22:36 ` [PATCH 04/11] arm64: dts: ls1043a: Add SCFG phandle for PCIe nodes Li Yang
2022-08-24 22:36   ` Li Yang
2022-08-24 22:36 ` [PATCH 05/11] arm64: dts: ls1043a: Add big-endian property " Li Yang
2022-08-24 22:36   ` Li Yang
2022-08-24 22:36 ` [PATCH 06/11] arm64: dts: ls1043a: add missing dma ranges property Li Yang
2022-08-24 22:36   ` Li Yang
2022-08-24 22:36 ` [PATCH 07/11] arm64: dts: ls1043a: make dma-coherent global to the SoC Li Yang
2022-08-24 22:36   ` Li Yang
2022-08-24 22:36 ` [PATCH 08/11] arm64: dts: ls1043a: add gpio based i2c recovery information Li Yang
2022-08-24 22:36   ` Li Yang
2022-09-05  1:06   ` Shawn Guo [this message]
2022-09-05  1:06     ` Shawn Guo
2022-08-24 22:37 ` [PATCH 09/11] arm64: dts: ls1043a: use a pseudo-bus to constrain usb and sata dma size Li Yang
2022-08-24 22:37   ` Li Yang
2022-09-05  1:09   ` Shawn Guo
2022-09-05  1:09     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220905010642.GP1728671@dragon \
    --to=shawnguo@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=ying.zhang22455@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.