All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Sergey Matyukevich <geomatsi@gmail.com>
Cc: Matt Weber <matthew.weber@collins.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/hostapd: disable build with static zlib-ng
Date: Mon, 5 Sep 2022 09:02:19 +0200	[thread overview]
Message-ID: <20220905090219.47aaf9ca@windsurf> (raw)
In-Reply-To: <20220904201429.1480971-2-geomatsi@gmail.com>

On Sun,  4 Sep 2022 23:14:28 +0300
Sergey Matyukevich <geomatsi@gmail.com> wrote:

> Static linking fails because both hostapd and zlib-ng define functions
> with the same name 'crc32'. For now do not allow to select zlib-ng as
> zlib provider for hostapd in the case if static libraries are enabled.
> 
> Fixes: http://autobuild.buildroot.net/results/9901df820d3afa4cde78e8ad6d62cb8ce7e69fdb/
> 
> Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> ---
>  package/hostapd/Config.in | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/hostapd/Config.in b/package/hostapd/Config.in
> index f4206ceea5..3a88a9d276 100644
> --- a/package/hostapd/Config.in
> +++ b/package/hostapd/Config.in
> @@ -1,6 +1,7 @@
>  config BR2_PACKAGE_HOSTAPD
>  	bool "hostapd"
>  	depends on BR2_USE_MMU # fork()
> +	depends on !(BR2_PACKAGE_ZLIB_NG && BR2_STATIC_LIBS)

Thanks for your patch. However, we generally don't like to add such
weird dependencies. Instead, we prefer to fix the actual problem:
hostapd/wpa_supplicant should probably not define a crc32() function,
but use some other naming for it.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2022-09-05  7:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-04 20:14 [Buildroot] [PATCH 0/2] hostapd/wpa_s: disable build with static zlib-ng Sergey Matyukevich
2022-09-04 20:14 ` [Buildroot] [PATCH 1/2] package/hostapd: " Sergey Matyukevich
2022-09-05  7:02   ` Thomas Petazzoni via buildroot [this message]
2022-09-05 20:36     ` Sergey Matyukevich
2022-09-04 20:14 ` [Buildroot] [PATCH 2/2] package/wpa_supplicant: " Sergey Matyukevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220905090219.47aaf9ca@windsurf \
    --to=buildroot@buildroot.org \
    --cc=geomatsi@gmail.com \
    --cc=matthew.weber@collins.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.