Re: [Buildroot] [PATCH 1/2] package/hostapd: disable build with static zlib-ng

[Sergey Matyukevich <geomatsi@gmail.com>]

> > Static linking fails because both hostapd and zlib-ng define functions
> > with the same name 'crc32'. For now do not allow to select zlib-ng as
> > zlib provider for hostapd in the case if static libraries are enabled.
> > 
> > Fixes: http://autobuild.buildroot.net/results/9901df820d3afa4cde78e8ad6d62cb8ce7e69fdb/
> > 
> > Signed-off-by: Sergey Matyukevich <geomatsi@gmail.com>
> > ---
> >  package/hostapd/Config.in | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/package/hostapd/Config.in b/package/hostapd/Config.in
> > index f4206ceea5..3a88a9d276 100644
> > --- a/package/hostapd/Config.in
> > +++ b/package/hostapd/Config.in
> > @@ -1,6 +1,7 @@
> >  config BR2_PACKAGE_HOSTAPD
> >  	bool "hostapd"
> >  	depends on BR2_USE_MMU # fork()
> > +	depends on !(BR2_PACKAGE_ZLIB_NG && BR2_STATIC_LIBS)
> 
> Thanks for your patch. However, we generally don't like to add such
> weird dependencies. Instead, we prefer to fix the actual problem:
> hostapd/wpa_supplicant should probably not define a crc32() function,
> but use some other naming for it.

Indeed, suggested dependency is too weird. I sent a patch to hostapd
mailing list fixing too generic name for its IEEE 802.11 CRC-32:
http://lists.infradead.org/pipermail/hostap/2022-September/040752.html
If it is ok with hostapd maintainer, then I will split/adapt this patch
for hostapd/wpa_s v2.10 and send v2 here.

Regards,
Sergey
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot