Re: [PATCH v2 1/2] grub-install: Add missing points of no return for IEEE1275 on i386/powerpc

[Michael Chang <mchang@suse.com>]

On Mon, Aug 29, 2022 at 04:36:24PM +0200, Ismael Luceno wrote:
> Signed-off-by: Ismael Luceno <iluceno@suse.de>
> ---
>  util/grub-install.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/util/grub-install.c b/util/grub-install.c
> index 7b04bd3c534b..527b85e27aa7 100644
> --- a/util/grub-install.c
> +++ b/util/grub-install.c
> @@ -1835,6 +1835,7 @@ main (int argc, char *argv[])
>  	    {
>  	      if (write_to_disk (ins_dev, imgfile))
>  		grub_util_error ("%s", _("failed to copy Grub to the PReP partition"));
> +	      grub_set_install_backup_ponr ();

This looks good to me.

>  	    }
>  	  else
>  	    {
> @@ -1859,6 +1860,7 @@ main (int argc, char *argv[])
>  	  partno = grub_dev->disk->partition
>  	    ? grub_dev->disk->partition->number + 1 : 0;
>  	  dev = grub_util_get_os_disk (grub_devices[0]);
> +	  grub_set_install_backup_ponr ();

This should be moved way up, given failure may occur at
grub_make_system_path_relative_to_its_root or even earlier.

But in the first place the attempt may have been wrong, given the image
is installed as file in the platform directory, there we should not be
botherd to set grub_set_install_backup_ponr as file should be able to be
backup and restored thus is covered. On the other hand, the
grub_set_install_backup_ponr looked like a workaround to me to deal with
raw images embedded in partition that has no good way to restore it.

That is for i386-ieee1275, /boot/grub2/i386-ieee1275/grub should be
added to the list of backup and restore to get it to work in failure
recovery path.

Thanks,
Michael

>  	  grub_install_register_ieee1275 (0, dev,
>  					  partno, relpath);
>  	}
> -- 
> 2.37.1
> 
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel