All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Arend van Spriel <aspriel@gmail.com>,
	Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	asahi@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com,
	"David S. Miller" <davem@davemloft.net>,
	devicetree@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
	Hector Martin <marcan@marcan.st>,
	Jakub Kicinski <kuba@kernel.org>, Kalle Valo <kvalo@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	Paolo Abeni <pabeni@redhat.com>,
	Rafa__ Mi__ecki <zajec5@gmail.com>,
	SHA-cyfmac-dev-list@infineon.com, Sven Peter <sven@svenpeter.dev>,
	van Spriel <arend@broadcom.com>
Subject: Re: [PATCH net-next 01/12] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips
Date: Wed, 7 Sep 2022 10:47:56 -0500	[thread overview]
Message-ID: <20220907154756.GA3505310-robh@kernel.org> (raw)
In-Reply-To: <E1oVpmk-005LBL-5U@rmk-PC.armlinux.org.uk>

On Wed, Sep 07, 2022 at 08:47:46AM +0100, Russell King wrote:
> From: Hector Martin <marcan@marcan.st>
> 
> This binding is currently used for SDIO devices, but these chips are
> also used as PCIe devices on DT platforms and may be represented in the
> DT. Re-use the existing binding and add chip compatibles used by Apple
> T2 and M1 platforms (the T2 ones are not known to be used in DT
> platforms, but we might as well document them).
> 
> Then, add properties required for firmware selection and calibration on
> M1 machines.
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
>  .../net/wireless/brcm,bcm4329-fmac.yaml       | 37 +++++++++++++++++--
>  1 file changed, 34 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index 53b4153d9bfc..53ded82b273a 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Broadcom BCM4329 family fullmac wireless SDIO devices
> +title: Broadcom BCM4329 family fullmac wireless SDIO/PCIE devices
>  
>  maintainers:
>    - Arend van Spriel <arend@broadcom.com>
> @@ -42,10 +42,16 @@ title: Broadcom BCM4329 family fullmac wireless SDIO devices
>                - cypress,cyw43012-fmac
>            - const: brcm,bcm4329-fmac
>        - const: brcm,bcm4329-fmac

If you respin, this compatible can be combined with the enum below.

> +      - enum:
> +          - pci14e4,43dc  # BCM4355
> +          - pci14e4,4464  # BCM4364
> +          - pci14e4,4488  # BCM4377
> +          - pci14e4,4425  # BCM4378
> +          - pci14e4,4433  # BCM4387


Reviewed-by: Rob Herring <robh@kernel.org>

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Arend van Spriel <aspriel@gmail.com>,
	Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	asahi@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com,
	"David S. Miller" <davem@davemloft.net>,
	devicetree@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
	Hector Martin <marcan@marcan.st>,
	Jakub Kicinski <kuba@kernel.org>, Kalle Valo <kvalo@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	Paolo Abeni <pabeni@redhat.com>,
	Rafa__ Mi__ecki <zajec5@gmail.com>,
	SHA-cyfmac-dev-list@infineon.com, Sven Peter <sven@svenpeter.dev>,
	van Spriel <arend@broadcom.com>
Subject: Re: [PATCH net-next 01/12] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips
Date: Wed, 7 Sep 2022 10:47:56 -0500	[thread overview]
Message-ID: <20220907154756.GA3505310-robh@kernel.org> (raw)
In-Reply-To: <E1oVpmk-005LBL-5U@rmk-PC.armlinux.org.uk>

On Wed, Sep 07, 2022 at 08:47:46AM +0100, Russell King wrote:
> From: Hector Martin <marcan@marcan.st>
> 
> This binding is currently used for SDIO devices, but these chips are
> also used as PCIe devices on DT platforms and may be represented in the
> DT. Re-use the existing binding and add chip compatibles used by Apple
> T2 and M1 platforms (the T2 ones are not known to be used in DT
> platforms, but we might as well document them).
> 
> Then, add properties required for firmware selection and calibration on
> M1 machines.
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Hector Martin <marcan@marcan.st>
> Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
> ---
>  .../net/wireless/brcm,bcm4329-fmac.yaml       | 37 +++++++++++++++++--
>  1 file changed, 34 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index 53b4153d9bfc..53ded82b273a 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -4,7 +4,7 @@
>  $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Broadcom BCM4329 family fullmac wireless SDIO devices
> +title: Broadcom BCM4329 family fullmac wireless SDIO/PCIE devices
>  
>  maintainers:
>    - Arend van Spriel <arend@broadcom.com>
> @@ -42,10 +42,16 @@ title: Broadcom BCM4329 family fullmac wireless SDIO devices
>                - cypress,cyw43012-fmac
>            - const: brcm,bcm4329-fmac
>        - const: brcm,bcm4329-fmac

If you respin, this compatible can be combined with the enum below.

> +      - enum:
> +          - pci14e4,43dc  # BCM4355
> +          - pci14e4,4464  # BCM4364
> +          - pci14e4,4488  # BCM4377
> +          - pci14e4,4425  # BCM4378
> +          - pci14e4,4433  # BCM4387


Reviewed-by: Rob Herring <robh@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-09-07 15:47 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07  7:46 [PATCH net-next 0/12] Add support for bcm4378 on Apple platforms Russell King (Oracle)
2022-09-07  7:46 ` Russell King (Oracle)
2022-09-07  7:47 ` [PATCH net-next 01/12] dt-bindings: net: bcm4329-fmac: Add Apple properties & chips Russell King
2022-09-07  7:47   ` Russell King
2022-09-07  9:25   ` Mark Kettenis
2022-09-07  9:25     ` Mark Kettenis
2022-09-07 15:47   ` Rob Herring [this message]
2022-09-07 15:47     ` Rob Herring
2022-09-07  7:47 ` [PATCH net-next 02/12] brcmfmac: firmware: Handle per-board clm_blob files Russell King
2022-09-07  7:47   ` Russell King
2022-09-07  7:47 ` [PATCH net-next 03/12] brcmfmac: pcie/sdio/usb: Get CLM blob via standard firmware mechanism Russell King
2022-09-07  7:47   ` Russell King
2022-09-07  7:48 ` [PATCH net-next 04/12] brcmfmac: firmware: Support passing in multiple board_types Russell King
2022-09-07  7:48   ` Russell King
2022-09-07  7:48 ` [PATCH net-next 05/12] brcmfmac: pcie: Read Apple OTP information Russell King
2022-09-07  7:48   ` Russell King
2022-09-11 19:48   ` kernel test robot
2022-09-07  7:48 ` [PATCH net-next 06/12] brcmfmac: of: Fetch Apple properties Russell King
2022-09-07  7:48   ` Russell King
2022-09-07  7:48 ` [PATCH net-next 07/12] brcmfmac: pcie: Perform firmware selection for Apple platforms Russell King
2022-09-07  7:48   ` Russell King
2022-09-07  7:48 ` [PATCH net-next 08/12] brcmfmac: firmware: Allow platform to override macaddr Russell King
2022-09-07  7:48   ` Russell King
2022-09-07  7:48 ` [PATCH net-next 09/12] brcmfmac: msgbuf: Increase RX ring sizes to 1024 Russell King
2022-09-07  7:48   ` Russell King
2022-09-07  7:48 ` [PATCH net-next 10/12] brcmfmac: pcie: Support PCIe core revisions >= 64 Russell King
2022-09-07  7:48   ` Russell King
2022-09-07  7:48 ` [PATCH net-next 11/12] brcmfmac: pcie: Add IDs/properties for BCM4378 Russell King
2022-09-07  7:48   ` Russell King
2022-09-07  7:48 ` [PATCH net-next 12/12] arm64: dts: apple: Add WiFi module and antenna properties Russell King
2022-09-07  7:48   ` Russell King
2022-09-07  8:16   ` Kalle Valo
2022-09-07  8:16     ` Kalle Valo
2022-09-13 16:28     ` Russell King (Oracle)
2022-09-13 16:28       ` Russell King (Oracle)
2022-09-16  7:27       ` Kalle Valo
2022-09-16  7:27         ` Kalle Valo
2022-09-07  9:27   ` Mark Kettenis
2022-09-07  9:27     ` Mark Kettenis
2022-09-07  8:14 ` [PATCH net-next 0/12] Add support for bcm4378 on Apple platforms Kalle Valo
2022-09-07  8:14   ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220907154756.GA3505310-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=SHA-cyfmac-dev-list@infineon.com \
    --cc=alyssa@rosenzweig.io \
    --cc=arend@broadcom.com \
    --cc=asahi@lists.linux.dev \
    --cc=aspriel@gmail.com \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=franky.lin@broadcom.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=sven@svenpeter.dev \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.