* [PATCH 1/6] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity
@ 2022-08-12 17:35 ` Tim Harvey
0 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-12 17:35 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
The CAN STBY poarlity is active-low. Specify it as such.
Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index 521215520a0f..de17021df53f 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -123,8 +123,8 @@ reg_can2_stby: regulator-can2-stby {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_reg_can>;
regulator-name = "can2_stby";
- gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
- enable-active-high;
+ gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
+ enable-active-low;
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
};
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and unused pinctrl_sai2
2022-08-12 17:35 ` Tim Harvey
@ 2022-08-12 17:35 ` Tim Harvey
-1 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-12 17:35 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
pinctrl_sai2 is not yet used and not properly defined - remove it to
avoid:
imx8mp-pinctrl 30330000.pinctrl: Invalid fsl,pins or pins propert
y in node /soc@0/bus@30000000/pinctrl@30330000/sai2grp
Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts
support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index de17021df53f..80f0f1aafdbf 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -768,15 +768,6 @@ MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09 0x110
>;
};
- pinctrl_sai2: sai2grp {
- fsl,pins = <
- MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC
- MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00
- MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK
- MX8MP_IOMUXC_SAI2_MCLK__AUDIOMIX_SAI2_MCLK
- >;
- };
-
pinctrl_spi2: spi2grp {
fsl,pins = <
MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x82
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and unused pinctrl_sai2
@ 2022-08-12 17:35 ` Tim Harvey
0 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-12 17:35 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
pinctrl_sai2 is not yet used and not properly defined - remove it to
avoid:
imx8mp-pinctrl 30330000.pinctrl: Invalid fsl,pins or pins propert
y in node /soc@0/bus@30000000/pinctrl@30330000/sai2grp
Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts
support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index de17021df53f..80f0f1aafdbf 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -768,15 +768,6 @@ MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09 0x110
>;
};
- pinctrl_sai2: sai2grp {
- fsl,pins = <
- MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC
- MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00
- MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK
- MX8MP_IOMUXC_SAI2_MCLK__AUDIOMIX_SAI2_MCLK
- >;
- };
-
pinctrl_spi2: spi2grp {
fsl,pins = <
MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x82
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread* Re: [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and unused pinctrl_sai2
2022-08-12 17:35 ` Tim Harvey
@ 2022-08-22 17:03 ` Tim Harvey
-1 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-22 17:03 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel, Peng Fan (OSS)
On Fri, Aug 12, 2022 at 10:35 AM Tim Harvey <tharvey@gateworks.com> wrote:
>
> pinctrl_sai2 is not yet used and not properly defined - remove it to
> avoid:
> imx8mp-pinctrl 30330000.pinctrl: Invalid fsl,pins or pins propert
> y in node /soc@0/bus@30000000/pinctrl@30330000/sai2grp
>
> Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts
> support")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> index de17021df53f..80f0f1aafdbf 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> @@ -768,15 +768,6 @@ MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09 0x110
> >;
> };
>
> - pinctrl_sai2: sai2grp {
> - fsl,pins = <
> - MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC
> - MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00
> - MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK
> - MX8MP_IOMUXC_SAI2_MCLK__AUDIOMIX_SAI2_MCLK
> - >;
> - };
> -
> pinctrl_spi2: spi2grp {
> fsl,pins = <
> MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x82
> --
> 2.25.1
>
Shawn,
You can drop this. I didn't see Peng's patch commit 706dd9d30d3b
("arm64: dts: imx8mp-venice-gw74xx: fix sai2 pin settings") which
takes care of this.
Best Regards,
Tim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and unused pinctrl_sai2
@ 2022-08-22 17:03 ` Tim Harvey
0 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-22 17:03 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel, Peng Fan (OSS)
On Fri, Aug 12, 2022 at 10:35 AM Tim Harvey <tharvey@gateworks.com> wrote:
>
> pinctrl_sai2 is not yet used and not properly defined - remove it to
> avoid:
> imx8mp-pinctrl 30330000.pinctrl: Invalid fsl,pins or pins propert
> y in node /soc@0/bus@30000000/pinctrl@30330000/sai2grp
>
> Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts
> support")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> index de17021df53f..80f0f1aafdbf 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> @@ -768,15 +768,6 @@ MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09 0x110
> >;
> };
>
> - pinctrl_sai2: sai2grp {
> - fsl,pins = <
> - MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC
> - MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00
> - MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK
> - MX8MP_IOMUXC_SAI2_MCLK__AUDIOMIX_SAI2_MCLK
> - >;
> - };
> -
> pinctrl_spi2: spi2grp {
> fsl,pins = <
> MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x82
> --
> 2.25.1
>
Shawn,
You can drop this. I didn't see Peng's patch commit 706dd9d30d3b
("arm64: dts: imx8mp-venice-gw74xx: fix sai2 pin settings") which
takes care of this.
Best Regards,
Tim
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and unused pinctrl_sai2
2022-08-22 17:03 ` Tim Harvey
@ 2022-09-08 15:45 ` Tim Harvey
-1 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-09-08 15:45 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel, Peng Fan (OSS)
On Mon, Aug 22, 2022 at 10:03 AM Tim Harvey <tharvey@gateworks.com> wrote:
>
> On Fri, Aug 12, 2022 at 10:35 AM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > pinctrl_sai2 is not yet used and not properly defined - remove it to
> > avoid:
> > imx8mp-pinctrl 30330000.pinctrl: Invalid fsl,pins or pins propert
> > y in node /soc@0/bus@30000000/pinctrl@30330000/sai2grp
> >
> > Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts
> > support")
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 9 ---------
> > 1 file changed, 9 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > index de17021df53f..80f0f1aafdbf 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > @@ -768,15 +768,6 @@ MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09 0x110
> > >;
> > };
> >
> > - pinctrl_sai2: sai2grp {
> > - fsl,pins = <
> > - MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC
> > - MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00
> > - MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK
> > - MX8MP_IOMUXC_SAI2_MCLK__AUDIOMIX_SAI2_MCLK
> > - >;
> > - };
> > -
> > pinctrl_spi2: spi2grp {
> > fsl,pins = <
> > MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x82
> > --
> > 2.25.1
> >
>
> Shawn,
>
> You can drop this. I didn't see Peng's patch commit 706dd9d30d3b
> ("arm64: dts: imx8mp-venice-gw74xx: fix sai2 pin settings") which
> takes care of this.
>
> Best Regards,
>
> Tim
Shawn,
Did you need me to re-submit the series this patch was in without it?
I haven't seen any responses to the rest of the patches in this
series.
Best Regards,
Tim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and unused pinctrl_sai2
@ 2022-09-08 15:45 ` Tim Harvey
0 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-09-08 15:45 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel, Peng Fan (OSS)
On Mon, Aug 22, 2022 at 10:03 AM Tim Harvey <tharvey@gateworks.com> wrote:
>
> On Fri, Aug 12, 2022 at 10:35 AM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > pinctrl_sai2 is not yet used and not properly defined - remove it to
> > avoid:
> > imx8mp-pinctrl 30330000.pinctrl: Invalid fsl,pins or pins propert
> > y in node /soc@0/bus@30000000/pinctrl@30330000/sai2grp
> >
> > Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts
> > support")
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 9 ---------
> > 1 file changed, 9 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > index de17021df53f..80f0f1aafdbf 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > @@ -768,15 +768,6 @@ MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09 0x110
> > >;
> > };
> >
> > - pinctrl_sai2: sai2grp {
> > - fsl,pins = <
> > - MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC
> > - MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00
> > - MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK
> > - MX8MP_IOMUXC_SAI2_MCLK__AUDIOMIX_SAI2_MCLK
> > - >;
> > - };
> > -
> > pinctrl_spi2: spi2grp {
> > fsl,pins = <
> > MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x82
> > --
> > 2.25.1
> >
>
> Shawn,
>
> You can drop this. I didn't see Peng's patch commit 706dd9d30d3b
> ("arm64: dts: imx8mp-venice-gw74xx: fix sai2 pin settings") which
> takes care of this.
>
> Best Regards,
>
> Tim
Shawn,
Did you need me to re-submit the series this patch was in without it?
I haven't seen any responses to the rest of the patches in this
series.
Best Regards,
Tim
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and unused pinctrl_sai2
2022-09-08 15:45 ` Tim Harvey
@ 2022-09-12 8:04 ` Shawn Guo
-1 siblings, 0 replies; 24+ messages in thread
From: Shawn Guo @ 2022-09-12 8:04 UTC (permalink / raw)
To: Tim Harvey
Cc: Fabio Estevam, NXP Linux Team, Sascha Hauer, Rob Herring,
Krzysztof Kozlowski, Pengutronix Kernel Team, devicetree,
linux-arm-kernel, linux-kernel, Peng Fan (OSS)
On Thu, Sep 08, 2022 at 08:45:24AM -0700, Tim Harvey wrote:
> On Mon, Aug 22, 2022 at 10:03 AM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > On Fri, Aug 12, 2022 at 10:35 AM Tim Harvey <tharvey@gateworks.com> wrote:
> > >
> > > pinctrl_sai2 is not yet used and not properly defined - remove it to
> > > avoid:
> > > imx8mp-pinctrl 30330000.pinctrl: Invalid fsl,pins or pins propert
> > > y in node /soc@0/bus@30000000/pinctrl@30330000/sai2grp
> > >
> > > Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts
> > > support")
> > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > > ---
> > > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 9 ---------
> > > 1 file changed, 9 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > index de17021df53f..80f0f1aafdbf 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > @@ -768,15 +768,6 @@ MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09 0x110
> > > >;
> > > };
> > >
> > > - pinctrl_sai2: sai2grp {
> > > - fsl,pins = <
> > > - MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC
> > > - MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00
> > > - MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK
> > > - MX8MP_IOMUXC_SAI2_MCLK__AUDIOMIX_SAI2_MCLK
> > > - >;
> > > - };
> > > -
> > > pinctrl_spi2: spi2grp {
> > > fsl,pins = <
> > > MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x82
> > > --
> > > 2.25.1
> > >
> >
> > Shawn,
> >
> > You can drop this. I didn't see Peng's patch commit 706dd9d30d3b
> > ("arm64: dts: imx8mp-venice-gw74xx: fix sai2 pin settings") which
> > takes care of this.
> >
> > Best Regards,
> >
> > Tim
>
> Shawn,
>
> Did you need me to re-submit the series this patch was in without it?
> I haven't seen any responses to the rest of the patches in this
> series.
You said you will send a new version in responding to Fabio's comment on
patch 1/6 [1], right?
Shawn
[1] https://lore.kernel.org/linux-arm-kernel/CAJ+vNU3E+5DWR5tQyUurLzGkinjX2fidbVNZ4T70CNmhM6eNTw@mail.gmail.com/
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and unused pinctrl_sai2
@ 2022-09-12 8:04 ` Shawn Guo
0 siblings, 0 replies; 24+ messages in thread
From: Shawn Guo @ 2022-09-12 8:04 UTC (permalink / raw)
To: Tim Harvey
Cc: Fabio Estevam, NXP Linux Team, Sascha Hauer, Rob Herring,
Krzysztof Kozlowski, Pengutronix Kernel Team, devicetree,
linux-arm-kernel, linux-kernel, Peng Fan (OSS)
On Thu, Sep 08, 2022 at 08:45:24AM -0700, Tim Harvey wrote:
> On Mon, Aug 22, 2022 at 10:03 AM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > On Fri, Aug 12, 2022 at 10:35 AM Tim Harvey <tharvey@gateworks.com> wrote:
> > >
> > > pinctrl_sai2 is not yet used and not properly defined - remove it to
> > > avoid:
> > > imx8mp-pinctrl 30330000.pinctrl: Invalid fsl,pins or pins propert
> > > y in node /soc@0/bus@30000000/pinctrl@30330000/sai2grp
> > >
> > > Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts
> > > support")
> > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > > ---
> > > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 9 ---------
> > > 1 file changed, 9 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > index de17021df53f..80f0f1aafdbf 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > @@ -768,15 +768,6 @@ MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09 0x110
> > > >;
> > > };
> > >
> > > - pinctrl_sai2: sai2grp {
> > > - fsl,pins = <
> > > - MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC
> > > - MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00
> > > - MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK
> > > - MX8MP_IOMUXC_SAI2_MCLK__AUDIOMIX_SAI2_MCLK
> > > - >;
> > > - };
> > > -
> > > pinctrl_spi2: spi2grp {
> > > fsl,pins = <
> > > MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x82
> > > --
> > > 2.25.1
> > >
> >
> > Shawn,
> >
> > You can drop this. I didn't see Peng's patch commit 706dd9d30d3b
> > ("arm64: dts: imx8mp-venice-gw74xx: fix sai2 pin settings") which
> > takes care of this.
> >
> > Best Regards,
> >
> > Tim
>
> Shawn,
>
> Did you need me to re-submit the series this patch was in without it?
> I haven't seen any responses to the rest of the patches in this
> series.
You said you will send a new version in responding to Fabio's comment on
patch 1/6 [1], right?
Shawn
[1] https://lore.kernel.org/linux-arm-kernel/CAJ+vNU3E+5DWR5tQyUurLzGkinjX2fidbVNZ4T70CNmhM6eNTw@mail.gmail.com/
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and unused pinctrl_sai2
2022-09-12 8:04 ` Shawn Guo
@ 2022-09-12 18:01 ` Tim Harvey
-1 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-09-12 18:01 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Sascha Hauer, Rob Herring,
Krzysztof Kozlowski, Pengutronix Kernel Team, devicetree,
linux-arm-kernel, linux-kernel, Peng Fan (OSS)
On Mon, Sep 12, 2022 at 1:04 AM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Thu, Sep 08, 2022 at 08:45:24AM -0700, Tim Harvey wrote:
> > On Mon, Aug 22, 2022 at 10:03 AM Tim Harvey <tharvey@gateworks.com> wrote:
> > >
> > > On Fri, Aug 12, 2022 at 10:35 AM Tim Harvey <tharvey@gateworks.com> wrote:
> > > >
> > > > pinctrl_sai2 is not yet used and not properly defined - remove it to
> > > > avoid:
> > > > imx8mp-pinctrl 30330000.pinctrl: Invalid fsl,pins or pins propert
> > > > y in node /soc@0/bus@30000000/pinctrl@30330000/sai2grp
> > > >
> > > > Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts
> > > > support")
> > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > > > ---
> > > > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 9 ---------
> > > > 1 file changed, 9 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > > index de17021df53f..80f0f1aafdbf 100644
> > > > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > > @@ -768,15 +768,6 @@ MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09 0x110
> > > > >;
> > > > };
> > > >
> > > > - pinctrl_sai2: sai2grp {
> > > > - fsl,pins = <
> > > > - MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC
> > > > - MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00
> > > > - MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK
> > > > - MX8MP_IOMUXC_SAI2_MCLK__AUDIOMIX_SAI2_MCLK
> > > > - >;
> > > > - };
> > > > -
> > > > pinctrl_spi2: spi2grp {
> > > > fsl,pins = <
> > > > MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x82
> > > > --
> > > > 2.25.1
> > > >
> > >
> > > Shawn,
> > >
> > > You can drop this. I didn't see Peng's patch commit 706dd9d30d3b
> > > ("arm64: dts: imx8mp-venice-gw74xx: fix sai2 pin settings") which
> > > takes care of this.
> > >
> > > Best Regards,
> > >
> > > Tim
> >
> > Shawn,
> >
> > Did you need me to re-submit the series this patch was in without it?
> > I haven't seen any responses to the rest of the patches in this
> > series.
>
> You said you will send a new version in responding to Fabio's comment on
> patch 1/6 [1], right?
>
> Shawn
>
> [1] https://lore.kernel.org/linux-arm-kernel/CAJ+vNU3E+5DWR5tQyUurLzGkinjX2fidbVNZ4T70CNmhM6eNTw@mail.gmail.com/
Shawn,
Yes, I will re-submit that series.
Thanks,
Tim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and unused pinctrl_sai2
@ 2022-09-12 18:01 ` Tim Harvey
0 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-09-12 18:01 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam, NXP Linux Team, Sascha Hauer, Rob Herring,
Krzysztof Kozlowski, Pengutronix Kernel Team, devicetree,
linux-arm-kernel, linux-kernel, Peng Fan (OSS)
On Mon, Sep 12, 2022 at 1:04 AM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Thu, Sep 08, 2022 at 08:45:24AM -0700, Tim Harvey wrote:
> > On Mon, Aug 22, 2022 at 10:03 AM Tim Harvey <tharvey@gateworks.com> wrote:
> > >
> > > On Fri, Aug 12, 2022 at 10:35 AM Tim Harvey <tharvey@gateworks.com> wrote:
> > > >
> > > > pinctrl_sai2 is not yet used and not properly defined - remove it to
> > > > avoid:
> > > > imx8mp-pinctrl 30330000.pinctrl: Invalid fsl,pins or pins propert
> > > > y in node /soc@0/bus@30000000/pinctrl@30330000/sai2grp
> > > >
> > > > Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts
> > > > support")
> > > > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> > > > ---
> > > > arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 9 ---------
> > > > 1 file changed, 9 deletions(-)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > > index de17021df53f..80f0f1aafdbf 100644
> > > > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > > > @@ -768,15 +768,6 @@ MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09 0x110
> > > > >;
> > > > };
> > > >
> > > > - pinctrl_sai2: sai2grp {
> > > > - fsl,pins = <
> > > > - MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC
> > > > - MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00
> > > > - MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK
> > > > - MX8MP_IOMUXC_SAI2_MCLK__AUDIOMIX_SAI2_MCLK
> > > > - >;
> > > > - };
> > > > -
> > > > pinctrl_spi2: spi2grp {
> > > > fsl,pins = <
> > > > MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK 0x82
> > > > --
> > > > 2.25.1
> > > >
> > >
> > > Shawn,
> > >
> > > You can drop this. I didn't see Peng's patch commit 706dd9d30d3b
> > > ("arm64: dts: imx8mp-venice-gw74xx: fix sai2 pin settings") which
> > > takes care of this.
> > >
> > > Best Regards,
> > >
> > > Tim
> >
> > Shawn,
> >
> > Did you need me to re-submit the series this patch was in without it?
> > I haven't seen any responses to the rest of the patches in this
> > series.
>
> You said you will send a new version in responding to Fabio's comment on
> patch 1/6 [1], right?
>
> Shawn
>
> [1] https://lore.kernel.org/linux-arm-kernel/CAJ+vNU3E+5DWR5tQyUurLzGkinjX2fidbVNZ4T70CNmhM6eNTw@mail.gmail.com/
Shawn,
Yes, I will re-submit that series.
Thanks,
Tim
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH 3/6] arm64: dts: imx8mp-venice-gw74xx: fix ksz9477 cpu port
2022-08-12 17:35 ` Tim Harvey
@ 2022-08-12 17:35 ` Tim Harvey
-1 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-12 17:35 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
The CPU uplink port on the KSZ9477 is P5 not P6 - fix this.
Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index 80f0f1aafdbf..6ab4896f708b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -511,8 +511,8 @@ lan5: port@4 {
local-mac-address = [00 00 00 00 00 00];
};
- port@6 {
- reg = <6>;
+ port@5 {
+ reg = <5>;
label = "cpu";
ethernet = <&fec>;
phy-mode = "rgmii-id";
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 3/6] arm64: dts: imx8mp-venice-gw74xx: fix ksz9477 cpu port
@ 2022-08-12 17:35 ` Tim Harvey
0 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-12 17:35 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
The CPU uplink port on the KSZ9477 is P5 not P6 - fix this.
Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index 80f0f1aafdbf..6ab4896f708b 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -511,8 +511,8 @@ lan5: port@4 {
local-mac-address = [00 00 00 00 00 00];
};
- port@6 {
- reg = <6>;
+ port@5 {
+ reg = <5>;
label = "cpu";
ethernet = <&fec>;
phy-mode = "rgmii-id";
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 4/6] arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation
2022-08-12 17:35 ` Tim Harvey
@ 2022-08-12 17:35 ` Tim Harvey
-1 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-12 17:35 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
Since commit 65ac79e18120 ("net: dsa: microchip: add the phylink
get_caps") the phy-mode must be set otherwise the switch driver will
assume "NA" mode and invalidate the port.
Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400
dts support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index 6ab4896f708b..cb4cf293a7b7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -484,30 +484,35 @@ ports {
lan1: port@0 {
reg = <0>;
label = "lan1";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan2: port@1 {
reg = <1>;
label = "lan2";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan3: port@2 {
reg = <2>;
label = "lan3";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan4: port@3 {
reg = <3>;
label = "lan4";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan5: port@4 {
reg = <4>;
label = "lan5";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 4/6] arm64: dts: imx8mp-venice-gw74xx: fix port/phy validation
@ 2022-08-12 17:35 ` Tim Harvey
0 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-12 17:35 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
Since commit 65ac79e18120 ("net: dsa: microchip: add the phylink
get_caps") the phy-mode must be set otherwise the switch driver will
assume "NA" mode and invalidate the port.
Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400
dts support")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index 6ab4896f708b..cb4cf293a7b7 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -484,30 +484,35 @@ ports {
lan1: port@0 {
reg = <0>;
label = "lan1";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan2: port@1 {
reg = <1>;
label = "lan2";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan3: port@2 {
reg = <2>;
label = "lan3";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan4: port@3 {
reg = <3>;
label = "lan4";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
lan5: port@4 {
reg = <4>;
label = "lan5";
+ phy-mode = "internal";
local-mac-address = [00 00 00 00 00 00];
};
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 5/6] arm64: dts: imx8mp-venice-gw74xx: add cpu-supply node for cpufreq
2022-08-12 17:35 ` Tim Harvey
@ 2022-08-12 17:35 ` Tim Harvey
-1 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-12 17:35 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
Add regulator config for cpu-supply in order to support cpufreq.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
.../dts/freescale/imx8mp-venice-gw74xx.dts | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index cb4cf293a7b7..bfc480aaf54d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -142,6 +142,22 @@ reg_wifi_en: regulator-wifi-en {
};
};
+&A53_0 {
+ cpu-supply = <®_arm>;
+};
+
+&A53_1 {
+ cpu-supply = <®_arm>;
+};
+
+&A53_2 {
+ cpu-supply = <®_arm>;
+};
+
+&A53_3 {
+ cpu-supply = <®_arm>;
+};
+
/* off-board header */
&ecspi2 {
pinctrl-names = "default";
@@ -362,7 +378,7 @@ BUCK1 {
regulator-ramp-delay = <3125>;
};
- BUCK2 {
+ reg_arm: BUCK2 {
regulator-name = "BUCK2";
regulator-min-microvolt = <720000>;
regulator-max-microvolt = <1025000>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 5/6] arm64: dts: imx8mp-venice-gw74xx: add cpu-supply node for cpufreq
@ 2022-08-12 17:35 ` Tim Harvey
0 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-12 17:35 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
Add regulator config for cpu-supply in order to support cpufreq.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
.../dts/freescale/imx8mp-venice-gw74xx.dts | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index cb4cf293a7b7..bfc480aaf54d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -142,6 +142,22 @@ reg_wifi_en: regulator-wifi-en {
};
};
+&A53_0 {
+ cpu-supply = <®_arm>;
+};
+
+&A53_1 {
+ cpu-supply = <®_arm>;
+};
+
+&A53_2 {
+ cpu-supply = <®_arm>;
+};
+
+&A53_3 {
+ cpu-supply = <®_arm>;
+};
+
/* off-board header */
&ecspi2 {
pinctrl-names = "default";
@@ -362,7 +378,7 @@ BUCK1 {
regulator-ramp-delay = <3125>;
};
- BUCK2 {
+ reg_arm: BUCK2 {
regulator-name = "BUCK2";
regulator-min-microvolt = <720000>;
regulator-max-microvolt = <1025000>;
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH 6/6] arm64: dts: imx8mp-venice-gw74xx: add WiFi/BT module support
2022-08-12 17:35 ` Tim Harvey
@ 2022-08-12 17:35 ` Tim Harvey
-1 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-12 17:35 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
The GW74xx supports an on-board Laird Connectivity Sterling LWB5+ module
which uses a Cypress CYW4373W chip to provide 1x1 802.11 a/b/g/n/ac +
Bluetooth 5.2.
Add the proper device-tree nodes for it.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
.../dts/freescale/imx8mp-venice-gw74xx.dts | 38 +++++++++++++++++--
1 file changed, 35 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index bfc480aaf54d..47866d4e5444 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -135,10 +135,10 @@ reg_wifi_en: regulator-wifi-en {
compatible = "regulator-fixed";
regulator-name = "wl";
gpio = <&gpio3 9 GPIO_ACTIVE_HIGH>;
- startup-delay-us = <100>;
+ startup-delay-us = <70000>;
enable-active-high;
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
};
};
@@ -577,6 +577,21 @@ &uart2 {
status = "okay";
};
+/* bluetooth HCI */
+&uart3 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>;
+ cts-gpios = <&gpio3 21 GPIO_ACTIVE_LOW>;
+ rts-gpios = <&gpio3 22 GPIO_ACTIVE_LOW>;
+ uart-has-rtscts;
+ status = "okay";
+
+ bluetooth {
+ compatible = "brcm,bcm4330-bt";
+ shutdown-gpios = <&gpio3 8 GPIO_ACTIVE_HIGH>;
+ };
+};
+
&uart4 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart4>;
@@ -617,6 +632,23 @@ &usb_dwc3_1 {
status = "okay";
};
+/* SDIO WiFi */
+&usdhc1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc1>;
+ bus-width = <4>;
+ non-removable;
+ vmmc-supply = <®_wifi_en>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ wifi@0 {
+ compatible = "cypress,cyw4373-fmac";
+ reg = <0>;
+ };
+};
+
/* eMMC */
&usdhc3 {
assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
--
2.25.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 24+ messages in thread* [PATCH 6/6] arm64: dts: imx8mp-venice-gw74xx: add WiFi/BT module support
@ 2022-08-12 17:35 ` Tim Harvey
0 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-12 17:35 UTC (permalink / raw)
To: Shawn Guo, Fabio Estevam, NXP Linux Team, Sascha Hauer,
Rob Herring, Krzysztof Kozlowski, Pengutronix Kernel Team,
devicetree, linux-arm-kernel, linux-kernel
Cc: Tim Harvey
The GW74xx supports an on-board Laird Connectivity Sterling LWB5+ module
which uses a Cypress CYW4373W chip to provide 1x1 802.11 a/b/g/n/ac +
Bluetooth 5.2.
Add the proper device-tree nodes for it.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
.../dts/freescale/imx8mp-venice-gw74xx.dts | 38 +++++++++++++++++--
1 file changed, 35 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
index bfc480aaf54d..47866d4e5444 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
@@ -135,10 +135,10 @@ reg_wifi_en: regulator-wifi-en {
compatible = "regulator-fixed";
regulator-name = "wl";
gpio = <&gpio3 9 GPIO_ACTIVE_HIGH>;
- startup-delay-us = <100>;
+ startup-delay-us = <70000>;
enable-active-high;
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
};
};
@@ -577,6 +577,21 @@ &uart2 {
status = "okay";
};
+/* bluetooth HCI */
+&uart3 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_uart3>, <&pinctrl_uart3_gpio>;
+ cts-gpios = <&gpio3 21 GPIO_ACTIVE_LOW>;
+ rts-gpios = <&gpio3 22 GPIO_ACTIVE_LOW>;
+ uart-has-rtscts;
+ status = "okay";
+
+ bluetooth {
+ compatible = "brcm,bcm4330-bt";
+ shutdown-gpios = <&gpio3 8 GPIO_ACTIVE_HIGH>;
+ };
+};
+
&uart4 {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart4>;
@@ -617,6 +632,23 @@ &usb_dwc3_1 {
status = "okay";
};
+/* SDIO WiFi */
+&usdhc1 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usdhc1>;
+ bus-width = <4>;
+ non-removable;
+ vmmc-supply = <®_wifi_en>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "okay";
+
+ wifi@0 {
+ compatible = "cypress,cyw4373-fmac";
+ reg = <0>;
+ };
+};
+
/* eMMC */
&usdhc3 {
assigned-clocks = <&clk IMX8MP_CLK_USDHC3>;
--
2.25.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH 1/6] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity
2022-08-12 17:35 ` Tim Harvey
@ 2022-08-12 17:50 ` Fabio Estevam
-1 siblings, 0 replies; 24+ messages in thread
From: Fabio Estevam @ 2022-08-12 17:50 UTC (permalink / raw)
To: Tim Harvey
Cc: Shawn Guo, NXP Linux Team, Sascha Hauer, Rob Herring,
Krzysztof Kozlowski, Pengutronix Kernel Team, devicetree,
linux-arm-kernel, linux-kernel
Hi Tim,
On Fri, Aug 12, 2022 at 2:35 PM Tim Harvey <tharvey@gateworks.com> wrote:
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> index 521215520a0f..de17021df53f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> @@ -123,8 +123,8 @@ reg_can2_stby: regulator-can2-stby {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_reg_can>;
> regulator-name = "can2_stby";
> - gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
> - enable-active-high;
> + gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
> + enable-active-low;
This 'enable-active-low' property does not exist. Just remove it.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 1/6] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity
@ 2022-08-12 17:50 ` Fabio Estevam
0 siblings, 0 replies; 24+ messages in thread
From: Fabio Estevam @ 2022-08-12 17:50 UTC (permalink / raw)
To: Tim Harvey
Cc: Shawn Guo, NXP Linux Team, Sascha Hauer, Rob Herring,
Krzysztof Kozlowski, Pengutronix Kernel Team, devicetree,
linux-arm-kernel, linux-kernel
Hi Tim,
On Fri, Aug 12, 2022 at 2:35 PM Tim Harvey <tharvey@gateworks.com> wrote:
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> index 521215520a0f..de17021df53f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> @@ -123,8 +123,8 @@ reg_can2_stby: regulator-can2-stby {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_reg_can>;
> regulator-name = "can2_stby";
> - gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
> - enable-active-high;
> + gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
> + enable-active-low;
This 'enable-active-low' property does not exist. Just remove it.
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 1/6] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity
2022-08-12 17:50 ` Fabio Estevam
@ 2022-08-12 18:51 ` Tim Harvey
-1 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-12 18:51 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, NXP Linux Team, Sascha Hauer, Rob Herring,
Krzysztof Kozlowski, Pengutronix Kernel Team, devicetree,
linux-arm-kernel, linux-kernel
On Fri, Aug 12, 2022 at 10:51 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Tim,
>
> On Fri, Aug 12, 2022 at 2:35 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > index 521215520a0f..de17021df53f 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > @@ -123,8 +123,8 @@ reg_can2_stby: regulator-can2-stby {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_reg_can>;
> > regulator-name = "can2_stby";
> > - gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
> > - enable-active-high;
> > + gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
> > + enable-active-low;
>
> This 'enable-active-low' property does not exist. Just remove it.
Fabio,
Thanks - I see now that for active-low you just omit the
'enable-active-high' prop. I will send a new version.
Thanks,
Tim
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 24+ messages in thread* Re: [PATCH 1/6] arm64: dts: imx8mp-venice-gw74xx: fix CAN STBY polarity
@ 2022-08-12 18:51 ` Tim Harvey
0 siblings, 0 replies; 24+ messages in thread
From: Tim Harvey @ 2022-08-12 18:51 UTC (permalink / raw)
To: Fabio Estevam
Cc: Shawn Guo, NXP Linux Team, Sascha Hauer, Rob Herring,
Krzysztof Kozlowski, Pengutronix Kernel Team, devicetree,
linux-arm-kernel, linux-kernel
On Fri, Aug 12, 2022 at 10:51 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Tim,
>
> On Fri, Aug 12, 2022 at 2:35 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > index 521215520a0f..de17021df53f 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > @@ -123,8 +123,8 @@ reg_can2_stby: regulator-can2-stby {
> > pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_reg_can>;
> > regulator-name = "can2_stby";
> > - gpio = <&gpio3 19 GPIO_ACTIVE_HIGH>;
> > - enable-active-high;
> > + gpio = <&gpio3 19 GPIO_ACTIVE_LOW>;
> > + enable-active-low;
>
> This 'enable-active-low' property does not exist. Just remove it.
Fabio,
Thanks - I see now that for active-low you just omit the
'enable-active-high' prop. I will send a new version.
Thanks,
Tim
^ permalink raw reply [flat|nested] 24+ messages in thread