Re: [PATCH v3 09/14] ASoC: dt-bindings:: qcom,q6asm: convert to dtschema

[Rob Herring <robh@kernel.org>]

On Thu, 08 Sep 2022 11:19:41 +0200, Krzysztof Kozlowski wrote:
> Convert Qualcomm Audio Stream Manager (Q6ASM) bindings to DT schema.
> 
> The original bindings documented:
> 1. APR service node with compatibles: "qcom,q6asm" and
>    "qcom,q6asm-v<MAJOR-NUMBER>.<MINOR-NUMBER>",
> 2. actual DAIs child node with compatible "qcom,q6asm-dais".
> 
> The conversion entirely drops (1) because the compatible is already
> documented in bindings/soc/qcom/qcom,apr.yaml.  The
> "qcom,q6asm-v<MAJOR-NUMBER>.<MINOR-NUMBER>" on the other hand is not
> used at all - neither in existing DTS, nor in downstream sources - so
> versions seems to be fully auto-detectable.
> 
> Another change done in conversion is adding "iommus" property, which is
> already used in DTS and Linux driver.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Expected warning because the qcom,apr.yaml is being fixed in next commit:
> 
>   Documentation/devicetree/bindings/sound/qcom,q6asm.example.dtb: apr: service@7: 'dais' does not match any of the regexes: '^.*@[0-9a-f]+$', 'pinctrl-[0-9]+'
>     From schema: /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml
> 
> Changes since v2:
> 1. Rename to qcom,q6asm-dais.yaml (Rob)
> 2. Extend commit msg.
> 
> Changes since v1:
> 1. New patch.
> ---
>  .../bindings/sound/qcom,q6asm-dais.yaml       | 112 ++++++++++++++++++
>  .../devicetree/bindings/sound/qcom,q6asm.txt  |  70 -----------
>  2 files changed, 112 insertions(+), 70 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm-dais.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.txt
> 

Reviewed-by: Rob Herring <robh@kernel.org>