All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
	linux-rockchip@lists.infradead.org, philipp.tomsich@vrull.eu,
	linux-arm-kernel@lists.infradead.org,
	krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
	linux-pwm@vger.kernel.org, kever.yang@rock-chips.com,
	zhangqing@rock-chips.com, linux-kernel@vger.kernel.org,
	heiko@sntech.de
Subject: Re: [PATCH v1 03/11] dt-bindings: pwm: rockchip: add rockchip,rk3128-pwm
Date: Mon, 12 Sep 2022 11:21:59 -0500	[thread overview]
Message-ID: <20220912162159.GA1397560-robh@kernel.org> (raw)
In-Reply-To: <1c13181b-8421-69d8-21ee-9742dd5f55dd@gmail.com>

On Sat, Sep 10, 2022 at 09:48:04PM +0200, Johan Jonker wrote:
> Reduced CC.
> 
> Hi Rob,
> 

Seemed like a simple enough warning to fix...

> The rk3328 and rv1108 PWM interrupt is chaired between blocks I think.
> For rv1108 the same interrupt is used for all PWM nodes.
> For rk3328 only added to one PWM node.
> Currently not in use in a Linux drivers??

How is that relevant to the binding? It's used in dts files.

> 
> No consensus yet...on removing or parent node, so it stays as it is...
> Maybe if you have ideas things will change. ;)

Only that existing issues should be addressed before adding new 
platforms especially if the binding might change in an incompatible way 
(splitting nodes).

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
	linux-rockchip@lists.infradead.org, philipp.tomsich@vrull.eu,
	linux-arm-kernel@lists.infradead.org,
	krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
	linux-pwm@vger.kernel.org, kever.yang@rock-chips.com,
	zhangqing@rock-chips.com, linux-kernel@vger.kernel.org,
	heiko@sntech.de
Subject: Re: [PATCH v1 03/11] dt-bindings: pwm: rockchip: add rockchip,rk3128-pwm
Date: Mon, 12 Sep 2022 11:21:59 -0500	[thread overview]
Message-ID: <20220912162159.GA1397560-robh@kernel.org> (raw)
In-Reply-To: <1c13181b-8421-69d8-21ee-9742dd5f55dd@gmail.com>

On Sat, Sep 10, 2022 at 09:48:04PM +0200, Johan Jonker wrote:
> Reduced CC.
> 
> Hi Rob,
> 

Seemed like a simple enough warning to fix...

> The rk3328 and rv1108 PWM interrupt is chaired between blocks I think.
> For rv1108 the same interrupt is used for all PWM nodes.
> For rk3328 only added to one PWM node.
> Currently not in use in a Linux drivers??

How is that relevant to the binding? It's used in dts files.

> 
> No consensus yet...on removing or parent node, so it stays as it is...
> Maybe if you have ideas things will change. ;)

Only that existing issues should be addressed before adding new 
platforms especially if the binding might change in an incompatible way 
(splitting nodes).

Rob

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Johan Jonker <jbx6244@gmail.com>
Cc: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
	linux-rockchip@lists.infradead.org, philipp.tomsich@vrull.eu,
	linux-arm-kernel@lists.infradead.org,
	krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
	linux-pwm@vger.kernel.org, kever.yang@rock-chips.com,
	zhangqing@rock-chips.com, linux-kernel@vger.kernel.org,
	heiko@sntech.de
Subject: Re: [PATCH v1 03/11] dt-bindings: pwm: rockchip: add rockchip,rk3128-pwm
Date: Mon, 12 Sep 2022 11:21:59 -0500	[thread overview]
Message-ID: <20220912162159.GA1397560-robh@kernel.org> (raw)
In-Reply-To: <1c13181b-8421-69d8-21ee-9742dd5f55dd@gmail.com>

On Sat, Sep 10, 2022 at 09:48:04PM +0200, Johan Jonker wrote:
> Reduced CC.
> 
> Hi Rob,
> 

Seemed like a simple enough warning to fix...

> The rk3328 and rv1108 PWM interrupt is chaired between blocks I think.
> For rv1108 the same interrupt is used for all PWM nodes.
> For rk3328 only added to one PWM node.
> Currently not in use in a Linux drivers??

How is that relevant to the binding? It's used in dts files.

> 
> No consensus yet...on removing or parent node, so it stays as it is...
> Maybe if you have ideas things will change. ;)

Only that existing issues should be addressed before adding new 
platforms especially if the binding might change in an incompatible way 
(splitting nodes).

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-09-12 16:22 UTC|newest]

Thread overview: 186+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220909212543.17428-1-jbx6244@gmail.com>
2022-09-09 22:01 ` [PATCH v1 11/11] dt-bindings: mtd: rockchip: add rockchip,rk3128-nfc Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-10  7:46   ` Krzysztof Kozlowski
2022-09-10  7:46     ` Krzysztof Kozlowski
2022-09-10  7:46     ` Krzysztof Kozlowski
2022-09-10  7:46     ` Krzysztof Kozlowski
2022-09-10  7:46     ` Krzysztof Kozlowski
2022-09-09 22:01 ` [PATCH v1 01/11] dt-bindings: serial: rockchip: add rockchip,rk3128-uart Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-10 15:42   ` (subset) " Mark Brown
2022-09-10 15:42     ` Mark Brown
2022-09-10 15:42     ` Mark Brown
2022-09-10 15:42     ` Mark Brown
2022-09-10 15:42     ` Mark Brown
2022-09-13 14:05   ` Rob Herring
2022-09-13 14:05     ` Rob Herring
2022-09-13 14:05     ` Rob Herring
2022-09-13 14:05     ` Rob Herring
2022-09-13 14:05     ` Rob Herring
2022-09-13 14:37   ` Jamie Iles
2022-09-13 14:37     ` Jamie Iles
2022-09-13 14:37     ` Jamie Iles
2022-09-13 14:37     ` Jamie Iles
2022-09-13 14:37     ` Jamie Iles
2022-09-14  8:52   ` (subset) " Heiko Stuebner
2022-09-14  8:52     ` Heiko Stuebner
2022-09-14  8:52     ` Heiko Stuebner
2022-09-14  8:52     ` Heiko Stuebner
2022-09-14  8:52     ` Heiko Stuebner
2022-09-09 22:01 ` [PATCH v1 10/11] dt-bindings: soc: rockchip: grf: add rockchip,rk3128-grf Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-13 14:06   ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-09 22:01 ` [PATCH v1 09/11] dt-bindings: phy: phy-rockchip-inno-usb2: add rockchip,rk3128-usb2phy Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-13 14:06   ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 16:42   ` Vinod Koul
2022-09-13 16:42     ` Vinod Koul
2022-09-13 16:42     ` Vinod Koul
2022-09-13 16:42     ` Vinod Koul
2022-09-13 16:42     ` Vinod Koul
2022-09-09 22:01 ` [PATCH v1 08/11] dt-bindings: arm: rockchip: pmu: add rockchip,rk3128-pmu Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-13 14:06   ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-09 22:01 ` [PATCH v1 07/11] dt-bindings: watchdog: rockchip: add rockchip,rk3128-wdt Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-09 22:01   ` Johan Jonker
2022-09-10 14:30   ` Guenter Roeck
2022-09-10 14:30     ` Guenter Roeck
2022-09-10 14:30     ` Guenter Roeck
2022-09-10 14:30     ` Guenter Roeck
2022-09-10 14:30     ` Guenter Roeck
2022-09-13 14:06   ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-09 22:02 ` [PATCH v1 06/11] dt-bindings: usb: dwc2: rockchip: add rockchip,rk3128-usb Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-13 14:06   ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-13 14:06     ` Rob Herring
2022-09-09 22:02 ` [PATCH v1 05/11] dt-bindings: spi: rockchip: add rockchip,rk3128-spi Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-10 14:53   ` Rob Herring
2022-09-10 14:53     ` Rob Herring
2022-09-10 14:53     ` Rob Herring
2022-09-10 14:53     ` Rob Herring
2022-09-10 14:53     ` Rob Herring
2022-09-09 22:02 ` [PATCH v1 04/11] dt-bindings: mmc: rockchip: add rockchip,rk3128-dw-mshc Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-13 14:15   ` Rob Herring
2022-09-13 14:15     ` Rob Herring
2022-09-13 14:15     ` Rob Herring
2022-09-13 14:15     ` Rob Herring
2022-09-13 14:15     ` Rob Herring
2022-09-14 14:00   ` Ulf Hansson
2022-09-14 14:00     ` Ulf Hansson
2022-09-14 14:00     ` Ulf Hansson
2022-09-14 14:00     ` Ulf Hansson
2022-09-14 14:00     ` Ulf Hansson
2022-09-09 22:02 ` [PATCH v1 03/11] dt-bindings: pwm: rockchip: add rockchip,rk3128-pwm Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-10 14:53   ` Rob Herring
2022-09-10 14:53     ` Rob Herring
2022-09-10 14:53     ` Rob Herring
2022-09-10 14:53     ` Rob Herring
2022-09-10 14:53     ` Rob Herring
2022-09-10 19:48     ` Johan Jonker
2022-09-10 19:48       ` Johan Jonker
2022-09-10 19:48       ` Johan Jonker
2022-09-12 16:21       ` Rob Herring [this message]
2022-09-12 16:21         ` Rob Herring
2022-09-12 16:21         ` Rob Herring
2022-09-13 14:38         ` Johan Jonker
2022-09-13 14:38           ` Johan Jonker
2022-09-13 14:38           ` Johan Jonker
2022-09-28 11:59           ` Thierry Reding
2022-09-28 11:59             ` Thierry Reding
2022-09-28 11:59             ` Thierry Reding
2022-09-29 10:26             ` Johan Jonker
2022-09-29 10:26               ` Johan Jonker
2022-09-29 10:26               ` Johan Jonker
2022-09-29 15:41               ` Robin Murphy
2022-09-29 15:41                 ` Robin Murphy
2022-09-29 15:41                 ` Robin Murphy
2022-09-30  6:13             ` Biju Das
2022-09-30  6:13               ` Biju Das
2022-09-30  6:13               ` Biju Das
2022-09-12  8:35   ` Uwe Kleine-König
2022-09-12  8:35     ` Uwe Kleine-König
2022-09-12  8:35     ` Uwe Kleine-König
2022-09-12  8:35     ` Uwe Kleine-König
2022-09-12  8:35     ` Uwe Kleine-König
2022-09-13 14:26   ` Rob Herring
2022-09-13 14:26     ` Rob Herring
2022-09-13 14:26     ` Rob Herring
2022-09-13 14:26     ` Rob Herring
2022-09-13 14:26     ` Rob Herring
2022-09-20  6:21   ` Uwe Kleine-König
2022-09-20  6:21     ` Uwe Kleine-König
2022-09-20  6:21     ` Uwe Kleine-König
2022-09-20  6:21     ` Uwe Kleine-König
2022-09-20  6:21     ` Uwe Kleine-König
2022-09-23 10:22     ` Heiko Stuebner
2022-09-23 10:22       ` Heiko Stuebner
2022-09-23 10:22       ` Heiko Stuebner
2022-09-23 10:22       ` Heiko Stuebner
2022-09-23 10:22       ` Heiko Stuebner
2022-09-09 22:02 ` [PATCH v1 02/11] dt-bindings: i2c: rockchip: add rockchip,rk3128-i2c Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-09 22:02   ` Johan Jonker
2022-09-13 14:26   ` Rob Herring
2022-09-13 14:26     ` Rob Herring
2022-09-13 14:26     ` Rob Herring
2022-09-13 14:26     ` Rob Herring
2022-09-13 14:26     ` Rob Herring
2022-09-16 19:57   ` Wolfram Sang
2022-09-16 19:57     ` Wolfram Sang
2022-09-16 19:57     ` Wolfram Sang
2022-09-16 19:57     ` Wolfram Sang
2022-09-16 19:57     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220912162159.GA1397560-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jbx6244@gmail.com \
    --cc=kever.yang@rock-chips.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=philipp.tomsich@vrull.eu \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=zhangqing@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.