[PATCH] vgremove: PVID file leakage in /run/lvm/pvs_online

[David Teigland <teigland@redhat.com>]

Hi, a patch for this is here:
https://sourceware.org/git/?p=lvm2.git;a=commit;h=0887896847807e159a70edc5ac92a4030c13923a

Dave

On Sat, Sep 10, 2022 at 01:56:59AM +0000, liuzhiqiang (I) wrote:
> Thanks for your reply.
> /run dir is mounted as tmpfs type, which has a setting inode number by systemd service. If the number of leakage pvid files increases with time, it may cause Deny of Service for other apps because cannot create files in /run.
> 
> ????David Teigland <teigland@redhat.com>
> ????LVM2 development <lvm-devel@redhat.com>
> ????zkabelac <zkabelac@redhat.com>;linfeilong <linfeilong@huawei.com>;wuguanghao <wuguanghao3@huawei.com>;liuzhiqiang (I) <liuzhiqiang26@huawei.com>
> ????2022-09-09 22:27:45
> ????Re: [lvm-devel] [PATCH] vgremove: PVID file leakage in /run/lvm/pvs_online
> 
> On Thu, Sep 08, 2022 at 10:03:40PM +0800, miaoguanqin wrote:
> > We found PVID file leakage problem when exec the following test;
> > pvcreate /dev/sdb
> > vgcreate -s 1M docker /dev/sdb
> > lvcreate -L 10M docker
> > pvscan --cache --listvg --checkcomplete --vgonline --udevoutput
> > --journal=output /dev/sdb
> > vgremove -ff docker
> >
> > pvcreate operation generates a new PVID, which is used to create PVID pvid
> > file
> > when exec pvcan. However vgremove does not delete the old PVID file.
> >
> > Here, we will delete all PVID files of each pv in current vg, when exec
> > vgremove.
> 
> Hi, these files are located in tmpfs, so they will disappear automatically
> when the system reboots. Is there a reason that you want remove them in
> vgremove instead of waiting for reboot to remove them?