From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Helmut Schaa <helmut.schaa@googlemail.com>,
Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] wifi: rt2x00: Fix "Error - Attempt to send packet over invalid queue 2"
Date: Thu, 15 Sep 2022 20:56:08 +0200 [thread overview]
Message-ID: <20220915185608.GA10590@wp.pl> (raw)
In-Reply-To: <20220908173618.155291-2-hdegoede@redhat.com>
On Thu, Sep 08, 2022 at 07:36:18PM +0200, Hans de Goede wrote:
> Even though ieee80211_hw.queues is set to 2, the ralink rt2x00 driver
> is seeing tx skbs submitted to it with the queue-id set to 2 / set to
> IEEE80211_AC_BE on a rt2500 card when associating with an access-point.
I'm impressed you have still working rt2500 card :-)
> This causes rt2x00queue_get_tx_queue() to return NULL and the following
> error to be logged: "ieee80211 phy0: rt2x00mac_tx: Error - Attempt to
> send packet over invalid queue 2", after which association with the AP
> fails.
>
> This patch works around this by mapping QID_AC_BE and QID_AC_BK
> to QID_AC_VI when there are only 2 tx_queues.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
next prev parent reply other threads:[~2022-09-15 18:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 17:36 [PATCH 0/1] rt2x00 WA for mac80211 core (BUG?) submitting skb-s with queue-ids >= hw.queues Hans de Goede
2022-09-08 17:36 ` [PATCH 1/1] wifi: rt2x00: Fix "Error - Attempt to send packet over invalid queue 2" Hans de Goede
2022-09-15 18:56 ` Stanislaw Gruszka [this message]
2022-09-16 11:32 ` Hans de Goede
2022-09-19 10:09 ` Kalle Valo
2022-09-15 19:01 ` [PATCH 0/1] rt2x00 WA for mac80211 core (BUG?) submitting skb-s with queue-ids >= hw.queues Stanislaw Gruszka
2022-09-18 14:33 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220915185608.GA10590@wp.pl \
--to=stf_xl@wp.pl \
--cc=hdegoede@redhat.com \
--cc=helmut.schaa@googlemail.com \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.