From: kernel test robot <lkp@intel.com>
To: Jia Zhu <zhujia.zj@bytedance.com>
Cc: linux-erofs@lists.ozlabs.org, llvm@lists.linux.dev,
kbuild-all@lists.01.org
Subject: [xiang-erofs:dev-test 5/6] fs/erofs/fscache.c:535:23: warning: no previous prototype for function 'erofs_fscache_acquire_cookie'
Date: Sun, 18 Sep 2022 16:02:57 +0800 [thread overview]
Message-ID: <202209181550.IB5iSy64-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git dev-test
head: 73ac9605cc83179e0d44a8c64d85ab81d5d7a57e
commit: 0c8acee18add4f65597f6a2a3111256bee50ffc8 [5/6] erofs: Support sharing cookies in the same domain
config: hexagon-randconfig-r025-20220918 (https://download.01.org/0day-ci/archive/20220918/202209181550.IB5iSy64-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git/commit/?id=0c8acee18add4f65597f6a2a3111256bee50ffc8
git remote add xiang-erofs https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
git fetch --no-tags xiang-erofs dev-test
git checkout 0c8acee18add4f65597f6a2a3111256bee50ffc8
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/erofs/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> fs/erofs/fscache.c:535:23: warning: no previous prototype for function 'erofs_fscache_acquire_cookie' [-Wmissing-prototypes]
struct erofs_fscache *erofs_fscache_acquire_cookie(struct super_block *sb,
^
fs/erofs/fscache.c:535:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct erofs_fscache *erofs_fscache_acquire_cookie(struct super_block *sb,
^
static
1 warning generated.
vim +/erofs_fscache_acquire_cookie +535 fs/erofs/fscache.c
534
> 535 struct erofs_fscache *erofs_fscache_acquire_cookie(struct super_block *sb,
536 char *name, bool need_inode)
537 {
538 struct fscache_volume *volume = EROFS_SB(sb)->volume;
539 struct erofs_fscache *ctx;
540 struct fscache_cookie *cookie;
541 int ret;
542
543 ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
544 if (!ctx)
545 return ERR_PTR(-ENOMEM);
546
547 cookie = fscache_acquire_cookie(volume, FSCACHE_ADV_WANT_CACHE_SIZE,
548 name, strlen(name), NULL, 0, 0);
549 if (!cookie) {
550 erofs_err(sb, "failed to get cookie for %s", name);
551 ret = -EINVAL;
552 goto err;
553 }
554
555 fscache_use_cookie(cookie, false);
556 ctx->cookie = cookie;
557
558 if (need_inode) {
559 struct inode *const inode = new_inode(sb);
560
561 if (!inode) {
562 erofs_err(sb, "failed to get anon inode for %s", name);
563 ret = -ENOMEM;
564 goto err_cookie;
565 }
566
567 set_nlink(inode, 1);
568 inode->i_size = OFFSET_MAX;
569 inode->i_mapping->a_ops = &erofs_fscache_meta_aops;
570 mapping_set_gfp_mask(inode->i_mapping, GFP_NOFS);
571
572 ctx->inode = inode;
573 }
574
575 return ctx;
576
577 err_cookie:
578 fscache_unuse_cookie(ctx->cookie, NULL, NULL);
579 fscache_relinquish_cookie(ctx->cookie, false);
580 err:
581 kfree(ctx);
582 return ERR_PTR(ret);
583 }
584
--
0-DAY CI Kernel Test Service
https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Jia Zhu <zhujia.zj@bytedance.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Xiang Gao <xiang@kernel.org>,
linux-erofs@lists.ozlabs.org,
Jingbo Xu <jefflexu@linux.alibaba.com>
Subject: [xiang-erofs:dev-test 5/6] fs/erofs/fscache.c:535:23: warning: no previous prototype for function 'erofs_fscache_acquire_cookie'
Date: Sun, 18 Sep 2022 16:02:57 +0800 [thread overview]
Message-ID: <202209181550.IB5iSy64-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git dev-test
head: 73ac9605cc83179e0d44a8c64d85ab81d5d7a57e
commit: 0c8acee18add4f65597f6a2a3111256bee50ffc8 [5/6] erofs: Support sharing cookies in the same domain
config: hexagon-randconfig-r025-20220918 (https://download.01.org/0day-ci/archive/20220918/202209181550.IB5iSy64-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git/commit/?id=0c8acee18add4f65597f6a2a3111256bee50ffc8
git remote add xiang-erofs https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
git fetch --no-tags xiang-erofs dev-test
git checkout 0c8acee18add4f65597f6a2a3111256bee50ffc8
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/erofs/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> fs/erofs/fscache.c:535:23: warning: no previous prototype for function 'erofs_fscache_acquire_cookie' [-Wmissing-prototypes]
struct erofs_fscache *erofs_fscache_acquire_cookie(struct super_block *sb,
^
fs/erofs/fscache.c:535:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct erofs_fscache *erofs_fscache_acquire_cookie(struct super_block *sb,
^
static
1 warning generated.
vim +/erofs_fscache_acquire_cookie +535 fs/erofs/fscache.c
534
> 535 struct erofs_fscache *erofs_fscache_acquire_cookie(struct super_block *sb,
536 char *name, bool need_inode)
537 {
538 struct fscache_volume *volume = EROFS_SB(sb)->volume;
539 struct erofs_fscache *ctx;
540 struct fscache_cookie *cookie;
541 int ret;
542
543 ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
544 if (!ctx)
545 return ERR_PTR(-ENOMEM);
546
547 cookie = fscache_acquire_cookie(volume, FSCACHE_ADV_WANT_CACHE_SIZE,
548 name, strlen(name), NULL, 0, 0);
549 if (!cookie) {
550 erofs_err(sb, "failed to get cookie for %s", name);
551 ret = -EINVAL;
552 goto err;
553 }
554
555 fscache_use_cookie(cookie, false);
556 ctx->cookie = cookie;
557
558 if (need_inode) {
559 struct inode *const inode = new_inode(sb);
560
561 if (!inode) {
562 erofs_err(sb, "failed to get anon inode for %s", name);
563 ret = -ENOMEM;
564 goto err_cookie;
565 }
566
567 set_nlink(inode, 1);
568 inode->i_size = OFFSET_MAX;
569 inode->i_mapping->a_ops = &erofs_fscache_meta_aops;
570 mapping_set_gfp_mask(inode->i_mapping, GFP_NOFS);
571
572 ctx->inode = inode;
573 }
574
575 return ctx;
576
577 err_cookie:
578 fscache_unuse_cookie(ctx->cookie, NULL, NULL);
579 fscache_relinquish_cookie(ctx->cookie, false);
580 err:
581 kfree(ctx);
582 return ERR_PTR(ret);
583 }
584
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next reply other threads:[~2022-09-18 8:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-18 8:02 kernel test robot [this message]
2022-09-18 8:02 ` [xiang-erofs:dev-test 5/6] fs/erofs/fscache.c:535:23: warning: no previous prototype for function 'erofs_fscache_acquire_cookie' kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209181550.IB5iSy64-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=zhujia.zj@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.