From: Jakub Kicinski <kuba@kernel.org>
To: Li Zhong <floridsleeves@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
edumazet@google.com, intel-wired-lan@lists.osuosl.org,
pabeni@redhat.com, davem@davemloft.net
Subject: Re: [Intel-wired-lan] [PATCH v2] drivers/net/ethernet/intel/e100: check the return value of e100_exec_cmd()
Date: Tue, 20 Sep 2022 11:36:23 -0700 [thread overview]
Message-ID: <20220920113623.2f041e80@kernel.org> (raw)
In-Reply-To: <20220917001027.3799634-1-floridsleeves@gmail.com>
On Fri, 16 Sep 2022 17:10:27 -0700 Li Zhong wrote:
> Check the return value of e100_exec_cmd() which could return error code
> when execution fails.
You need to provide more detailed analysis in the commit message.
Right now it looks like you're just blindly finding cases where
return value is not checked and adding error checks. This is as
likely to fix something as it is to break.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Li Zhong <floridsleeves@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
intel-wired-lan@lists.osuosl.org, pabeni@redhat.com,
edumazet@google.com, davem@davemloft.net,
anthony.l.nguyen@intel.com, jesse.brandeburg@intel.com
Subject: Re: [PATCH v2] drivers/net/ethernet/intel/e100: check the return value of e100_exec_cmd()
Date: Tue, 20 Sep 2022 11:36:23 -0700 [thread overview]
Message-ID: <20220920113623.2f041e80@kernel.org> (raw)
In-Reply-To: <20220917001027.3799634-1-floridsleeves@gmail.com>
On Fri, 16 Sep 2022 17:10:27 -0700 Li Zhong wrote:
> Check the return value of e100_exec_cmd() which could return error code
> when execution fails.
You need to provide more detailed analysis in the commit message.
Right now it looks like you're just blindly finding cases where
return value is not checked and adding error checks. This is as
likely to fix something as it is to break.
next prev parent reply other threads:[~2022-09-20 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 0:10 [Intel-wired-lan] [PATCH v2] drivers/net/ethernet/intel/e100: check the return value of e100_exec_cmd() Li Zhong
2022-09-17 0:10 ` Li Zhong
2022-09-20 18:36 ` Jakub Kicinski [this message]
2022-09-20 18:36 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920113623.2f041e80@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=floridsleeves@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.