From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <simon.horman@corigine.com>
Cc: David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com,
Fei Qin <fei.qin@corigine.com>
Subject: Re: [PATCH net-next 3/3] nfp: add support restart of link auto-negotiation
Date: Thu, 22 Sep 2022 17:54:53 -0700 [thread overview]
Message-ID: <20220922175453.0b7057ac@kernel.org> (raw)
In-Reply-To: <20220921121235.169761-4-simon.horman@corigine.com>
On Wed, 21 Sep 2022 14:12:35 +0200 Simon Horman wrote:
> + err = nfp_port_configure(netdev, false);
> + if (err) {
> + netdev_info(netdev, "Link down failed: %d\n", err);
> + return err;
> + }
> +
> + err = nfp_port_configure(netdev, true);
> + if (err) {
> + netdev_info(netdev, "Link up failed: %d\n", err);
> + return err;
> + }
> +
> + netdev_info(netdev, "Link reset succeeded\n");
> + return 0;
This will not do anything if the port is forced up by multi host
or NC-SI.
next prev parent reply other threads:[~2022-09-23 0:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 12:12 [PATCH net-next 0/3] nfp: support FEC mode reporting and auto-neg Simon Horman
2022-09-21 12:12 ` [PATCH net-next 1/3] nfp: add support for reporting active FEC mode Simon Horman
2022-09-21 12:12 ` [PATCH net-next 2/3] nfp: add support for link auto negotiation Simon Horman
2022-09-23 1:00 ` Jakub Kicinski
2022-09-23 4:37 ` Yinjun Zhang
2022-09-23 13:21 ` Jakub Kicinski
2022-09-23 15:41 ` Yinjun Zhang
2022-09-24 0:24 ` Jakub Kicinski
2022-09-24 2:45 ` Yinjun Zhang
2022-09-26 16:25 ` Jakub Kicinski
2022-09-27 1:13 ` Yinjun Zhang
2022-09-27 1:38 ` Jakub Kicinski
2022-09-27 1:52 ` Yinjun Zhang
2022-09-21 12:12 ` [PATCH net-next 3/3] nfp: add support restart of link auto-negotiation Simon Horman
2022-09-23 0:54 ` Jakub Kicinski [this message]
2022-09-23 4:40 ` Yinjun Zhang
2022-09-23 4:52 ` Yinjun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922175453.0b7057ac@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=fei.qin@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.