From: Jakub Kicinski <kuba@kernel.org>
To: Yinjun Zhang <yinjun.zhang@corigine.com>
Cc: Simon Horman <simon.horman@corigine.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
oss-drivers <oss-drivers@corigine.com>,
Fei Qin <fei.qin@corigine.com>
Subject: Re: [PATCH net-next 2/3] nfp: add support for link auto negotiation
Date: Fri, 23 Sep 2022 06:21:14 -0700 [thread overview]
Message-ID: <20220923062114.7db02bce@kernel.org> (raw)
In-Reply-To: <DM6PR13MB3705B174455A7E5225CAF996FC519@DM6PR13MB3705.namprd13.prod.outlook.com>
On Fri, 23 Sep 2022 04:37:58 +0000 Yinjun Zhang wrote:
> > I can't parse what this is saying but doesn't look good
>
> I think this comment is clear enough. In previous `
> nfp_net_pf_cfg_nsp`, hwinfo "sp_indiff" is configured into Management
> firmware(NSP), and it decides if autoneg is supported or not and
> updates eth table accordingly. And only `CHANGED` flag is set here so
> that with some delay driver can get the updated eth table instead of
> stale info.
Why is the sp_indif thing configured at the nfp_main layer, before
the eth table is read? Doing this inside nfp_net_main seems like
the wrong layering to me.
next prev parent reply other threads:[~2022-09-23 13:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 12:12 [PATCH net-next 0/3] nfp: support FEC mode reporting and auto-neg Simon Horman
2022-09-21 12:12 ` [PATCH net-next 1/3] nfp: add support for reporting active FEC mode Simon Horman
2022-09-21 12:12 ` [PATCH net-next 2/3] nfp: add support for link auto negotiation Simon Horman
2022-09-23 1:00 ` Jakub Kicinski
2022-09-23 4:37 ` Yinjun Zhang
2022-09-23 13:21 ` Jakub Kicinski [this message]
2022-09-23 15:41 ` Yinjun Zhang
2022-09-24 0:24 ` Jakub Kicinski
2022-09-24 2:45 ` Yinjun Zhang
2022-09-26 16:25 ` Jakub Kicinski
2022-09-27 1:13 ` Yinjun Zhang
2022-09-27 1:38 ` Jakub Kicinski
2022-09-27 1:52 ` Yinjun Zhang
2022-09-21 12:12 ` [PATCH net-next 3/3] nfp: add support restart of link auto-negotiation Simon Horman
2022-09-23 0:54 ` Jakub Kicinski
2022-09-23 4:40 ` Yinjun Zhang
2022-09-23 4:52 ` Yinjun Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220923062114.7db02bce@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=fei.qin@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=yinjun.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.