Re: [cocci] spatch --jobs N missing matches?

[Kees Cook <keescook@chromium.org>]

On Mon, Sep 26, 2022 at 11:14:55PM +0200, Julia Lawall wrote:
> I likewise see the following puzzling behavior:

Okay, that's a relief -- I'm usually holding it wrong. :P

> [...]
> So it worked when I tried only one .c file, but not when I tried the whole
> directory.  When I put some tracing (--debug --show-trying) it seems to be
> considering only the .c file in the full directory case, not the header
> file.  I will look into it.

Thank you! If you end up with patches, I'm happy to try them out. I've
got a fresh build of the latest cocci git tree building, so I can easily
test changes.

> In the short term, you could try using the option --selected-only to get a
> list of files considered to be relevant, and then run Coccinelle on each
> of them individually.

Ah-ha! I hadn't noticed --selected-only, that's nicer than my
sorta-by-hand version of just using "git grep memcpy | filter...", but
yes, that's what I ran a while ago. I see it just finished after two
hours. :) But it found (what I hope is) the full set!

--- ./drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c
--- ./drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c
--- ./drivers/platform/surface/surface_acpi_notify.c
--- ./drivers/s390/net/qeth_l2_main.c
--- ./drivers/w1/w1_netlink.c
--- ./fs/dlm/requestqueue.c
--- ./net/sched/cls_u32.c
--- ./net/wireless/nl80211.c

real    111m15.762s

Thanks for taking a look at this!

-- 
Kees Cook