Re: [cocci] spatch --jobs N missing matches?

[Julia Lawall <julia.lawall@inria.fr>]

The running time is cut in half for the command line:

spatch ~/linux-next/fs/dlm flex2.cocci -I ~/linux-next/include

Where flex2.cocci is:

------------

#spatch --recursive-includes --include-headers

// match memcpy() which has a composite flexible array struct as the destination
@memcpy_compflex_dest@
identifier outer, compflex;
struct outer *PTR;
expression SRC, SIZE;
@@

  memcpy(
       &PTR->compflex
  , SRC, SIZE)

// "level2" matches a composite flexible array struct (struct ending with "level1")
@level2@
identifier inner;
identifier memcpy_compflex_dest.outer, memcpy_compflex_dest.compflex;
@@
        struct outer {
                ...
                struct inner compflex;
        };

// "level1" matches a struct ending in a flexible array.
@level1@
identifier level2.inner, flex;
type T;
@@
        struct inner {
                ...
                T flex[];
        };

// match memcpy() which has a composite flexible array struct as the destination
@depends on level1@
identifier memcpy_compflex_dest.outer, memcpy_compflex_dest.compflex;
struct outer *memcpy_compflex_dest.PTR;
expression SRC, SIZE;
@@

  memcpy(
*       &PTR->compflex
  , SRC, SIZE)

------------

Actually, there are not that many memcpys in the considered code.  Then
there are not that many that refer to the last element of a structure.  If
level2 produces nothing, then level 1 should not be applied.

In the original rule order, all of the pairs of a flexible structure and
any structure are considered, regardless of whether any memcpys are
present.

julia