From: Kees Cook <keescook@chromium.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
linux-hardening@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH][next] ASoC: uapi: Replace zero-length arrays with __DECLARE_FLEX_ARRAY() helper
Date: Mon, 26 Sep 2022 19:33:09 -0700 [thread overview]
Message-ID: <202209261932.F68BBD85@keescook> (raw)
In-Reply-To: <YzIzUjUuJKf0mkKg@work>
On Mon, Sep 26, 2022 at 06:18:42PM -0500, Gustavo A. R. Silva wrote:
> Zero-length arrays are deprecated and we are moving towards adopting
> C99 flexible-array members, instead. So, replace zero-length arrays
> declarations in anonymous union with the new __DECLARE_FLEX_ARRAY()
> helper macro.
>
> This helper allows for flexible-array members in unions.
>
> Link: https://github.com/KSPP/linux/issues/193
> Link: https://github.com/KSPP/linux/issues/227
> Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Some day after the __element_count__ attribute exists, we might want to
consider a __type_select__ attribute to tie union members to a variable
outside the union (like the "type" member here).
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] ASoC: uapi: Replace zero-length arrays with __DECLARE_FLEX_ARRAY() helper
Date: Mon, 26 Sep 2022 19:33:09 -0700 [thread overview]
Message-ID: <202209261932.F68BBD85@keescook> (raw)
In-Reply-To: <YzIzUjUuJKf0mkKg@work>
On Mon, Sep 26, 2022 at 06:18:42PM -0500, Gustavo A. R. Silva wrote:
> Zero-length arrays are deprecated and we are moving towards adopting
> C99 flexible-array members, instead. So, replace zero-length arrays
> declarations in anonymous union with the new __DECLARE_FLEX_ARRAY()
> helper macro.
>
> This helper allows for flexible-array members in unions.
>
> Link: https://github.com/KSPP/linux/issues/193
> Link: https://github.com/KSPP/linux/issues/227
> Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Some day after the __element_count__ attribute exists, we might want to
consider a __type_select__ attribute to tie union members to a variable
outside the union (like the "type" member here).
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2022-09-27 2:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 23:18 [PATCH][next] ASoC: uapi: Replace zero-length arrays with __DECLARE_FLEX_ARRAY() helper Gustavo A. R. Silva
2022-09-26 23:18 ` Gustavo A. R. Silva
2022-09-27 2:33 ` Kees Cook [this message]
2022-09-27 2:33 ` Kees Cook
2022-09-27 7:37 ` Amadeusz Sławiński
2023-02-02 20:34 ` Gustavo A. R. Silva
2023-02-02 21:09 ` Mark Brown
2023-02-02 21:09 ` Mark Brown
2023-02-02 21:18 ` Gustavo A. R. Silva
2023-02-02 21:18 ` Gustavo A. R. Silva
2023-02-03 12:57 ` Mark Brown
2023-02-03 12:57 ` Mark Brown
2023-02-03 13:27 ` Gustavo A. R. Silva
2023-02-03 13:27 ` Gustavo A. R. Silva
2023-02-03 13:45 ` Mark Brown
2023-02-03 13:45 ` Mark Brown
2023-02-03 13:50 ` Gustavo A. R. Silva
2023-02-03 13:50 ` Gustavo A. R. Silva
2023-02-03 16:29 ` Kees Cook
2023-02-03 16:29 ` Kees Cook
2023-02-03 18:36 ` Mark Brown
2023-02-03 18:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202209261932.F68BBD85@keescook \
--to=keescook@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=gustavoars@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.