All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 02/13] phy: qcom-qmp-combo: drop unused UFS reset
Date: Wed, 28 Sep 2022 17:28:11 +0200	[thread overview]
Message-ID: <20220928152822.30687-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20220928152822.30687-1-johan+linaro@kernel.org>

Drop the unused UFS reset code which isn't used since the QMP driver
split.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
index 0cf1eb8a62f6..e618e675e8ec 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
@@ -944,7 +944,6 @@ struct qmp_phy_dp_clks {
  * @phys: array of per-lane phy descriptors
  * @phy_mutex: mutex lock for PHY common block initialization
  * @init_count: phy common block initialization count
- * @ufs_reset: optional UFS PHY reset handle
  */
 struct qcom_qmp {
 	struct device *dev;
@@ -958,8 +957,6 @@ struct qcom_qmp {
 
 	struct mutex phy_mutex;
 	int init_count;
-
-	struct reset_control *ufs_reset;
 };
 
 static void qcom_qmp_v3_phy_dp_aux_init(struct qmp_phy *qphy);
@@ -2027,8 +2024,6 @@ static int qmp_combo_com_exit(struct qmp_phy *qphy)
 		return 0;
 	}
 
-	reset_control_assert(qmp->ufs_reset);
-
 	reset_control_bulk_assert(cfg->num_resets, qmp->resets);
 
 	clk_bulk_disable_unprepare(cfg->num_clks, qmp->clks);
@@ -2103,10 +2098,6 @@ static int qmp_combo_power_on(struct phy *phy)
 	else
 		qmp_combo_configure(pcs, cfg->regs, cfg->pcs_tbl, cfg->pcs_tbl_num);
 
-	ret = reset_control_deassert(qmp->ufs_reset);
-	if (ret)
-		goto err_disable_pipe_clk;
-
 	if (cfg->has_pwrdn_delay)
 		usleep_range(cfg->pwrdn_delay_min, cfg->pwrdn_delay_max);
 
-- 
2.35.1


WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 02/13] phy: qcom-qmp-combo: drop unused UFS reset
Date: Wed, 28 Sep 2022 17:28:11 +0200	[thread overview]
Message-ID: <20220928152822.30687-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20220928152822.30687-1-johan+linaro@kernel.org>

Drop the unused UFS reset code which isn't used since the QMP driver
split.

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
index 0cf1eb8a62f6..e618e675e8ec 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c
@@ -944,7 +944,6 @@ struct qmp_phy_dp_clks {
  * @phys: array of per-lane phy descriptors
  * @phy_mutex: mutex lock for PHY common block initialization
  * @init_count: phy common block initialization count
- * @ufs_reset: optional UFS PHY reset handle
  */
 struct qcom_qmp {
 	struct device *dev;
@@ -958,8 +957,6 @@ struct qcom_qmp {
 
 	struct mutex phy_mutex;
 	int init_count;
-
-	struct reset_control *ufs_reset;
 };
 
 static void qcom_qmp_v3_phy_dp_aux_init(struct qmp_phy *qphy);
@@ -2027,8 +2024,6 @@ static int qmp_combo_com_exit(struct qmp_phy *qphy)
 		return 0;
 	}
 
-	reset_control_assert(qmp->ufs_reset);
-
 	reset_control_bulk_assert(cfg->num_resets, qmp->resets);
 
 	clk_bulk_disable_unprepare(cfg->num_clks, qmp->clks);
@@ -2103,10 +2098,6 @@ static int qmp_combo_power_on(struct phy *phy)
 	else
 		qmp_combo_configure(pcs, cfg->regs, cfg->pcs_tbl, cfg->pcs_tbl_num);
 
-	ret = reset_control_deassert(qmp->ufs_reset);
-	if (ret)
-		goto err_disable_pipe_clk;
-
 	if (cfg->has_pwrdn_delay)
 		usleep_range(cfg->pwrdn_delay_min, cfg->pwrdn_delay_max);
 
-- 
2.35.1


-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

  parent reply	other threads:[~2022-09-28 15:29 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 15:28 [PATCH 00/13] phy: qcom-qmp: more fixes and cleanups Johan Hovold
2022-09-28 15:28 ` Johan Hovold
2022-09-28 15:28 ` [PATCH 01/13] phy: qcom-qmp: fix obsolete lane comments Johan Hovold
2022-09-28 15:28   ` Johan Hovold
2022-09-28 15:56   ` Neil Armstrong
2022-09-28 15:56     ` Neil Armstrong
2022-09-28 17:26   ` Dmitry Baryshkov
2022-09-28 17:26     ` Dmitry Baryshkov
2022-09-28 15:28 ` Johan Hovold [this message]
2022-09-28 15:28   ` [PATCH 02/13] phy: qcom-qmp-combo: drop unused UFS reset Johan Hovold
2022-09-28 16:04   ` Neil Armstrong
2022-09-28 16:04     ` Neil Armstrong
2022-09-28 17:25   ` Dmitry Baryshkov
2022-09-28 17:25     ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 03/13] phy: qcom-qmp-pcie: drop unused common-block registers Johan Hovold
2022-09-28 15:28   ` Johan Hovold
2022-09-28 16:03   ` Neil Armstrong
2022-09-28 16:03     ` Neil Armstrong
2022-09-28 17:23   ` Dmitry Baryshkov
2022-09-28 17:23     ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 04/13] phy: qcom-qmp-pcie: unify ipq registers Johan Hovold
2022-09-28 15:28   ` Johan Hovold
2022-09-28 15:57   ` Neil Armstrong
2022-09-28 15:57     ` Neil Armstrong
2022-09-28 17:34   ` Dmitry Baryshkov
2022-09-28 17:34     ` Dmitry Baryshkov
2022-09-29  6:53     ` Johan Hovold
2022-09-29  6:53       ` Johan Hovold
2022-09-28 15:28 ` [PATCH 05/13] phy: qcom-qmp-pcie: unify sdm845 registers Johan Hovold
2022-09-28 15:28   ` Johan Hovold
2022-09-28 16:01   ` Neil Armstrong
2022-09-28 16:01     ` Neil Armstrong
2022-09-28 16:03     ` Neil Armstrong
2022-09-28 16:03       ` Neil Armstrong
2022-09-28 19:11   ` Dmitry Baryshkov
2022-09-28 19:11     ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 06/13] phy: qcom-qmp-pcie: drop bogus register update Johan Hovold
2022-09-28 15:28   ` Johan Hovold
2022-09-28 19:10   ` Dmitry Baryshkov
2022-09-28 19:10     ` Dmitry Baryshkov
2022-09-28 19:48     ` Dmitry Baryshkov
2022-09-28 19:48       ` Dmitry Baryshkov
2022-09-29  7:12       ` Johan Hovold
2022-09-29  7:12         ` Johan Hovold
2022-09-29  7:56         ` Dmitry Baryshkov
2022-09-29  7:56           ` Dmitry Baryshkov
2022-09-29  8:18           ` Johan Hovold
2022-09-29  8:18             ` Johan Hovold
2022-09-29  6:56     ` Johan Hovold
2022-09-29  6:56       ` Johan Hovold
2022-09-28 15:28 ` [PATCH 07/13] phy: qcom-qmp-pcie: clean up power-down handling Johan Hovold
2022-09-28 15:28   ` Johan Hovold
2022-09-28 19:15   ` Dmitry Baryshkov
2022-09-28 19:15     ` Dmitry Baryshkov
2022-09-29  7:25     ` Johan Hovold
2022-09-29  7:25       ` Johan Hovold
2022-09-29  7:30       ` Dmitry Baryshkov
2022-09-29  7:30         ` Dmitry Baryshkov
2022-09-29  9:04         ` Johan Hovold
2022-09-29  9:04           ` Johan Hovold
2022-09-29  9:07           ` Dmitry Baryshkov
2022-09-29  9:07             ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 08/13] phy: qcom-qmp-pcie: move power-down update Johan Hovold
2022-09-28 15:28   ` Johan Hovold
2022-09-28 15:28 ` [PATCH 09/13] phy: qcom-qmp-pcie-msm8996: clean up power-down handling Johan Hovold
2022-09-28 15:28   ` Johan Hovold
2022-09-28 19:52   ` Dmitry Baryshkov
2022-09-28 19:52     ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 10/13] phy: qcom-qmp-combo: " Johan Hovold
2022-09-28 15:28   ` Johan Hovold
2022-09-28 19:53   ` Dmitry Baryshkov
2022-09-28 19:53     ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 11/13] phy: qcom-qmp-ufs: " Johan Hovold
2022-09-28 15:28   ` Johan Hovold
2022-09-28 19:53   ` Dmitry Baryshkov
2022-09-28 19:53     ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 12/13] phy: qcom-qmp-usb: " Johan Hovold
2022-09-28 15:28   ` Johan Hovold
2022-09-28 19:53   ` Dmitry Baryshkov
2022-09-28 19:53     ` Dmitry Baryshkov
2022-09-28 15:28 ` [PATCH 13/13] phy: qcom-qmp-pcie: clean up clock lists Johan Hovold
2022-09-28 15:28   ` Johan Hovold
2022-09-28 19:54   ` Dmitry Baryshkov
2022-09-28 19:54     ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220928152822.30687-3-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=kishon@ti.com \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.